Skip to content
Snippets Groups Projects
  1. Jan 08, 2018
  2. Jan 03, 2018
  3. Jan 02, 2018
  4. Dec 31, 2017
    • Sean Bright's avatar
      ice: Increase foundation buffer size · 15f8b9b8
      Sean Bright authored
      Per RFC 5245, the foundation specified with an ICE candidate can be up
      to 32 characters but we are only allowing for 31.
      
      ASTERISK-27498 #close
      Reported by: Michele Prà
      
      Change-Id: I05ce7a5952721a76a2b4c90366168022558dc7cf
      15f8b9b8
  5. Dec 30, 2017
  6. Dec 29, 2017
  7. Dec 28, 2017
    • Richard Mudgett's avatar
      stasis_channels.c: Misc cleanup. · 2dde5bef
      Richard Mudgett authored
      * Use current OBJ_SEARCH_xxx defines instead of the deprecated versions.
      
      * Fix hash_cb and cmp_cb container functions to correctly use the
      OBJ_SEARCH_xxx values.
      
      * Remove incorrect usage of CMP_STOP.  Most uses in the system have no
      effect.  This allows the collapse of channel_role_single_cmp_cb() and
      channel_role_multi_cmp_cb() into channel_role_cmp_cb().
      
      * Remove unnecessary usage of RAII_VAR().
      
      Change-Id: I02c405518cab22aa2a082b61e2353bf7cd629a70
      2dde5bef
    • Jenkins2's avatar
      0d9968e0
    • Richard Mudgett's avatar
    • Jenkins2's avatar
      Merge "astobj.h: Remove from Asterisk core." · 43e70525
      Jenkins2 authored
      43e70525
    • Jenkins2's avatar
      Merge "cdr: Missing NULL check and unlock." · 50cf373b
      Jenkins2 authored
      50cf373b
    • Sean Bright's avatar
      cdr_mysql: Make sure connection charset is always set · 898b3b08
      Sean Bright authored
      When the MYSQL_OPT_RECONNECT option is enabled, the MySQL client API
      will transparently reconnect when it needs to. Ideally this simplifies
      our code, but when this reconnection occurs all connection state is
      lost. Because we are not notified that this has happened, we don't know
      to set our character set again (with "SET NAMES 'xyz'").
      
      Rather than calling SET NAMES, we instead set the MYSQL_SET_CHARSET_NAME
      option which will do it for us under the hood on each connect. This
      option has been present in the MySQL C API for at least 15 years, so it
      should be safe for most installations.
      
      I also snuck a few other changes into this patch:
      
      * Default the MySQL port to MYSQL_PORT (3306) instead of 0 if it's not
        defined.
      
      * Fix some erroneous and/or silly checks on the contents of the
        configuration ast_str values.
      
      ASTERISK-27366 #close
      Reported by: Halil İbrahim YILDIZ
      
      Change-Id: I36bf8dc5d5f83584e803b3b1a151dea9396ab8f5
      898b3b08
    • Richard Mudgett's avatar
      manager.c: Update AMI Status event documentation · d69b7c6c
      Richard Mudgett authored
      The AMI Status event had linkedid listed twice and was missing the
      effective connected line name and number headers.
      
      NOTE: The linkedid and other standard channel snapshot fields in the XML
      documentation are part of the <channel_snapshot/> XML template defined in
      doc/appdocsxml.xslt.
      
      Change-Id: I004c4c4f9e7b40ef55035c831702721bec82496c
      d69b7c6c
    • Richard Mudgett's avatar
      bridge_native_rtp.c: Fix reentrancy framehook crash. · fa36f9c0
      Richard Mudgett authored
      If two channels enter different native rtp bridges at the same time it is
      possible that the framehook interface data pointer can be corrupted
      because the struct variable was declared static.
      
      * Fixed the reentrancy corruption by changing the framehook interface
      struct static variable to a stack local variable.
      
      * Moved the hook.data assignment outside of the channel lock.  It did not
      need the lock's protection.  It probably was giving a false sense of
      security.
      
      The testsuite
      channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/bob_hangs_up
      test caught this with MALLOC_DEBUG and DO_CRASH enabled.
      
      Change-Id: If9e35b97d19209b0f984941c1d8eb5f7c55eea91
      fa36f9c0
    • Richard Mudgett's avatar
      func_channel.c: Update MASTER_CHANNEL documentation · 1d3dc9ae
      Richard Mudgett authored
      Be more explicit in what is meant by the master channel to eliminate
      misunderstanding.
      
      ASTERISK-23133
      
      Change-Id: I453bcaf4b99404a5a3e345dbf093ac6c1afcfc72
      1d3dc9ae
    • Corey Farrell's avatar
      menuselect: Fix check for running configure. · 6338a03c
      Corey Farrell authored
      menuselect/Makefile checks that autoconfig.h and makeopts were newer
      than the '.in' files.  Unfortunately running ./configure does not touch
      autoconfig.h unless the contents will change.
      
      Instead of looking at autoconfig.h we just need to ensure that makeopts
      is newer than configure.
      
      Also make change to configure.ac so bootstrap.sh doesn't re-add the
      extra trailing line-feed.
      
      Change-Id: Ief1f831d6717007f9cebb668c14e92782cd2b794
      6338a03c
  8. Dec 26, 2017
    • Corey Farrell's avatar
      cdr: Missing NULL check and unlock. · 94eb12ca
      Corey Farrell authored
      * handle_dial_message: Missing a check for NULL peer.
      * cdr_generic_register: Missing unlock on allocation failure.
      
      cdr_generic_register is fixed by reordering so the new structure is
      allocated and initialized before locking the list.
      
      Change-Id: I5799b99270d1a7a716a555c31ac85f4b00ce8686
      94eb12ca
  9. Dec 24, 2017
    • Corey Farrell's avatar
      loader: Add volatile to resource_being_loaded. · 23aa20bf
      Corey Farrell authored
      Some compiler optimizers seem to assume that dlopen will not use
      __attribute__((constructor)) functions to call back to the program.
      This was causing resource_being_loaded to be optimized away completely.
      
      ASTERISK-27531 #close
      Tested By: abelbeck
      
      Change-Id: If17a3b889e06811a0e7119f0539d052494d6ece9
      23aa20bf
  10. Dec 22, 2017
  11. Dec 21, 2017
  12. Dec 20, 2017
Loading