Skip to content
Snippets Groups Projects

RM14593, Changed maxptime to 20 ms to follow DT requirements

Merged RM14593, Changed maxptime to 20 ms to follow DT requirements
RM14593_maxptime into asterisk_rdkb
1 unresolved thread
Merged Michael Gustavsson requested to merge RM14593_maxptime into asterisk_rdkb
1 unresolved thread

Merge request reports

Approval is optional

Merged by Yalu ZhangYalu Zhang 9 months ago (Jun 11, 2024 2:53pm UTC)

Merge details

  • Changes merged into asterisk_rdkb with 70923b73 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
main/codec_builtin.c
169 169 .type = AST_MEDIA_TYPE_AUDIO,
170 170 .sample_rate = 8000,
171 171 .minimum_ms = 10,
172 .maximum_ms = 150,
172 .maximum_ms = 20, /* Changed according to DT requirements */
  • Yalu Zhang
    Yalu Zhang @Yalu ·
    Maintainer

    maximum_ms here defines the maximum ptime supported by Asterisk as its capacity. DT actually complain that the wrong ptime is offered in an outgoing INVITE by Asterisk if I understand correctly from the ticket. The offered ptime is determined by below configuration that we support now. So this patch shall not be needed.

    asterisk.g722.ptime='20'

  • Michael Gustavsson
    Michael Gustavsson @migu ·
    Author Developer

    Their only complaint is about maxptime which is set to 150 ms by default in asterisk and is present in the offer. ptime is already set to 20 ms and is according to their requirements. The headline of their ticket is also "Value of media attribute maxptime in SDP is too high", nothing else.

    If you want to have this configurable, then someone else will need to fix this. My proposal solves the problem for DT in the rdkb branch.

  • Please register or sign in to reply
  • Yalu Zhang merged

    merged

    • Please register or sign in to reply