res · 80e6205bb05f920022b959685155c3b3ce1668ec · Voice / asterisk

res_adsi: Fix major regression caused by media format rearchitecture.

Naveen Albert authored 2 years ago

The commit that rearchitected media formats,
a2c912e9 (ASTERISK_23114)
introduced a regression by improperly translating code in res_adsi.c.
In particular, the pointer to the frame buffer was initialized
at the top of adsi_careful_send, rather than dynamically updating it
for each frame, as is required.

This resulted in the first frame being repeatedly sent,
rather than advancing through the frames.
This corrupted the transmission of the CAS to the CPE,
which meant that CPE would never respond with the DTMF acknowledgment,
effectively completely breaking ADSI functionality.

This issue is now fixed, and ADSI now works properly again.

ASTERISK-29793 #close

Change-Id: Icdeddf733eda2981c98712d1ac9cddc0db507dbe

80e6205b

History

80e6205b 2 years ago

History

Name	Last commit	Last update
..
ael
ari
parking
prometheus
res_aeap
res_geolocation
res_pjsip
res_pjsip_session
res_stir_shaken
snmp
srtp
stasis
stasis_recording
Makefile
ari.make
res.xml
res_adsi.c
res_aeap.c
res_aeap.exports.in
res_ael_share.c
res_ael_share.exports.in
res_agi.c
res_agi.exports.in
res_ari.c
res_ari.exports.in
res_ari_applications.c
res_ari_asterisk.c
res_ari_bridges.c
res_ari_channels.c
res_ari_device_states.c
res_ari_endpoints.c
res_ari_events.c
res_ari_mailboxes.c
res_ari_model.c
res_ari_model.exports.in
res_ari_playbacks.c
res_ari_recordings.c
res_ari_sounds.c
res_audiosocket.c
res_audiosocket.exports.in
res_calendar.c
res_calendar.exports.in
res_calendar_caldav.c
res_calendar_ews.c
res_calendar_exchange.c
res_calendar_icalendar.c
res_chan_stats.c
res_clialiases.c
res_cliexec.c
res_clioriginate.c
res_config_curl.c
res_config_ldap.c
res_config_odbc.c
res_config_pgsql.c
res_config_sqlite3.c
res_convert.c
res_corosync.c
res_crypto.c
res_crypto.exports.in
res_curl.c
res_endpoint_stats.c
res_fax.c
res_fax.exports.in
res_fax_spandsp.c
res_format_attr_celt.c
res_format_attr_g729.c
res_format_attr_h263.c
res_format_attr_h264.c
res_format_attr_ilbc.c
res_format_attr_opus.c
res_format_attr_silk.c
res_format_attr_siren14.c
res_format_attr_siren7.c
res_format_attr_vp8.c
res_geolocation.c
res_geolocation.exports.in
res_hep.c
res_hep.exports.in
res_hep_pjsip.c
res_hep_rtcp.c
res_http_media_cache.c
res_http_post.c
res_http_websocket.c
res_http_websocket.exports.in
res_limit.c
res_manager_devicestate.c
res_manager_presencestate.c
res_monitor.c
res_monitor.exports.in
res_musiconhold.c
res_mutestream.c
res_mwi_devstate.c
res_mwi_external.c
res_mwi_external.exports.in
res_mwi_external_ami.c
res_odbc.c
res_odbc.exports.in
res_odbc_transaction.c
res_odbc_transaction.exports.in
res_parking.c