Mark Michelson
authored
The doxygen for ast_rtp_codecs_payloads_copy() states: "This copies the payloads from the codecs0 structure to the codecs1 structure, overwriting any current values." However, in practice, the overwriting of current values was not happening. Instead, a new RTP codec payload object would be appended to the codecs1 structure instead of replacing the corresponding object. This patch corrects this behavior by overwriting the object in the codecs1 structure if it exists already. If it does not already exist, then create a new copy and link it in. Tests of "memory show summary rtp_engine.c" had previously shown additional allocations being performed any time that Asterisk processed an incoming SDP. Scenarios involving lots of reinvites resulted in lots of allocations. With this patch, I can perform as many reinvites as I want and see no memory increases from the RTP engine. ASTERISK-24916 #close Reported by Christophe Osuna Change-Id: I9a90bc3f564535bc767bf2fc0c455d5f065cea75