Skip to content
Snippets Groups Projects
  1. Apr 02, 2019
  2. Mar 29, 2019
    • Sean Bright's avatar
      app_queue: Fix a few member pause bugs · e8cf3693
      Sean Bright authored
      * Always set member->lastpause when setting member->paused
      
      * Fixed typo (using member->lastcall instead of member->lastpause) in
        'queue show' output.
      
      * Use a constant 'now' in 'queue show' output for a better point-in-time
        view of time based stats.
      
      ASTERISK-27541 #close
      Reported by: César Benjamín García Martínez
      
      Change-Id: Ib41ced90cfdb66f9bb1e7b263d0f6fc1ac6e18fa
      e8cf3693
  3. Mar 28, 2019
    • Ben Ford's avatar
      alembic: Fix errors during upgrade head. · 4edd2484
      Ben Ford authored
      When trying to upgrade using alembic, a couple different errors kept
      popping up that prevented the upgrade. An additional parameter was
      needed when changing the schema for mwi_subscribe_replaces_unsolicited
      from an integer to an enum. When changing from a string to an enum, the
      type needed to be cast for postgresql. The other issue was a parameter
      being used during column creation that did not exist.
      
      After fixing the upgrade process, it revealed errors with the downgrade
      process. One was a variable not being defined in the downgrade function,
      and the other was tables not existing when using MySQL. This was due to
      a context check that should have encompassed MySQL, but in the end was
      not doing so.
      
      Change-Id: Ib4d70cf3ce5080023a50be496272a777b55d6c8e
      4edd2484
    • George Joseph's avatar
    • George Joseph's avatar
  4. Mar 27, 2019
    • George Joseph's avatar
    • Friendly Automation's avatar
    • Ben Ford's avatar
      build: Add staging directories for future changes. · d5d8448c
      Ben Ford authored
      This is the first step in changing the release process so that changes
      made to the CHANGES and UPGRADE.txt files do not result in merge
      conflicts every time multiple people modify these files. The changes
      made will go in these new directories: doc/CHANGES-staging and
      doc/UPGRADE-staging. The README.md files explain how things will work,
      but here's a little overview. When you make a change that would go in
      either CHANGES or UPGRADE.txt, this should instead be documented in a
      new file in the doc/CHANGES-staging or doc/UPGRADE-staging directory,
      respectively. The format will look like this:
      
         Subject: res_pjsip
      
         A description that explains the changes made and why. The release
         script will handle the bulleting and section separators! The
         'Subject:' header is case-sensitive.
      
         You can still separate with new lines within your description.
      
         Subject: res_ari
         Master-Only: true
      
         You can have more than one subject, and they don't have to be the
         same! Also, the 'Master-Only' header should always be true and is
         also case-sensitive (but the value is not - you can have 'true' or
         'True'). This header will only ever be present in the master branch.
      
      For more information, check out the wiki page:
      https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt
      
      This is an initial change for ASTERISK_28111. Functionally, this will
      make no difference, but it will prep the directories for when the
      changes from CHANGES and UPGRADE.txt are extracted.
      
      Change-Id: I8d852f284f66ac456b26dcb899ee46babf7d15b6
      d5d8448c
    • Alexei Gradinari's avatar
      pjsip: restrict function PJSIP_PARSE_URI to parse only SIP/SIPS URIs · f236377c
      Alexei Gradinari authored
      The next usage of PJSIP_PARSE_URI will crash asterisk
      ${PJSIP_PARSE_URI(tel:+1234567890,host)}
      or
      ${PJSIP_PARSE_URI(192.168.1.1:5060,host)}
      
      The function pjsip_parse_uri successfully parses then, but returns
      struct pjsip_other_uri *.
      
      This patch restricts parsing only SIP/SIPS URIs.
      
      Change-Id: I16f255c2b86a80a67e9f9604b94b129a381dd25e
      f236377c
    • Sean Bright's avatar
      pjproject: Add timer patch from pjproject r5934 · 7043ed6a
      Sean Bright authored
      ASTERISK-28161 #close
      Reported by: Ross Beer
      
      Change-Id: I65331d554695753005eaa66c1d5d4807fe9009c8
      7043ed6a
    • Friendly Automation's avatar
  5. Mar 26, 2019
  6. Mar 25, 2019
    • Sean Bright's avatar
      chan_sip: Ensure 'qualifygap' isn't negative · 1499640d
      Sean Bright authored
      Passing negative intervals to the scheduler rips a hole in the
      space-time continuum.
      
      ASTERISK-25792 #close
      Reported by: Paul Sandys
      
      Change-Id: Ie706f21cee05f76ffb6f7d89e9c867930ee7bcd7
      1499640d
    • Alexei Gradinari's avatar
      res_config_odbc: set empty extended field as a single whitespace · e5d990d0
      Alexei Gradinari authored
      If Realtime @ variable value is NULL or empty or contains only whitespaces
      then when we try to retrieve it using PJSIP_ENDPOINT we get WARNING
      pjsip_endpoint_function_read: Unknown property @my_var for PJSIP endpoint.
      And the variable is missing in the result of CLI pjsip show endpoint.
      
      This patch keeps empty sorcery extended field.
      
      ASTERISK-28341 #close
      
      Change-Id: I221fccc04cbfa2be17ce971f64ae0e74e465eea0
      e5d990d0
  7. Mar 22, 2019
  8. Mar 19, 2019
  9. Mar 18, 2019
    • George Joseph's avatar
      sorcery.c: Sorcery enhancements for wizard management · 7e77815a
      George Joseph authored
      Added ability to specifiy a wizard is read-only when applying
      it to a specific object type.  This allows you to specify
      create, update and delete callbacks for the wizard but limit
      which object types can use them.
      
      Added the ability to allow an object type to have multiple
      wizards of the same type.  This is indicated when a wizard
      is added to a specific object type.
      
      Added 3 new sorcery wizard functions:
      
      * ast_sorcery_object_type_insert_wizard which does the same thing
        as the existing ast_sorcery_insert_wizard_mapping function but
        accepts the new read-only and allot-duplicates flags and also
        returns the ast_sorcery_wizard structure used and it's internal
        data structure. This allows immediate use of the wizard's
        callbacks without having to register a "wizard mapped" observer.
      
      * ast_sorcery_object_type_apply_wizard which does the same
        thing as the existing ast_sorcery_apply_wizard_mapping function
        but has the added capabilities of
        ast_sorcery_object_type_insert_wizard.
      
      * ast_sorcery_object_type_remove_wizard which removes a wizard
        matching both its name and its original argument string.
      
      * The original logic in __ast_sorcery_insert_wizard_mapping was moved
        to __ast_sorcery_object_type_insert_wizard and enhanced for the
        new capabilities, then __ast_sorcery_insert_wizard_mapping was
        refactored to just call __ast_sorcery_insert_wizard_mapping.
      
      * Added a unit test to test_sorcery.c to test the read-only
        capability.
      
      Change-Id: I40f35840252e4313d99e11dbd80e270a3aa10605
      7e77815a
    • Joshua Colp's avatar
    • Joshua Colp's avatar
    • Joshua Colp's avatar
  10. Mar 15, 2019
  11. Mar 14, 2019
    • Richard Mudgett's avatar
      taskprocessor.c: Fix printf type mismatch · 45a8892e
      Richard Mudgett authored
      A size_t is not always an unsigned long.
      
      * Use the %zu format specifier in the ast_cli() printf format string since
      AST_VECTOR_SIZE() returns a size_t value.
      
      Change-Id: Ib102dd36bbe6c2a7a4ce6870ae9110d978dd7e98
      45a8892e
    • George Joseph's avatar
      app.c: Remove deletion of pool topic on mwi state delete · 63d90c38
      George Joseph authored
      As part of an earlier voicemail refactor, ast_delete_mwi_state_full
      was modified to remove the pool topic for a mailbox when the state
      was deleted.  This was an attempt to prevent stale topics from
      accumulating when app_voicemail was reloaded and a mailbox went
      away.  Unfortunately because of the fact that when app_voicemail
      reloads, ALL mailboxes are deleted then only current ones recreated,
      topics were being removed from the pool that still had subscribers
      on them, then recreated as new topics of the same name.  So now
      modules like res_pjsip_mwi are listening on a topic that will
      never receive any messages because app_voicemail is publishing on
      a different topic that happens to have the same name.  The solutiuon
      to this is not easy and given that accumulating topics for
      deleted mailboxes is less evil that not sending NOTIFYs...
      
      * Removed the call to stasis_topic_pool_delete_topic in
        ast_delete_mwi_state_full.
      
      Also:
      
      * Fixed a topic reference leak in res_pjsip_mwi
        mwi_stasis_subscription_alloc.
      
      * Added some debugging to mwi_stasis_subscription_alloc,
        stasis_topic_create, and topic_dtor.
      
      * Fixed a topic reference leak in an error path in
        internal_stasis_subscribe.
      
      ASTERISK-28306
      Reported-by: Jared Hull
      
      Change-Id: Id7da0990b3ac4be4b58491536b35f41291247b27
      63d90c38
    • Joshua C. Colp's avatar
    • Joshua C. Colp's avatar
  12. Mar 13, 2019
  13. Mar 12, 2019
Loading