Skip to content
Snippets Groups Projects
  1. Jan 13, 2015
  2. Jan 12, 2015
  3. Jan 09, 2015
  4. Jan 08, 2015
    • George Joseph's avatar
      res_pjsip_pubsub: Fix persistent subscriptions not surviving graceful shutdown · 8786fe13
      George Joseph authored
      If you do a 'core (shutdown|restart) graceful' persistent subscriptions won't 
      survive.  If you do a 'core (shutdown|restart) now' or asterisk terminates for 
      some reason, they do.  Here's why...
      
      When asterisk shuts down gracefully, it sends a 'NOTIFY/terminated' to 
      subscribers for each subscription.  This not only tells the subscribers that the 
      dialog/state machine is done, it also frees the last reference to the 
      subscription tree which causes the persistent subscription to get deleted from 
      astdb.  When asterisk restarts, nothing's left.  Just preventing the delete from 
      astdb doesn't work because we already told the subscriber to terminate the 
      dialog so we can't restart it even if it was still in astdb.  Everything works 
      OK if asterisk terminates unexpectedly because we never send the 'terminated' 
      message so on restart, the subscription is still in astdb and the subscriber is 
      none the wiser.
      
      This patch suppresses the sending of 'NOTIFY/terminated' on shutdown for 
      persistent connections.
      
      Tested-by: George Joseph
      
      Review: https://reviewboard.asterisk.org/r/4318/
      ........
      
      Merged revisions 430397 from http://svn.asterisk.org/svn/asterisk/branches/13
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@430398 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      8786fe13
    • George Joseph's avatar
      res_pjsip_outbound_registration: Fix reference leak. · c55f86c6
      George Joseph authored
      Every time a registration started, sip_outbound_registration_response_cb bumps 
      the ref count on client_state then pushes a handle_registration_response task.  
      handle_registration_response never unreffed it though.  So every time a 
      registration goes out, the ref count goes up by one.
      
      This patch adds the unreffs to handle_registration_response.
      
      Tested-by: George Joseph
      
      Review: https://reviewboard.asterisk.org/r/4303/
      ........
      
      Merged revisions 430395 from http://svn.asterisk.org/svn/asterisk/branches/13
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@430396 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      c55f86c6
    • George Joseph's avatar
      res_pjsip_outbound_registration: Fix several reload issues · 030facce
      George Joseph authored
      There are 2 issues with reloading registrations...
      
      1.  The 'can_reuse_registration' test wasn't considering the intervals or 
      expiration in its determination of whether a registration changed or not so if 
      you changed any of the intervals or the expiration and reloaded, the object 
      would get reloaded but the actual timers wouldn't change.  
      can_reuse_registration now does a sorcery diff on the old and new objects 
      instead of discretely testing certain fields.  Now if you change expiration for 
      instance, and reload, the timer is updated and re-registration will occur on the 
      new value.
      
      2.  If you mung up your password on an outbound registration you get a permanent 
      failure.  If you fix the password (on the outbound_auth object) and reload, 
      nothing tells outbound_registration to try again because the registration itself 
      didn't change.  This patch adds an observer on the "auth" object type and if any 
      auth changes, existing registration states are searched and those in a 
      REJECTED_PERMANENT state are retried.
      
      Tested-by: George Joseph
      
      Review: https://reviewboard.asterisk.org/r/4304/
      ........
      
      Merged revisions 430373 from http://svn.asterisk.org/svn/asterisk/branches/13
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@430374 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      030facce
  5. Jan 07, 2015
  6. Jan 06, 2015
  7. Jan 05, 2015
  8. Dec 31, 2014
  9. Dec 29, 2014
  10. Dec 24, 2014
  11. Dec 23, 2014
  12. Dec 22, 2014
Loading