Skip to content
Snippets Groups Projects
  1. Oct 27, 2016
    • Corey Farrell's avatar
      Remove ASTERISK_REGISTER_FILE. · a6e5bae3
      Corey Farrell authored
      ASTERISK_REGISTER_FILE no longer has any purpose so this commit removes
      all traces of it.
      
      Previously exported symbols removed:
      * __ast_register_file
      * __ast_unregister_file
      * ast_complete_source_filename
      
      This also removes the mtx_prof static variable that was declared when
      MTX_PROFILE was enabled.  This variable was only used in lock.c so it
      is now initialized in that file only.
      
      ASTERISK-26480 #close
      
      Change-Id: I1074af07d71f9e159c48ef36631aa432c86f9966
      a6e5bae3
  2. Apr 13, 2015
    • Matt Jordan's avatar
      git migration: Refactor the ASTERISK_FILE_VERSION macro · 4a582616
      Matt Jordan authored
      Git does not support the ability to replace a token with a version
      string during check-in. While it does have support for replacing a
      token on clone, this is somewhat sub-optimal: the token is replaced
      with the object hash, which is not particularly easy for human
      consumption. What's more, in practice, the source file version was often
      not terribly useful. Generally, when triaging bugs, the overall version
      of Asterisk is far more useful than an individual SVN version of a file. As a
      result, this patch removes Asterisk's support for showing source file
      versions.
      
      Specifically, it does the following:
      
      * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
        remove passing the version in with the macro. Other facilities
        than 'core show file version' make use of the file names, such as
        setting a debug level only on a specific file. As such, the act of
        registering source files with the Asterisk core still has use. The
        macro rename now reflects the new macro purpose.
      
      * main/asterisk:
        - Refactor the file_version structure to reflect that it no longer
          tracks a version field.
        - Remove the "core show file version" CLI command. Without the file
          version, it is no longer useful.
        - Remove the ast_file_version_find function. The file version is no
          longer tracked.
        - Rename ast_register_file_version/ast_unregister_file_version to
          ast_register_file/ast_unregister_file, respectively.
      
      * main/manager: Remove value from the Version key of the ModuleCheck
        Action. The actual key itself has not been removed, as doing so would
        absolutely constitute a backwards incompatible change. However, since
        the file version is no longer tracked, there is no need to attempt to
        include it in the Version key.
      
      * UPGRADE: Add notes for:
        - Modification to the ModuleCheck AMI Action
        - Removal of the "core show file version" CLI command
      
      Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
      4a582616
  3. Jan 12, 2013
    • Automerge script's avatar
      Merged revisions 378935 via svnmerge from · f7f7850f
      Automerge script authored
      file:///srv/subversion/repos/asterisk/trunk
      
      ................
        r378935 | dlee | 2013-01-12 00:43:37 -0600 (Sat, 12 Jan 2013) | 41 lines
        
        Fix XML encoding of 'identity display' in NOTIFY messages.
        
        XML encoding in chan_sip is accomplished by naively building the XML
        directly from strings. While this usually works, it fails to take into
        account escaping the reserved characters in XML.
        
        This patch adds an 'ast_xml_escape' function, which works similarly to
        'ast_uri_encode'. This is used to properly escape the local_display
        attribute in XML formatted NOTIFY messages.
        
        Several things to note:
         * The Right Thing(TM) to do would probably be to replace the
           ast_build_string stuff with building an ast_xml_doc. That's a much
           bigger change, and out of scope for the original ticket, so I
           refrained myself.
         * It is with great sadness that I wrote my own ast_xml_escape
           function. There's one in libxml2, but it's knee-deep in
           libxml2-ness, and not easily used to one-off escape a
           string.
         * I only escaped the string we know is causing problems
           (local_display). At least some of the other strings are
           URI-encoded, which should be XML safe. Rather than figuring out
           what's safe and escaping what's not, it would be much cleaner to
           simply build an ast_xml_doc for the messages and let the XML
           library do the XML escaping. Like I said, that's out of scope.
        
        (closes issue ABE-2902)
        Reported by: Guenther Kelleter
        Tested by: Guenther Kelleter
        Review: http://reviewboard.digium.internal/r/365/
        
        ........
        
        Merged revision 378919 from https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
        ........
        
        Merged revisions 378933 from http://svn.asterisk.org/svn/asterisk/branches/1.8
        ........
        
        Merged revisions 378934 from http://svn.asterisk.org/svn/asterisk/branches/11
      ................
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/team/mmichelson/threadpool@378946 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      f7f7850f
    • David M. Lee's avatar
      Fix XML encoding of 'identity display' in NOTIFY messages. · aecd2429
      David M. Lee authored
      XML encoding in chan_sip is accomplished by naively building the XML
      directly from strings. While this usually works, it fails to take into
      account escaping the reserved characters in XML.
      
      This patch adds an 'ast_xml_escape' function, which works similarly to
      'ast_uri_encode'. This is used to properly escape the local_display
      attribute in XML formatted NOTIFY messages.
      
      Several things to note:
       * The Right Thing(TM) to do would probably be to replace the
         ast_build_string stuff with building an ast_xml_doc. That's a much
         bigger change, and out of scope for the original ticket, so I
         refrained myself.
       * It is with great sadness that I wrote my own ast_xml_escape
         function. There's one in libxml2, but it's knee-deep in
         libxml2-ness, and not easily used to one-off escape a
         string.
       * I only escaped the string we know is causing problems
         (local_display). At least some of the other strings are
         URI-encoded, which should be XML safe. Rather than figuring out
         what's safe and escaping what's not, it would be much cleaner to
         simply build an ast_xml_doc for the messages and let the XML
         library do the XML escaping. Like I said, that's out of scope.
      
      (closes issue ABE-2902)
      Reported by: Guenther Kelleter
      Tested by: Guenther Kelleter
      Review: http://reviewboard.digium.internal/r/365/
      
      ........
      
      Merged revision 378919 from https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
      ........
      
      Merged revisions 378933 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 378934 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@378935 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      aecd2429
Loading