Skip to content
Snippets Groups Projects
  1. Nov 15, 2021
    • Josh Soref's avatar
      main: Spelling fixes · 4019a93e
      Josh Soref authored
      Correct typos of the following word families:
      
      analysis
      nuisance
      converting
      although
      transaction
      desctitle
      acquire
      update
      evaluate
      thousand
      this
      dissolved
      management
      integrity
      reconstructed
      decrement
      further on
      irrelevant
      currently
      constancy
      anyway
      unconstrained
      featuregroups
      right
      larger
      evaluated
      encumbered
      languages
      digits
      authoritative
      framing
      blindxfer
      tolerate
      traverser
      exclamation
      perform
      permissions
      rearrangement
      performing
      processing
      declension
      happily
      duplicate
      compound
      hundred
      returns
      elicit
      allocate
      actually
      paths
      inheritance
      atxferdropcall
      earlier
      synchronization
      multiplier
      acknowledge
      across
      against
      thousands
      joyous
      manipulators
      guaranteed
      emulating
      soundfile
      
      ASTERISK-29714
      
      Change-Id: I926ba4b11e9f6dd3fdd93170ab1f9b997910be70
      4019a93e
  2. Mar 03, 2018
  3. Dec 22, 2017
  4. Dec 20, 2017
    • Corey Farrell's avatar
      Fix Common Typo's. · 1b80ffa4
      Corey Farrell authored
      Fix instances of:
      * Retreive
      * Recieve
      * other then
      * different then
      * Repeated words ("the the", "an an", "and and", etc).
      * othterwise, teh
      
      ASTERISK-24198 #close
      
      Change-Id: I3809a9c113b92fd9d0d9f9bac98e9c66dc8b2d31
      1b80ffa4
  5. Dec 19, 2017
    • Corey Farrell's avatar
      Remove constant conditionals (dead-code). · b3e839de
      Corey Farrell authored
      Some variables are set and never changed, making them constant.  This
      means that code in the 'false' block of the conditional is unreachable.
      
      In chan_skinny and res_config_ldap I used preprocessor directive `#if 0`
      as I'm unsure if the unreachable code could be enabled in the future.
      
      Change-Id: I62e2aac353d739fb3c983cf768933120f5fba059
      b3e839de
  6. Aug 01, 2017
    • Corey Farrell's avatar
      Fix compiler warnings on Fedora 26 / GCC 7. · 58d03211
      Corey Farrell authored
      GCC 7 has added capability to produce warnings, this fixes most of those
      warnings.  The specific warnings are disabled in a few places:
      
      * app_voicemail.c: truncation of paths more than 4096 chars in many places.
      * chan_mgcp.c: callid truncated to 80 chars.
      * cdr.c: two userfields are combined to cdr copy, fix would break ABI.
      * tcptls.c: ignore use of deprecated method SSLv3_client_method().
      
      ASTERISK-27156 #close
      
      Change-Id: I65f280e7d3cfad279d16f41823a4d6fddcbc4c88
      58d03211
  7. Oct 27, 2016
    • Corey Farrell's avatar
      Remove ASTERISK_REGISTER_FILE. · a6e5bae3
      Corey Farrell authored
      ASTERISK_REGISTER_FILE no longer has any purpose so this commit removes
      all traces of it.
      
      Previously exported symbols removed:
      * __ast_register_file
      * __ast_unregister_file
      * ast_complete_source_filename
      
      This also removes the mtx_prof static variable that was declared when
      MTX_PROFILE was enabled.  This variable was only used in lock.c so it
      is now initialized in that file only.
      
      ASTERISK-26480 #close
      
      Change-Id: I1074af07d71f9e159c48ef36631aa432c86f9966
      a6e5bae3
  8. Jun 28, 2016
  9. Dec 28, 2015
    • Joshua Colp's avatar
      test_time: Provide a timeout when waiting. · a05bb258
      Joshua Colp authored
      The test_timezone_watch unit test is written to expect a
      condition to be signaled when the inotify daemon thread runs.
      There exists a small window where the test_timezone_watch
      thread can signal the inotify daemon thread while it is not
      reading on the underlying file descriptor. If this occurs
      the test_timezone_watch thread will wait indefinitely for a
      signal that will never arrive.
      
      This change adds a timeout to the condition so it will return
      regardless after a period of time.
      
      Change-Id: Ifed981879df6de3d93acd3ee0a70f92546517390
      a05bb258
  10. Apr 13, 2015
    • Matt Jordan's avatar
      git migration: Refactor the ASTERISK_FILE_VERSION macro · 4a582616
      Matt Jordan authored
      Git does not support the ability to replace a token with a version
      string during check-in. While it does have support for replacing a
      token on clone, this is somewhat sub-optimal: the token is replaced
      with the object hash, which is not particularly easy for human
      consumption. What's more, in practice, the source file version was often
      not terribly useful. Generally, when triaging bugs, the overall version
      of Asterisk is far more useful than an individual SVN version of a file. As a
      result, this patch removes Asterisk's support for showing source file
      versions.
      
      Specifically, it does the following:
      
      * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
        remove passing the version in with the macro. Other facilities
        than 'core show file version' make use of the file names, such as
        setting a debug level only on a specific file. As such, the act of
        registering source files with the Asterisk core still has use. The
        macro rename now reflects the new macro purpose.
      
      * main/asterisk:
        - Refactor the file_version structure to reflect that it no longer
          tracks a version field.
        - Remove the "core show file version" CLI command. Without the file
          version, it is no longer useful.
        - Remove the ast_file_version_find function. The file version is no
          longer tracked.
        - Rename ast_register_file_version/ast_unregister_file_version to
          ast_register_file/ast_unregister_file, respectively.
      
      * main/manager: Remove value from the Version key of the ModuleCheck
        Action. The actual key itself has not been removed, as doing so would
        absolutely constitute a backwards incompatible change. However, since
        the file version is no longer tracked, there is no need to attempt to
        include it in the Version key.
      
      * UPGRADE: Add notes for:
        - Modification to the ModuleCheck AMI Action
        - Removal of the "core show file version" CLI command
      
      Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
      4a582616
  11. Mar 30, 2015
  12. Mar 10, 2015
  13. May 09, 2014
  14. Aug 28, 2013
  15. Dec 03, 2012
  16. Jun 15, 2012
    • Kevin P. Fleming's avatar
      Multiple revisions 369001-369002 · 166b4e2b
      Kevin P. Fleming authored
      ........
        r369001 | kpfleming | 2012-06-15 10:56:08 -0500 (Fri, 15 Jun 2012) | 11 lines
        
        Add support-level indications to many more source files.
        
        Since we now have tools that scan through the source tree looking for files
        with specific support levels, we need to ensure that every file that is
        a component of a 'core' or 'extended' module (or the main Asterisk binary)
        is explicitly marked with its support level. This patch adds support-level
        indications to many more source files in tree, but avoids adding them to
        third-party libraries that are included in the tree and to source files
        that don't end up involved in Asterisk itself.
      ........
        r369002 | kpfleming | 2012-06-15 10:57:14 -0500 (Fri, 15 Jun 2012) | 3 lines
        
        Add a script to enable finding source files without support-levels defined.
      ........
      
      Merged revisions 369001-369002 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 369005 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@369013 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      166b4e2b
  17. Apr 19, 2012
    • Matthew Jordan's avatar
      Fix a variety of potential buffer overflows · f7829006
      Matthew Jordan authored
      * chan_mobile: Fixed an overrun where the cind_state buffer (an integer array
        of size 16) would be overrun due to improper bounds checking. At worst, the
        buffer can be overrun by a total of 48 bytes (assuming 4-byte integers),
        which would still leave it within the allocated memory of struct hfp.  This
        would corrupt other elements in that struct but not necessarily cause any
        further issues.
      
      * app_sms: The array imsg is of size 250, while the array (ud) that the data
        is copied into is of size 160.  If the size of the inbound message is 
        greater then 160, up to 90 bytes could be overrun in ud.  This would corrupt
        the user data header (array udh) adjacent to ud.
      
      * chan_unistim: A number of invalid memmoves are corrected.  These would move
        data (which may or may not be valid) into the ends of these buffers.
      
      * asterisk: ast_console_toggle_loglevel does not check that the console log
        level being set is less then or equal to the allowed log levels of 32.
      
      * format_pref: In ast_codec_pref_prepend, if any occurrence of the specified
        codec is not found, the value used to index into the array pref->order
        would be one greater then the maximum size of the array.
      
      * jitterbuf: If the element being placed into the jitter buffer lands in the
        last available slot in the jitter history buffer, the insertion sort attempts
        to move the last entry in the buffer into one slot past the maximum length
        of the buffer.  Note that this occurred for both the min and max jitter
        history buffers.
      
      * tdd: If a read from fsk_serial returns a character that is greater then 32,
        an attempt to read past one of the statically defined arrays containing the
        values that character maps to would occur.
      
      * localtime: struct ast_time and tm are not the same size - ast_time is larger,
        although it contains the elements of tm within it in the same layout.  Hence,
        when using memcpy to copy the contents of tm into ast_time, the size of tm
        should be used, as opposed to the size of ast_time.
      
      * extconf: this treats ast_timing's minmask array as if it had a length of 48,
        when it has defined the size of the array as 24.  pbx.h defines minmask as
        having a size of 48.
      
      (issue ASTERISK-19668)
      Reported by: Matt Jordan
      ........
      
      Merged revisions 362485 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 362496 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@362497 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      f7829006
  18. Mar 22, 2012
  19. Feb 14, 2012
  20. Oct 14, 2010
  21. Sep 30, 2010
  22. Jun 01, 2010
  23. May 13, 2010
  24. Mar 20, 2010
  25. Mar 18, 2010
  26. Mar 16, 2010
  27. Mar 08, 2010
  28. Apr 20, 2009
  29. Apr 03, 2009
  30. Feb 25, 2009
  31. Nov 20, 2008
    • Kevin P. Fleming's avatar
      Merged revisions 157859 via svnmerge from · 8d5deb31
      Kevin P. Fleming authored
      https://origsvn.digium.com/svn/asterisk/branches/1.4
      
      ........
        r157859 | kpfleming | 2008-11-19 15:34:47 -0600 (Wed, 19 Nov 2008) | 7 lines
        
        the gcc optimizer frequently finds broken code (use of uninitalized variables, unreachable code, etc.), which is good. however, developers usually compile with the optimizer turned off, because if they need to debug the resulting code, optimized code makes that process very difficult. this means that we get code changes committed that weren't adequately checked over for these sorts of problems.
        
        with this build system change, if (and only if) --enable-dev-mode was used and DONT_OPTIMIZE is turned on, when a source file is compiled it will actually be preprocessed (into a .i or .ii file), then compiled once with optimization (with the result sent to /dev/null) and again without optimization (but only if the first compile succeeded, of course).
        
        while making these changes, i did some cleanup work in Makefile.rules to move commonly-used combinations of flag variables into their own variables, to make the file easier to read and maintain
      ........
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157974 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      8d5deb31
  32. Oct 01, 2008
  33. Sep 27, 2008
    • Kevin P. Fleming's avatar
      Merged revisions 144924-144925 via svnmerge from · 629861a7
      Kevin P. Fleming authored
      https://origsvn.digium.com/svn/asterisk/branches/1.4
      
      ........
        r144924 | kpfleming | 2008-09-27 10:00:48 -0500 (Sat, 27 Sep 2008) | 6 lines
        
        improve header inclusion process in a few small ways:
        
          - it is no longer necessary to forcibly include asterisk/autoconfig.h; every module already includes asterisk.h as its first header (even before system headers), which serves the same purpose
          - astmm.h is now included by asterisk.h when needed, instead of being forced by the Makefile; this means external modules will build properly against installed headers with MALLOC_DEBUG enabled
          - simplify the usage of some of these headers in the AEL-related stuff in the utils directory
      ........
        r144925 | kpfleming | 2008-09-27 10:13:30 -0500 (Sat, 27 Sep 2008) | 2 lines
        
        fix some minor issues with rev 144924
      ........
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@144949 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      629861a7
  34. Feb 20, 2008
Loading