Skip to content
Snippets Groups Projects
  1. Oct 27, 2016
    • Corey Farrell's avatar
      Remove ASTERISK_REGISTER_FILE. · a6e5bae3
      Corey Farrell authored
      ASTERISK_REGISTER_FILE no longer has any purpose so this commit removes
      all traces of it.
      
      Previously exported symbols removed:
      * __ast_register_file
      * __ast_unregister_file
      * ast_complete_source_filename
      
      This also removes the mtx_prof static variable that was declared when
      MTX_PROFILE was enabled.  This variable was only used in lock.c so it
      is now initialized in that file only.
      
      ASTERISK-26480 #close
      
      Change-Id: I1074af07d71f9e159c48ef36631aa432c86f9966
      a6e5bae3
  2. Apr 13, 2015
    • Matt Jordan's avatar
      git migration: Refactor the ASTERISK_FILE_VERSION macro · 4a582616
      Matt Jordan authored
      Git does not support the ability to replace a token with a version
      string during check-in. While it does have support for replacing a
      token on clone, this is somewhat sub-optimal: the token is replaced
      with the object hash, which is not particularly easy for human
      consumption. What's more, in practice, the source file version was often
      not terribly useful. Generally, when triaging bugs, the overall version
      of Asterisk is far more useful than an individual SVN version of a file. As a
      result, this patch removes Asterisk's support for showing source file
      versions.
      
      Specifically, it does the following:
      
      * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
        remove passing the version in with the macro. Other facilities
        than 'core show file version' make use of the file names, such as
        setting a debug level only on a specific file. As such, the act of
        registering source files with the Asterisk core still has use. The
        macro rename now reflects the new macro purpose.
      
      * main/asterisk:
        - Refactor the file_version structure to reflect that it no longer
          tracks a version field.
        - Remove the "core show file version" CLI command. Without the file
          version, it is no longer useful.
        - Remove the ast_file_version_find function. The file version is no
          longer tracked.
        - Rename ast_register_file_version/ast_unregister_file_version to
          ast_register_file/ast_unregister_file, respectively.
      
      * main/manager: Remove value from the Version key of the ModuleCheck
        Action. The actual key itself has not been removed, as doing so would
        absolutely constitute a backwards incompatible change. However, since
        the file version is no longer tracked, there is no need to attempt to
        include it in the Version key.
      
      * UPGRADE: Add notes for:
        - Modification to the ModuleCheck AMI Action
        - Removal of the "core show file version" CLI command
      
      Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
      4a582616
  3. May 21, 2013
  4. Mar 13, 2012
  5. Feb 20, 2012
  6. Jul 14, 2011
  7. Jun 07, 2009
  8. May 21, 2009
    • Kevin P. Fleming's avatar
      Const-ify the world (or at least a good part of it) · e6b2e9a7
      Kevin P. Fleming authored
      This patch adds 'const' tags to a number of Asterisk APIs where they are appropriate (where the API already demanded that the function argument not be modified, but the compiler was not informed of that fact). The list includes:
      
      - CLI command handlers
      - CLI command handler arguments
      - AGI command handlers
      - AGI command handler arguments
      - Dialplan application handler arguments
      - Speech engine API function arguments
      
      In addition, various file-scope and function-scope constant arrays got 'const' and/or 'static' qualifiers where they were missing.
      
      Review: https://reviewboard.asterisk.org/r/251/
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@196072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      e6b2e9a7
  9. Apr 24, 2009
    • Russell Bryant's avatar
      Convert the ast_channel data structure over to the astobj2 framework. · cba19c8a
      Russell Bryant authored
      There is a lot that could be said about this, but the patch is a big 
      improvement for performance, stability, code maintainability, 
      and ease of future code development.
      
      The channel list is no longer an unsorted linked list.  The main container 
      for channels is an astobj2 hash table.  All of the code related to searching 
      for channels or iterating active channels has been rewritten.  Let n be 
      the number of active channels.  Iterating the channel list has gone from 
      O(n^2) to O(n).  Searching for a channel by name went from O(n) to O(1).  
      Searching for a channel by extension is still O(n), but uses a new method 
      for doing so, which is more efficient.
      
      The ast_channel object is now a reference counted object.  The benefits 
      here are plentiful.  Some benefits directly related to issues in the 
      previous code include:
      
      1) When threads other than the channel thread owning a channel wanted 
         access to a channel, it had to hold the lock on it to ensure that it didn't 
         go away.  This is no longer a requirement.  Holding a reference is 
         sufficient.
      
      2) There are places that now require less dealing with channel locks.
      
      3) There are places where channel locks are held for much shorter periods 
         of time.
      
      4) There are places where dealing with more than one channel at a time becomes 
         _MUCH_ easier.  ChanSpy is a great example of this.  Writing code in the 
         future that deals with multiple channels will be much easier.
      
      Some additional information regarding channel locking and reference count 
      handling can be found in channel.h, where a new section has been added that 
      discusses some of the rules associated with it.
      
      Mark Michelson also assisted with the development of this patch.  He did the 
      conversion of ChanSpy and introduced a new API, ast_autochan, which makes it 
      much easier to deal with holding on to a channel pointer for an extended period 
      of time and having it get automatically updated if the channel gets masqueraded.
      Mark was also a huge help in the code review process.
      
      Thanks to David Vossel for his assistance with this branch, as well.  David 
      did the conversion of the DAHDIScan application by making it become a wrapper 
      for ChanSpy internally.
      
      The changes come from the svn/asterisk/team/russell/ast_channel_ao2 branch.
      
      Review: http://reviewboard.digium.com/r/203/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@190423 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      cba19c8a
  10. Jan 28, 2009
    • Steve Murphy's avatar
      Merged revisions 172030 via svnmerge from · 268ac221
      Steve Murphy authored
      https://origsvn.digium.com/svn/asterisk/branches/1.4
      
      ........
        r172030 | murf | 2009-01-28 11:51:16 -0700 (Wed, 28 Jan 2009) | 46 lines
        
        This patch fixes h-exten running misbehavior in manager-redirected 
        situations.
        
        What it does:
        1. A new Flag value is defined in include/asterisk/channel.h,
         AST_FLAG_BRIDGE_HANGUP_DONT, which used as a messenge to the
         bridge hangup exten code not to run the h-exten there (nor
         publish the bridge cdr there). It will done at the pbx-loop
         level instead.
        2. In the manager Redirect code, I set this flag on the channel
         if the channel has a non-null pbx pointer. I did the same for the
         second (chan2) channel, which gets run if name2 is set...
         and the first succeeds.
        3. I restored the ending of the cdr for the pbx loop h-exten
         running code. Don't know why it was removed in the first place.
        4. The first attempt at the fix for this bug was to place code
           directly in the async_goto routine, which was called from a
           large number of places, and could affect a large number of
           cases, so I tested that fix against a fair number of transfer
           scenarios, both with and without the patch. In the process,
           I saw that putting the fix in async_goto seemed not to affect
           any of the blind or attended scenarios, but still, I was
           was highly concerned that some other scenarios I had not tested
           might be negatively impacted, so I refined the patch to 
           its current scope, and jmls tested both. In the process, tho,
           I saw that blind xfers in one situation, when the one-touch
           blind-xfer feature is used by the peer, we got strange 
           h-exten behavior.  So, I  inserted code to swap CDRs and
           to set the HANGUP_DONT field, to get uniform behavior.
        5. I added code to the bridge to obey the HANGUP_DONT flag,
           skipping both publishing the bridge CDR, and running
           the h-exten; they will be done at the pbx-loop (higher)
           level instead.
        6. I removed all the debug logs from the patch before committing.
        7. I moved the AUTOLOOP set/reset in the h-exten code in res_features
           so it's only done if the h-exten is going to be run. A very
           minor performance improvement, but technically correct.
        
        
        (closes issue #14241)
        Reported by: jmls
        Patches:
              14241_redirect_no_bridgeCDR_or_h_exten_via_transfer uploaded by murf (license 17)
        Tested by: murf, jmls
      ........
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@172063 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      268ac221
  11. Nov 01, 2008
  12. Jun 03, 2008
  13. Feb 19, 2008
  14. Feb 18, 2008
  15. Feb 09, 2008
  16. Feb 01, 2008
  17. Nov 21, 2007
  18. Nov 19, 2007
  19. Nov 16, 2007
    • Luigi Rizzo's avatar
      Start untangling header inclusion in a way that does not affect · fdb7f7ba
      Luigi Rizzo authored
      build times - tested, there is no measureable difference before and
      after this commit.
      
      In this change:
      
      use asterisk/compat.h to include a small set of system headers:
      inttypes.h, unistd.h, stddef.h, stddint.h, sys/types.h, stdarg.h,
      stdlib.h, alloca.h, stdio.h
      
      Where available, the inclusion is conditional on HAVE_FOO_H as determined
      by autoconf.
      
      Normally, source files should not include any of the above system headers,
      and instead use either "asterisk.h" or "asterisk/compat.h" which does it
      better. 
      
      For the time being I have left alone second-level directories
      (main/db1-ast, etc.).
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89333 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      fdb7f7ba
  20. Nov 15, 2007
  21. Jul 23, 2007
  22. Jul 16, 2007
  23. Jun 14, 2007
  24. May 30, 2007
  25. Aug 21, 2006
  26. Jun 07, 2006
  27. May 16, 2006
  28. Apr 14, 2006
    • Luigi Rizzo's avatar
      This rather large commit changes the way modules are loaded. · e43bc663
      Luigi Rizzo authored
       
      As partly documented in loader.c and include/asterisk/module.h,
      modules are now expected to return all of their methods and flags
      into a structure 'mod_data', and are normally loaded with RTLD_NOW
      | RTLD_LOCAL, so symbols are resolved immediately and conflicts
      should be less likely.  Only in a small number of cases (res_*,
      typically) modules are loaded RTLD_GLOBAL, so they can export
      symbols.
       
      The core of the change is only the two files loader.c and
      include/asterisk/module.h, all the rest is simply adaptation of the
      existing modules to the new API, a rather mechanical (but believe
      me, time and finger-consuming!) process whose detail you can figure
      out by svn diff'ing any single module.
      
      Expect some minor compilation issue after this change, please
      report it on mantis http://bugs.digium.com/view.php?id=6968
      so we collect all the feedback in one place.
      
      I am just sorry that this change missed SVN version number 20000!
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@20003 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      e43bc663
  29. Apr 11, 2006
  30. Apr 08, 2006
  31. Apr 05, 2006
  32. Mar 28, 2006
  33. Mar 26, 2006
  34. Mar 25, 2006
Loading