Skip to content
Snippets Groups Projects
  1. Jul 04, 2014
    • Matthew Jordan's avatar
      Remove many deprecated modules · 97834718
      Matthew Jordan authored
      Billing records are fair,
      To get paid is quite bright,
      You should really use ODBC;
      Good-bye cdr_sqlite.
      
      Microsoft did once push H.323,
      Hell, we all remember NetMeeting.
      But try to compile chan_h323 now
      And you will take quite a beating.
      
      The XMPP and SIP war was fierce,
      And in the distant fray
      Was birthed res_jabber/chan_jingle;
      But neither to stay.
      
      For everyone did care and chase what Google professed.
      "Free Internet Calling" was what devotees cried,
      But Google did change the specs so often
      That the developers were happy the day chan_gtalk died.
      
      And then there was that odd application
      Dedicated to the Polish tongue.
      app_saycountpl was subsumed by Say;
      One could say its bell was rung.
      
      To read and parse a file from the dialplan
      You could (I guess) use an application.
      app_readfile did fill that purpose, but I think
      A function is perhaps better in its creation.
      
      Barging is rude, I'm not sure why we do it.
      Inwardly, the caller will probably sigh.
      But if you really must do it,
      Don't use app_dahdibarge, use ChanSpy.
      
      We all despise the sound of tinny robots
      It makes our queues so cold.
      To control such an abomination
      It's better to not use Wait/SetMusicOnHold.
      
      It's often nice to know properties of a channel
      It makes our calls right
      We have a nice function called CHANNEL
      And so SIPCHANINFO is sent off into the night.
      
      And now things get odd;
      Apparently one could delimit with a colon
      Properties from the SIPPEER function!
      Commas are in; all others are done.
      
      Finally, a word on pipes and commas.
      We're sorry. We can't say it enough.
      But those compatibility options in asterisk.conf;
      To maintain them forever was just too tough.
      
      This patch removes:
      
      * cdr_sqlite
      * chan_gtalk
      * chan_jingle
      * chan_h323
      * res_jabber
      * app_saycountpl
      * app_readfile
      * app_dahdibarge
      
      It removes the following applications/functions:
      
      * WaitMusicOnHold
      * SetMusicOnHold
      * SIPCHANINFO
      
      It removes the colon delimiter from the SIPPEER function.
      
      Finally, it also removes all compatibility options that were configurable from
      asterisk.conf, as these all applied to compatibility with Asterisk 1.4 systems.
      
      Review: https://reviewboard.asterisk.org/r/3698/
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@418019 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      97834718
  2. Jun 10, 2014
  3. Mar 28, 2014
  4. Mar 07, 2014
    • Scott Griepentrog's avatar
      uniqueid: channel linkedid, ami, ari object creation with id's · 80ef9a21
      Scott Griepentrog authored
      Much needed was a way to assign id to objects on creation, and
      much change was necessary to accomplish it.  Channel uniqueids
      and linkedids are split into separate string and creation time
      components without breaking linkedid propgation.  This allowed
      the uniqueid to be specified by the user interface - and those
      values are now carried through to channel creation, adding the
      assignedids value to every function in the chain including the
      channel drivers. For local channels, the second channel can be
      specified or left to default to a ;2 suffix of first.  In ARI,
      bridge, playback, and snoop objects can also be created with a
      specified uniqueid.
      
      Along the way, the args order to allocating channels was fixed
      in chan_mgcp and chan_gtalk, and linkedid is no longer lost as
      masquerade occurs.
      
      (closes issue ASTERISK-23120)
      Review: https://reviewboard.asterisk.org/r/3191/
      ........
      
      Merged revisions 410157 from http://svn.asterisk.org/svn/asterisk/branches/12
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@410158 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      80ef9a21
  5. Feb 22, 2014
  6. Feb 21, 2014
  7. Feb 19, 2014
  8. Jan 23, 2014
  9. Dec 19, 2013
  10. Dec 18, 2013
  11. Dec 05, 2013
  12. Dec 03, 2013
  13. Dec 02, 2013
  14. Oct 27, 2013
  15. Oct 03, 2013
  16. Sep 03, 2013
  17. Jul 17, 2013
  18. Jun 17, 2013
    • Matthew Jordan's avatar
      Make cdr_mysql compile again by not directly setting the run-time CDR object · 2b992bc7
      Matthew Jordan authored
      A stray ast_cdr_setvar was missed in cdr_mysql (silly addons). This has now
      been refactored to not set the property, as the property would have been set
      on a run-time object that was already dispatched to the backend. The module
      simply remembers the value it wanted to set and writes it to MySQL later
      in the processing.
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@391964 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      2b992bc7
    • Matthew Jordan's avatar
      Update Asterisk's CDRs for the new bridging framework · 6258bbe7
      Matthew Jordan authored
      This patch is the initial push to update Asterisk's CDR engine for the new
      bridging framework. This patch guts the existing CDR engine and builds the new
      on top of messages coming across Stasis. As changes in channel state and bridge
      state are detected, CDRs are built and dispatched accordingly. This
      fundamentally changes CDRs in a few ways.
      (1) CDRs are now *very* reflective of the actual state of channels and bridges.
          This means CDRs track well with what an actual channel is doing - which
          is useful in transfer scenarios (which were previously difficult to pin
          down). It does, however, mean that CDRs cannot be 'fooled'. Previous
          behavior in Asterisk allowed for CDR applications, channels, and other
          properties to be spoofed in parts of the code - this no longer works.
      (2) CDRs have defined behavior in multi-party scenarios. This behavior will not
          be what everyone wants, but it is a defined behavior and as such, it is
          predictable.
      (3) The CDR manipulation functions and applications have been overhauled. Major
          changes have been made to ResetCDR and ForkCDR in particular. Many of the
          options for these two applications no longer made any sense with the new
          framework and the (slightly) more immutable nature of CDRs.
      
      There are a plethora of other changes. For a full description of CDR behavior,
      see the CDR specification on the Asterisk wiki.
      
      (closes issue ASTERISK-21196)
      
      Review: https://reviewboard.asterisk.org/r/2486/
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@391947 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      6258bbe7
  19. May 31, 2013
  20. May 21, 2013
  21. May 19, 2013
  22. Apr 27, 2013
  23. Mar 12, 2013
  24. Feb 25, 2013
  25. Jan 17, 2013
  26. Jan 16, 2013
    • Automerge script's avatar
      Merged revisions 379180 via svnmerge from · 4986651f
      Automerge script authored
      file:///srv/subversion/repos/asterisk/trunk
      
      ................
        r379180 | mjordan | 2013-01-15 22:14:38 -0600 (Tue, 15 Jan 2013) | 27 lines
        
        Fix parsing SMSSRC for SMS messages
        
        The parser for SMS messages would incorrectly parse out the from number.
        The parsing would incorrectly start scanning for the from number at the
        same index as the first double quote ("); this would inadvertently cause
        it to treat the first double quote as the terminating double quote for
        the from number as well.
        
        The SMSSRC should now populate correctly.
        
        (closes issue ASTERISK-16822)
        Reported by: menschentier
        Tested by: Jonas Falck
        patches:
         fixSMSSRC.patch uploaded by jonax (license 6320)
        
        (closes issue ASTERISK-19153)
        Reported by: Panos Gkikakis
        patches:
          sms-sender-fix.diff uploaded by roeften (license 5884)  
        ........
        
        Merged revisions 379178 from http://svn.asterisk.org/svn/asterisk/branches/1.8
        ........
        
        Merged revisions 379179 from http://svn.asterisk.org/svn/asterisk/branches/11
      ................
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/team/mmichelson/threadpool@379189 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      4986651f
    • Matthew Jordan's avatar
      Fix parsing SMSSRC for SMS messages · 02e70d78
      Matthew Jordan authored
      The parser for SMS messages would incorrectly parse out the from number.
      The parsing would incorrectly start scanning for the from number at the
      same index as the first double quote ("); this would inadvertently cause
      it to treat the first double quote as the terminating double quote for
      the from number as well.
      
      The SMSSRC should now populate correctly.
      
      (closes issue ASTERISK-16822)
      Reported by: menschentier
      Tested by: Jonas Falck
      patches:
       fixSMSSRC.patch uploaded by jonax (license 6320)
      
      (closes issue ASTERISK-19153)
      Reported by: Panos Gkikakis
      patches:
        sms-sender-fix.diff uploaded by roeften (license 5884)  
      ........
      
      Merged revisions 379178 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 379179 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@379180 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      02e70d78
    • Automerge script's avatar
      Merged revisions 379144,379147 via svnmerge from · 346e7740
      Automerge script authored
      file:///srv/subversion/repos/asterisk/trunk
      
      ................
        r379144 | mjordan | 2013-01-15 17:54:34 -0600 (Tue, 15 Jan 2013) | 17 lines
        
        Add busy detection to chan_mobile
        
        From the patch author:
        
        "First this patch adds general support for busy detection. It also adds support
         for the ECAM command at Sony Ericsson phones and also signals busy when only
         early media was received but the call got not answered."
        
        Review: https://reviewboard.asterisk.org/r/323
        
        (closes issue ASTERISK-14527)
        Reported by: Artem Makhutov
        Tested by: Artem Makhutov
        patches:
          busy-full5.patch uploaded by artem (license 5757)
      ................
        r379147 | mjordan | 2013-01-15 18:16:22 -0600 (Tue, 15 Jan 2013) | 25 lines
        
        Set the INVALID_EXTEN channel variable when chan_misdn forces the 'i' extension
        
        The chan_misdn channel driver will send a channel with an invalid destination
        to the 'i' extension itself if said extension can be reached. It forgot,
        however, to set the INVALID_EXTEN channel variable when it bounces the channel
        to this extension. Dialplan writers everywhere moaned at yet another
        inconsistency.
        
        This is yet another example of why duplicating logic in multiple places results
        in bugs that stick around in Jira for just under three years.
        
        Yes: ASTERISK-15456 was created on January 18th, 2010. Patch committed on
        January 15th, 2013. Ouch.
        
        (closes issue ASTERISK-15456)
        Reported by: Thomas Omerzu
        patches:
          chan_misdn_invalid.patch2 uploaded by Thomas Omerzu (license 5927)
        ........
        
        Merged revisions 379145 from http://svn.asterisk.org/svn/asterisk/branches/1.8
        ........
        
        Merged revisions 379146 from http://svn.asterisk.org/svn/asterisk/branches/11
      ................
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/team/mmichelson/threadpool@379156 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      346e7740
  27. Jan 15, 2013
  28. Jan 02, 2013
    • Automerge script's avatar
      Merged revisions 378374,378377,378384 via svnmerge from · b375abae
      Automerge script authored
      file:///srv/subversion/repos/asterisk/trunk
      
      ................
        r378374 | rmudgett | 2013-01-02 15:23:16 -0600 (Wed, 02 Jan 2013) | 33 lines
        
        Fix AMI redirect action with two channels failing to redirect both channels.
        
        The AMI redirect action can fail to redirect two channels that are bridged
        together.  There is a race between the AMI thread redirecting the two
        channels and the bridge thread noticing that a channel is hungup from the
        redirects.
        
        * Made the bridge wait for both channels to be redirected before exiting.
        
        * Made the AMI redirect check that all required headers are present before
        proceeding with the redirection.
        
        * Made the AMI redirect require that any supplied ExtraChannel exist
        before proceeding.  Previously the code fell back to a single channel
        redirect operation.
        
        (closes issue ASTERISK-18975)
        Reported by: Ben Klang
        
        (closes issue ASTERISK-19948)
        Reported by: Brent Dalgleish
        Patches:
              jira_asterisk_19948_v11.patch (license #5621) patch uploaded by rmudgett
        Tested by: rmudgett, Thomas Sevestre, Deepak Lohani, Kayode
        
        Review: https://reviewboard.asterisk.org/r/2243/
        ........
        
        Merged revisions 378356 from http://svn.asterisk.org/svn/asterisk/branches/1.8
        ........
        
        Merged revisions 378358 from http://svn.asterisk.org/svn/asterisk/branches/11
      ................
        r378377 | mjordan | 2013-01-02 16:10:32 -0600 (Wed, 02 Jan 2013) | 24 lines
        
        Prevent crashes from occurring when reading from data sources with large values
        
        When reading configuration data from an Asterisk .conf file or when pulling
        data from an Asterisk RealTime backend, Asterisk was copying the data on the
        stack for manipulation. Unfortunately, it is possible to read configuration
        data or realtime data from some data source that provides a large blob of
        characters. This could potentially cause a crash via a stack overflow.
        
        This patch prevents large sets of data from being read from an ARA backend or
        from an Asterisk conf file.
        
        (issue ASTERISK-20658)
        Reported by: wdoekes
        Tested by: wdoekes, mmichelson
        patches:
         * issueA20658_dont_process_overlong_config_lines.patch uploaded by wdoekes (license 5674)
         * issueA20658_func_realtime_limit.patch uploaded by wdoekes (license 5674)
        ........
        
        Merged revisions 378375 from http://svn.asterisk.org/svn/asterisk/branches/1.8
        ........
        
        Merged revisions 378376 from http://svn.asterisk.org/svn/asterisk/branches/11
      ................
        r378384 | mjordan | 2013-01-02 16:19:32 -0600 (Wed, 02 Jan 2013) | 11 lines
        
        Clean up app_mysql's application entry points to properly parse arguments
        
        When parsing arguments, application entry points should not attempt to
        directly modify the parameters to the function. This patch properly duplicates
        the passed in parameters before attempting to parse them.
        
        (issue ASTERISK-20658)
        Reported by: wdoekes
        patches:
          issueA20658_sanitize_app_mysql.patch uploaded by wdoekes (license 5674)
      ................
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/team/mmichelson/threadpool@378385 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      b375abae
    • Matthew Jordan's avatar
      Clean up app_mysql's application entry points to properly parse arguments · 473ec0b1
      Matthew Jordan authored
      When parsing arguments, application entry points should not attempt to
      directly modify the parameters to the function. This patch properly duplicates
      the passed in parameters before attempting to parse them.
      
      (issue ASTERISK-20658)
      Reported by: wdoekes
      patches:
        issueA20658_sanitize_app_mysql.patch uploaded by wdoekes (license 5674)
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@378384 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      473ec0b1
  29. Dec 10, 2012
Loading