Skip to content
Snippets Groups Projects
  1. Sep 13, 2021
    • Naveen Albert's avatar
      app_stack: Include current location if branch fails · c736cef3
      Naveen Albert authored
      Previously, the error emitted when app_stack tries
      to branch to a dialplan location that doesn't exist
      has included only the information about the attempted
      branch in the error log. This adds the current location
      as well so users can see where the branch failed in
      the logs.
      
      ASTERISK-29626
      
      Change-Id: Ia23502ab2ad21485a1ac74295063a8f25a6df5ce
      c736cef3
  2. Sep 10, 2021
    • Sungtae Kim's avatar
      resource_channels.c: Fix external media data option · d9747104
      Sungtae Kim authored
      Fixed the external media creation handle to handle the 'data' option correctly.
      
      ASTERISK-29629
      
      Change-Id: I22e57fe8ebf3d3e08fb2121aa4a8a52cc62e8129
      d9747104
    • Naveen Albert's avatar
      func_strings: Add STRBETWEEN function · 6198c1d2
      Naveen Albert authored
      Adds the STRBETWEEN function, which can be used to insert a
      substring between each character in a string. For instance,
      this can be used to insert pauses between DTMF tones in a
      string of digits.
      
      ASTERISK-29627
      
      Change-Id: Ice23009d4a8e9bb9718d2b2301d405567087d258
      6198c1d2
    • Sean Bright's avatar
      test_abstract_jb.c: Fix put and put_out_of_order memory leaks. · ee62a079
      Sean Bright authored
      We can't rely on RAII_VAR(...) to properly clean up data that is
      allocated within a loop.
      
      ASTERISK-27176 #close
      
      Change-Id: Ib575616101230c4f603519114ec62ebf3936882c
      ee62a079
    • Naveen Albert's avatar
      func_env: Add DIRNAME and BASENAME functions · 19de228e
      Naveen Albert authored
      Adds the DIRNAME and BASENAME functions, which are
      wrappers around the corresponding C library functions.
      These can be used to safely and conveniently work with
      file paths and names in the dialplan.
      
      ASTERISK-29628 #close
      
      Change-Id: Id3aeb907f65c0ff96b6e57751ff0cb49d61db7f3
      19de228e
    • Naveen Albert's avatar
      func_sayfiles: Retrieve say file names · b6b7b149
      Naveen Albert authored
      Up until now, all of the logic used to translate
      arguments to the Say applications has been
      directly coupled to playback, preventing other
      modules from using this logic.
      
      This refactors code in say.c and adds a SAYFILES
      function that can be used to retrieve the file
      names that would be played. These can then be
      used in other applications or for other purposes.
      
      Additionally, a SayMoney application and a SayOrdinal
      application are added. Both SayOrdinal and SayNumber
      are also expanded to support integers greater than
      one billion.
      
      ASTERISK-29531
      
      Change-Id: If9718c89353b8e153d84add3cc4637b79585db19
      b6b7b149
    • Naveen Albert's avatar
      res_tonedetect: Tone detection module · a6eb1b6f
      Naveen Albert authored
      dsp.c contains arbitrary tone detection functionality
      which is currently only used for fax tone recognition.
      This change makes this functionality publicly
      accessible so that other modules can take advantage
      of this.
      
      Additionally, a WaitForTone and TONE_DETECT app and
      function are included to allow users to do their
      own tone detection operations in the dialplan.
      
      ASTERISK-29546
      
      Change-Id: Ie38c395000f4fd4d04e942e8658e177f8f499b26
      a6eb1b6f
    • George Joseph's avatar
      res_snmp: Add -fPIC to _ASTCFLAGS · 2806a450
      George Joseph authored
      With gcc 11, res/res_snmp.c and res/snmp/agent.c need the
      -fPIC option added to its _ASTCFLAGS.
      
      ASTERISK-29634
      
      Change-Id: I34649c85e075fd954e578378fabf798c3f038f50
      2806a450
  3. Sep 09, 2021
    • Sean Bright's avatar
      term.c: Add support for extended number format terminfo files. · 858cb386
      Sean Bright authored
      ncurses 6.1 introduced an extended number format for terminfo files
      which the terminfo parsing in Asterisk is not able to parse. This
      results in some TERM values that do support color (screen-256color on
      Ubuntu 20.04 for example) to not get a color console.
      
      ASTERISK-29630 #close
      
      Change-Id: I27a4fcfab502219924af2d6b1c46feba92903cb3
      858cb386
    • Sean Bright's avatar
      app_voicemail.c: Ability to silence instructions if greeting is present. · 347e9a7e
      Sean Bright authored
      There is an option to silence voicemail instructions but it does not
      take into consideration if a recorded greeting exists or not. Add a
      new 'S' option that does that.
      
      ASTERISK-29632 #close
      
      Change-Id: I03f2f043a9beb9d99deab302247e2a8686066fb4
      347e9a7e
  4. Sep 08, 2021
    • Jasper Hafkenscheid's avatar
      res_srtp: Disable parsing of not enabled cryptos · c1a57590
      Jasper Hafkenscheid authored
      When compiled without extended srtp crypto suites also disable parsing
      these from received SDP. This prevents using these, as some client
      implementations are not stable.
      
      ASTERISK-29625
      
      Change-Id: I7dafb29be1cdaabdc984002573f4bea87520533a
      c1a57590
    • Sean Bright's avatar
      dns.c: Load IPv6 DNS resolvers if configured. · 689c703b
      Sean Bright authored
      IPv6 nameserver addresses are stored in different part of the
      __res_state structure, so look there if we appear to have support for
      it.
      
      ASTERISK-28004 #close
      
      Change-Id: I67067077d8a406ee996664518d9c8fbf11f6977d
      689c703b
    • George Joseph's avatar
      bridge_softmix: Suppress error on topology change failure · de19836c
      George Joseph authored
      There are conditions under which a failure to change topology
      is expected so there's no need to print an ERROR message.
      
      ASTERISK-29618
      Reported by: Alexander
      
      Change-Id: Idc168b8588e018bf3a23769f08c4ad646086d481
      de19836c
  5. Sep 02, 2021
    • sungtae kim's avatar
      resource_channels.c: Fix wrong external media parameter parse · 479cc17f
      sungtae kim authored
      Fixed ARI external media handler to accept body parameters.
      
      ASTERISK-29622
      
      Change-Id: I49509c48a6cbc0fb4165bfa4f834b5e8b9ace20d
      479cc17f
    • Sean Bright's avatar
      config_options: Handle ACO arrays correctly in generated XML docs. · 5c836c8e
      Sean Bright authored
      There are 3 separate changes here but they are all closely related:
      
      * Only try to set matchfield attributes on 'field' nodes
      
      * We need to adjust how we treat the category pointer based on the
        value of the category_match, to avoid memory corruption. We now
        generate a regex-like string when match types other than
        ACO_WHITELIST and ACO_BLACKLIST are used.
      
      * Switch app_agent_pool from ACO_BLACKLIST_ARRAY to
        ACO_BLACKLIST_EXACT since we only have one category we need to
        ignore, not two.
      
      ASTERISK-29614 #close
      
      Change-Id: I7be7bdb1bb9814f942bc6bb4fdd0a55a7b7efe1e
      5c836c8e
    • Naveen Albert's avatar
      chan_iax2: Add ANI2/OLI information element · 5a685249
      Naveen Albert authored
      Adds an information element for ANI2 so that
      Originating Line Information can be transmitted
      over IAX2 channels.
      
      ASTERISK-29605 #close
      
      Change-Id: Iaeacdf6ccde18eaff7f776a0f49fee87dcb549d2
      5a685249
    • Mark Murawski's avatar
      pbx_ael: Fix crash and lockup issue regarding 'ael reload' · 042ae05b
      Mark Murawski authored
      Currently pbx_ael does not check if a reload is currently pending
      before proceeding with a reload. This can cause multiple threads to
      operate at the same time on what should be mutex protected data. This
      change adds protection to reloading to ensure only one ael reload is
      executing at a time.
      
      ASTERISK-29609 #close
      
      Change-Id: I5ed392ad226f6e4e7696ad742076d3e45c57af35
      042ae05b
  6. Sep 01, 2021
    • Naveen Albert's avatar
      app_read: Allow reading # as a digit · dd980e00
      Naveen Albert authored
      Allows for the digit # to be read as a digit,
      just like any other DTMF digit, as opposed to
      forcing it to be used as an end of input
      indicator. The default behavior remains
      unchanged.
      
      ASTERISK-18454 #close
      
      Change-Id: I3033432adb9d296ad227e76b540b8b4a2417665b
      dd980e00
    • Sebastien Duthil's avatar
      res_rtp_asterisk: Automatically refresh stunaddr from DNS · ac492f2f
      Sebastien Duthil authored
      This allows the STUN server to change its IP address without having to
      reload the res_rtp_asterisk module.
      
      The refresh of the name resolution occurs first when the module is
      loaded, then recurringly, slightly after the previous DNS answer TTL
      expires.
      
      ASTERISK-29508 #close
      
      Change-Id: I7955a046293f913ba121bbd82153b04439e3465f
      ac492f2f
  7. Aug 26, 2021
    • Naveen Albert's avatar
      bridge_basic: Change warning to verbose if transfer cancelled · e660a2c0
      Naveen Albert authored
      The attended transfer feature will emit a warning if the user
      cancels the transfer or the attended transfer doesn't complete
      for any reason. Changes the warning to a verbose message,
      since nothing is actually wrong here.
      
      ASTERISK-29612 #close
      
      Change-Id: I64c93cdb21360a0a8d45e9cb6db3af8168f66e6d
      e660a2c0
  8. Aug 25, 2021
  9. Aug 20, 2021
    • Sarah Autumn's avatar
      sig_analog: Changes to improve electromechanical signalling compatibility · 241686f8
      Sarah Autumn authored
      This changeset is intended to address compatibility issues encountered
      when interfacing Asterisk to electromechanical telephone switches that
      implement ANI-B, ANI-C, or ANI-D.
      
      In particular the behaviours that this impacts include:
      
       - FGC-CAMA did not work at all when using MF signaling. Modified the
         switch case block to send calls to the correct part of the
         signaling-handling state machine.
      
       - For FGC-CAMA operation, the delay between called number ST and
         second wink for ANI spill has been made configurable; previously
         all calls were made to wait for one full second.
      
       - After the ANI spill, previous behavior was to require a 'ST' tone
         to advance the call.  This has been changed to allow 'STP' 'ST2P'
         or 'ST3P' as well, for compatibility with ANI-D.
      
       - Store ANI2 (ANI INFO) digits in the CALLERID(ANI2) channel variable.
      
       - For calls with an ANI failure, No. 1 Crossbar switches will send
         forward a single-digit failure code, with no calling number digits
         and no ST pulse to terminate the spill.  I've made the ANI timeout
         configurable so to reduce dead air time on calls with ANI fail.
      
       - ANI info digits configurable.  Modern digital switches will send 2
         digits, but ANI-B sends only a single info digit.  This caused the
         ANI reported by Asterisk to be misaligned.
      
       - Changed a confusing log message to be more informative.
      
      ASTERISK-29518
      
      Change-Id: Ib7e27d987aee4ed9bc3663c57ef413e21b404256
      241686f8
    • Andre Barbosa's avatar
      media_cache: Don't lock when curl the remote file · eb486db3
      Andre Barbosa authored
      When playing a remote sound file, which is not in cache, first we need
      to download it with ast_bucket_file_retrieve.
      
      This can take a while if the remote host is slow. The current CURL
      timeout is 180secs, so in extreme situations, it can take 3 minutes to
      return.
      
      Because ast_media_cache_retrieve has a lock on all function, while we
      are waiting for the delayed download, Asterisk is not able to play any
      more files, even the files already cached locally.
      
      ASTERISK-29544 #close
      
      Change-Id: I8d4142b463ae4a1d4c41bff2bf63324821567408
      eb486db3
  10. Aug 19, 2021
    • George Joseph's avatar
      res_pjproject: Allow mapping to Asterisk TRACE level · b72425b1
      George Joseph authored
      Allow mapping pjproject log messages to the Asterisk TRACE
      log level.  The defaults were also changes to log pjproject
      levels 3,4 to DEBUG and 5,6 to TRACE.  Previously 3,4,5,6
      all went to DEBUG.
      
      ASTERISK-29582
      
      Change-Id: I859a37a8dec263ed68099709cfbd3e665324c72d
      b72425b1
    • Naveen Albert's avatar
      app_milliwatt: Timing fix · dffc5e7f
      Naveen Albert authored
      The Milliwatt application uses incorrect tone timings
      that cause it to play the 1004 Hz tone constantly.
      
      This adds an option to enable the correct timing
      behavior, so that the Milliwatt application can
      be used for milliwatt test lines. The default behavior
      remains unchanged for compatability reasons, even
      though it is incorrect.
      
      ASTERISK-29575 #close
      
      Change-Id: I73ccc6c6fcaa31931c6fff3b85ad1805b2ce9d8c
      dffc5e7f
    • Naveen Albert's avatar
      func_math: Return integer instead of float if possible · c52ef4ac
      Naveen Albert authored
      The MIN, MAX, and ABS functions all support float
      arguments, but currently return floats even if the
      arguments are all integers and the response is
      a whole number, in which case the user is likely
      expecting an integer. This casts the float to an integer
      before printing into the response buffer if possible.
      
      ASTERISK-29495
      
      Change-Id: I902d29eacf3ecd0f8a6a5e433c97f0421d205488
      c52ef4ac
    • Naveen Albert's avatar
      app_morsecode: Add American Morse code · 9cac1c16
      Naveen Albert authored
      Previously, the Morsecode application only supported international
      Morse code. This adds support for American Morse code and adds an
      option to configure the frequency used in off intervals.
      
      Additionally, the application checks for hangup between tones
      to prevent application execution from continuing after hangup.
      
      ASTERISK-29541
      
      Change-Id: I172431a2e18e6527d577e74adfb05b154cba7bd4
      9cac1c16
    • Naveen Albert's avatar
      func_scramble: Audio scrambler function · 3eec5b8c
      Naveen Albert authored
      Adds a function to scramble audio on a channel using
      whole spectrum frequency inversion. This can be used
      as a privacy enhancement with applications like
      ChanSpy or other potentially sensitive audio.
      
      ASTERISK-29542
      
      Change-Id: I01020769d91060a1f56a708eb405f87648d1a67e
      3eec5b8c
    • Naveen Albert's avatar
      app_originate: Add ability to set codecs · cb1dfecc
      Naveen Albert authored
      A list of codecs to use for dialplan-originated calls can
      now be specified in Originate, similar to the ability
      in call files and the manager action.
      
      Additionally, we now default to just using the slin codec
      for originated calls, rather than all the slin* codecs up
      through slin192, which has been known to cause issues
      and inconsistencies from AMI and call file behavior.
      
      ASTERISK-29543
      
      Change-Id: I96a1aeb83d54b635b7a51e1b4680f03791622883
      cb1dfecc
    • Alexander Traud's avatar
      BuildSystem: Remove two dead exceptions for compiler Clang. · a8e8b3aa
      Alexander Traud authored
      Commit 305ce3de added -Wno-parentheses-equality to Makefile.rules,
      turning the previous two warning suppressions from commit e9520dbe
      redundant. Let us remove the latter.
      
      Change-Id: I0b471254b31e6e05902062761dded4b3e626c7ac
      a8e8b3aa
  11. Aug 16, 2021
    • Sean Bright's avatar
      mgcp: Remove dead debug code · 121860e3
      Sean Bright authored
      ASTERISK-20339 #close
      
      Change-Id: I36f364aaa1971241d8f3ea1a5909b463d185a2d5
      121860e3
    • Joshua C. Colp's avatar
      policy: Add deprecation and removal versions to modules. · 13fd0789
      Joshua C. Colp authored
      app_meetme is deprecated in 19, to be removed in 21.
      app_osplookup is deprecated in 19, to be removed in 21.
      chan_alsa is deprecated in 19, to be removed in 21.
      chan_mgcp is deprecated in 19, to be removed in 21.
      chan_skinny is deprecated in 19, to be removed in 21.
      res_pktccops is deprecated in 19, to be removed in 21.
      cdr_mysql was deprecated in 1.8, to be removed in 19.
      app_mysql was deprecated in 1.8, to be removed in 19.
      app_ices was deprecated in 16, to be removed in 19.
      app_macro was deprecated in 16, to be removed in 21.
      app_fax was deprecated in 16, to be removed in 19.
      app_url was deprecated in 16, to be removed in 19.
      app_image was deprecated in 16, to be removed in 19.
      app_nbscat was deprecated in 16, to be removed in 19.
      app_dahdiras was deprecated in 16, to be removed in 19.
      cdr_syslog was deprecated in 16, to be removed in 19.
      chan_oss was deprecated in 16, to be removed in 19.
      chan_phone was deprecated in 16, to be removed in 19.
      chan_sip was deprecated in 17, to be removed in 21.
      chan_nbs was deprecated in 16, to be removed in 19.
      chan_misdn was deprecated in 16, to be removed in 19.
      chan_vpb was deprecated in 16, to be removed in 19.
      res_config_sqlite was deprecated in 16, to be removed in 19.
      res_monitor was deprecated in 16, to be removed in 21.
      conf2ael was deprecated in 16, to be removed in 19.
      muted was deprecated in 16, to be removed in 19.
      
      ASTERISK-29548
      ASTERISK-29549
      ASTERISK-29550
      ASTERISK-29551
      ASTERISK-29552
      ASTERISK-29553
      ASTERISK-29554
      ASTERISK-29555
      ASTERISK-29557
      ASTERISK-29558
      ASTERISK-29559
      ASTERISK-29560
      ASTERISK-29561
      ASTERISK-29562
      ASTERISK-29563
      ASTERISK-29564
      ASTERISK-29565
      ASTERISK-29566
      ASTERISK-29567
      ASTERISK-29568
      ASTERISK-29569
      ASTERISK-29570
      ASTERISK-29571
      ASTERISK-29572
      ASTERISK-29573
      ASTERISK-29574
      
      Change-Id: Ic3bee31a10d42c4b3bbc913d893f7b2a28a27131
      13fd0789
  12. Aug 12, 2021
  13. Aug 09, 2021
    • Naveen Albert's avatar
      func_frame_drop: New function · 118d8482
      Naveen Albert authored
      Adds function to selectively drop specified frames
      in the TX or RX direction on a channel, including
      control frames.
      
      ASTERISK-29478
      
      Change-Id: I8147c9d55d74e2e48861edba6b22f930920541ec
      118d8482
  14. Aug 06, 2021
    • Alexander Traud's avatar
      aelparse: Accept an included context with timings. · 0b1a629e
      Alexander Traud authored
      With Asterisk 1.6.0, in the main parser for the configuration file
      extensions.conf, the separator was changed from vertical bar to comma.
      However, the first separator was not changed in aelparse; it still had
      to be a vertical bar, and no comma was allowed.
      
      Additionally, this change allows the vertical bar for the first and
      last parameter again, even in the main parser, because the vertical bar
      was still accepted for the other parameters.
      
      ASTERISK-29540
      
      Change-Id: I882e17c73adf4bf2f20f9046390860d04a9f8d81
      0b1a629e
    • Kevin Harwell's avatar
      format_ogg_speex: Implement a "not supported" write handler · 62883092
      Kevin Harwell authored
      This format did not specify a "write" handler, so when attempting to write
      to it (ast_writestream) a crash would occur.
      
      This patch adds a default handler that simply issues a "not supported"
      warning, thus no longer crashing.
      
      ASTERISK-29539
      
      Change-Id: I8f6ddc7cc3b15da30803be3b1cf68e2ba0fbce91
      62883092
  15. Aug 04, 2021
    • Naveen Albert's avatar
      cdr_adaptive_odbc: Prevent filter warnings · adf707f2
      Naveen Albert authored
      Previously, if CDR filters were used so that
      not all CDR records used all sections defined
      in cdr_adaptive_odbc.conf, then warnings will
      always be emitted (if each CDR record is unique
      to a particular section, n-1 warnings to be
      specific).
      
      This turns the offending warning log into
      a verbose message like the other one, since
      this behavior is intentional and not
      indicative of anything wrong.
      
      ASTERISK-29494
      
      Change-Id: Ifd314fa9298722bc99494d5ca2658a5caa94a5f8
      adf707f2
    • Naveen Albert's avatar
      app_queue: Allow streaming multiple announcement files · 940f6c4a
      Naveen Albert authored
      Allows multiple files comprising an agent announcement
      to be played by separating on the ampersand, similar
      to the multi-file support in other Asterisk applications.
      
      ASTERISK-29528
      
      Change-Id: Iec600d8cd5ba14aa1e4e37f906accb356cd7891a
      940f6c4a
Loading