Skip to content
Snippets Groups Projects
  1. Mar 26, 2019
  2. Mar 22, 2019
  3. Mar 19, 2019
  4. Mar 18, 2019
    • George Joseph's avatar
      sorcery.c: Sorcery enhancements for wizard management · 7e77815a
      George Joseph authored
      Added ability to specifiy a wizard is read-only when applying
      it to a specific object type.  This allows you to specify
      create, update and delete callbacks for the wizard but limit
      which object types can use them.
      
      Added the ability to allow an object type to have multiple
      wizards of the same type.  This is indicated when a wizard
      is added to a specific object type.
      
      Added 3 new sorcery wizard functions:
      
      * ast_sorcery_object_type_insert_wizard which does the same thing
        as the existing ast_sorcery_insert_wizard_mapping function but
        accepts the new read-only and allot-duplicates flags and also
        returns the ast_sorcery_wizard structure used and it's internal
        data structure. This allows immediate use of the wizard's
        callbacks without having to register a "wizard mapped" observer.
      
      * ast_sorcery_object_type_apply_wizard which does the same
        thing as the existing ast_sorcery_apply_wizard_mapping function
        but has the added capabilities of
        ast_sorcery_object_type_insert_wizard.
      
      * ast_sorcery_object_type_remove_wizard which removes a wizard
        matching both its name and its original argument string.
      
      * The original logic in __ast_sorcery_insert_wizard_mapping was moved
        to __ast_sorcery_object_type_insert_wizard and enhanced for the
        new capabilities, then __ast_sorcery_insert_wizard_mapping was
        refactored to just call __ast_sorcery_insert_wizard_mapping.
      
      * Added a unit test to test_sorcery.c to test the read-only
        capability.
      
      Change-Id: I40f35840252e4313d99e11dbd80e270a3aa10605
      7e77815a
    • Joshua Colp's avatar
    • Joshua Colp's avatar
    • Joshua Colp's avatar
  5. Mar 15, 2019
  6. Mar 14, 2019
    • Richard Mudgett's avatar
      taskprocessor.c: Fix printf type mismatch · 45a8892e
      Richard Mudgett authored
      A size_t is not always an unsigned long.
      
      * Use the %zu format specifier in the ast_cli() printf format string since
      AST_VECTOR_SIZE() returns a size_t value.
      
      Change-Id: Ib102dd36bbe6c2a7a4ce6870ae9110d978dd7e98
      45a8892e
    • George Joseph's avatar
      app.c: Remove deletion of pool topic on mwi state delete · 63d90c38
      George Joseph authored
      As part of an earlier voicemail refactor, ast_delete_mwi_state_full
      was modified to remove the pool topic for a mailbox when the state
      was deleted.  This was an attempt to prevent stale topics from
      accumulating when app_voicemail was reloaded and a mailbox went
      away.  Unfortunately because of the fact that when app_voicemail
      reloads, ALL mailboxes are deleted then only current ones recreated,
      topics were being removed from the pool that still had subscribers
      on them, then recreated as new topics of the same name.  So now
      modules like res_pjsip_mwi are listening on a topic that will
      never receive any messages because app_voicemail is publishing on
      a different topic that happens to have the same name.  The solutiuon
      to this is not easy and given that accumulating topics for
      deleted mailboxes is less evil that not sending NOTIFYs...
      
      * Removed the call to stasis_topic_pool_delete_topic in
        ast_delete_mwi_state_full.
      
      Also:
      
      * Fixed a topic reference leak in res_pjsip_mwi
        mwi_stasis_subscription_alloc.
      
      * Added some debugging to mwi_stasis_subscription_alloc,
        stasis_topic_create, and topic_dtor.
      
      * Fixed a topic reference leak in an error path in
        internal_stasis_subscribe.
      
      ASTERISK-28306
      Reported-by: Jared Hull
      
      Change-Id: Id7da0990b3ac4be4b58491536b35f41291247b27
      63d90c38
    • Joshua C. Colp's avatar
    • Joshua C. Colp's avatar
  7. Mar 13, 2019
  8. Mar 12, 2019
  9. Mar 11, 2019
    • sungtae kim's avatar
      res/res_ari: Added timestamp as a requirement for all ARI events · e2eb19b3
      sungtae kim authored
      Changed to requirement to having timestamp for all of ARI events.
      The below ARI events were changed to having timestamp.
      PlaybackStarted, PlaybackContinuing, PlaybackFinished,
      RecordingStarted, RecordingFinished, RecordingFailed,
      ApplicationReplaced, ApplicationMoveFailed
      
      ASTERISK-28326
      
      Change-Id: I382c2fef58f5fe107e1074869a6d05310accb41f
      e2eb19b3
    • Chris-Savinovich's avatar
      partial-inlining: disable partial-inlining if gcc>=8.2.1 · 449dff99
      Chris-Savinovich authored
      Apply flag -fno-partial-inlining on default optimization if and only if
      gcc version >= 8.2.1 (this is the current ver on Fedora and Ubuntu).
      This is done to avoid a bug that causes arithmetic calculations to fail
      if the following conditions are met:
      1. TEST_FRAMEWORK on
      2. DONT_OPTIMIZE off
      3. Fedora and Ubuntu
      4. GCC 8.2.1
      5. There must exist a certain combination of multithreading.
      6. Optimization level -O2 and -O3
      7. Flag -fpartial-inline activated (default when optimization level>=2)
      The following link points to a similar gcc bug reported in 2015. This leads me
      to believe the bug has regressed. Note I am not able to replicate this bug
      in an environment other than Asterisk + Test Framework + Test_cel because the
      multithreading combination that causes it seems to be unique. Therefore I
      am temporarily abandoning any thoughts of reporting the new occurrence of this
      bug to gcc.gnu.org.  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65307
      
      Change-Id: Ibd1afe60e0a38b88e85fdcd9b051004601c2f102
      449dff99
    • George Joseph's avatar
    • Friendly Automation's avatar
    • Joshua Colp's avatar
      stasis: Improve topic/subscription names and statistics. · 0231dd6a
      Joshua Colp authored
      Topic names now follow: <subsystem>:<functionality>[/<object>]
      
      This ensures that they are all unique, and also provides better
      insight in to what each topic is for.
      
      Subscriber ids now also use the main topic name they are
      subscribed to and an incrementing integer as their identifier to
      make it easier to understand what the subscription is primarily
      responsible for.
      
      Both the CLI commands for listing topic and subscription statistics
      now sort to make it a bit easier to see what is going on.
      
      Subscriptions will now show all topics that they are receiving messages
      from, not just the main topic they were subscribed to.
      
      ASTERISK-28335
      
      Change-Id: I484e971a38c3640f2bd156282e532eed84bf220d
      0231dd6a
    • cirillor's avatar
      chan_dahdi: Add logical group at DAHDIChannel event and CHANNEL function · 0d6d51b1
      cirillor authored
      Add logical group at DAHDIChannel event
      and create "dahdi_group" at CHANNEL function.
      
      ASTERISK-28317
      
      Change-Id: Ic1f834cd53982a9707a9748395ee746d6575086a
      0d6d51b1
    • sungtae kim's avatar
      res/res_rtp_asterisk.c: Fixing possible divide by zero · 8641fd97
      sungtae kim authored
      Currently, when the Asterisk calculates rtp statistics, it uses
      sample_count as a unsigned integer parameter. This would be fine
      for most of cases, but in case of large enough number of sample_count,
      this might be causing the divide by zero error.
      
      ASTERISK-28321
      
      Change-Id: If7e0629abaceddd2166eb012456c53033ea26249
      8641fd97
  10. Mar 08, 2019
Loading