Skip to content
Snippets Groups Projects
  1. May 13, 2015
    • Alexandre Fournier's avatar
      res_config_mysql: Fix broken column type checking · 9370db10
      Alexandre Fournier authored
      MySQL configuration engine contains a bug in require_mysql(). This
      function is used for column type checking in tables. This bug only
      affects DATETIME, DATE and FLOAT types.
      
      It came from mixing the first condition (switch-case-like
      if/then/else), to check the expected column type, with the second
      condition, to check the actual column type against the expected column
      type. Both conditions must be checked separately in order to avoid the
      execution of the wrong block.
      
      ASTERISK-18252 #comment This patch might fix the issue
      Reported by: Gareth Blades
      
      ASTERISK-25041 #close
      Reported by: Alexandre Fournier
      Tested by: Alexandre Fournier
      
      Change-Id: I0b8bf7e68ab938be8e6525a249260cb648cb0bfa
      9370db10
  2. Apr 29, 2015
    • Ivan Poddubny's avatar
      addons/res_config_mysql: Don't mutate va_list parameters · 41bf5231
      Ivan Poddubny authored
      The realtime API passes down the va_list argument to each RT engine in
      failover chain until one succeeds. MySQL engine used to access the
      variable argument list with va_arg, which mutates the va_list, so the
      next engine in failover chain gets invalid agrument list.
      This patch uses va_copy to preserve the original va_list argument intact.
      
      ASTERISK-19538 #close
      Reported by: alexat
      Tested by: Ivan Poddubny
      
      Change-Id: I7738b9f98bde81ddfbc2c0fa579d85a0c3e580ae
      41bf5231
  3. Apr 12, 2015
    • George Joseph's avatar
      Add .gitignore and .gitreview files · 7079f53a
      George Joseph authored
      Add the .gitignore and .gitreview files to the asterisk repo.
      
      NB:  You can add local ignores to the .git/info/exclude file
      without having to do a commit.
      
      Common ignore patterns are in the top-level .gitignore file.
      Subdirectory-specific ignore patterns are in their own .gitignore
      files.
      
      Change-Id: I2b7513fc9acf5d432cf9587c25faa9786af14abf
      Tested-by: George Joseph
      7079f53a
  4. Jan 23, 2015
  5. Dec 17, 2014
    • Walter Doekes's avatar
      Fix printf problems with high ascii characters after r413586 (1.8). · 822abf9e
      Walter Doekes authored
      In r413586 (1.8) various casts were added to silence gcc 4.10 warnings.
      Those fixes included things like:
      
          -out += sprintf(out, "%%%02X", (unsigned char) *ptr);
          +out += sprintf(out, "%%%02X", (unsigned) *ptr);
      
      That works for low ascii characters, but for the high range that yields
      e.g. FFFFFFC3 when C3 is expected.
      
      This changeset:
      - fixes those casts to use the 'hh' unsigned char modifier instead
      - consistently uses %02x instead of %2.2x (or other non-standard usage)
      - adds a few 'h' modifiers in various places
      - fixes a 'replcaes' typo
      - dev/urandon typo (in 13+ patch)
      
      Review: https://reviewboard.asterisk.org/r/4263/
      
      ASTERISK-24619 #close
      Reported by: Stefan27 (on IRC)
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@429673 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      822abf9e
  6. Nov 09, 2014
    • Matthew Jordan's avatar
      addons/chan_mobile: Increase buffer size of UCS2 encoded SMS messages · 80439dac
      Matthew Jordan authored
      When UCS2 character encoding is used, one symbol in national language can be
      expanded to 4 bytes. The current buffer used for receiving message in
      do_monitor_phone is 256 bytes, which is not large enough for incoming messages.
      
      For example:
      * AT+CMGR phone response prefix
        '+CMGR: "REC UNREAD","+7**********",,"14/10/29,13:31:39+12"\r\n' - 60 bytes
      * SMS body with UCS2 encoding (max) - 280 bytes
      * AT+CMGR phone response suffix '\r\n\r\nOK\r\n' - 8 bytes
      * Terminating null character - 1 byte
      
      This results in a needed buffer size of 349 bytes. Hence, this patch opts for a
      350 byte buffer.
      
      ASTERISK-24468 #close
      Reported by: Dmitriy Bubnov
      patches:
        chan_mobile-1_8.diff uploaded by Dmitriy Bubnov (License 6651)
        chan_mobile-trunk.diff uploaded by Dmitry Bubnov (License 6651)
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@427607 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      80439dac
  7. Oct 15, 2014
  8. Jul 24, 2014
  9. Jul 22, 2014
  10. Jun 10, 2014
  11. May 19, 2014
  12. Mar 28, 2014
  13. Feb 22, 2014
  14. Feb 21, 2014
  15. Feb 19, 2014
  16. Dec 19, 2013
  17. Dec 18, 2013
  18. Dec 02, 2013
  19. Sep 03, 2013
  20. May 31, 2013
  21. Mar 12, 2013
  22. Feb 25, 2013
  23. Jan 17, 2013
    • Matthew Jordan's avatar
      Fix issue where chan_mobile fails to bind to first available port · b80431fe
      Matthew Jordan authored
      Per the bluez API, in order to bind to the first available port, the rc_channel
      field of the socket addressing structure used to bind the socket should be set
      to 0. Previously, Asterisk had set the rc_channel field set to 1, causing it
      to connect to whatever happens to be on port 1.
      
      We could probably not explicitly set rc_channel to 0 since we memset the struct
      earlier, but explicitly setting it will hopefully prevent someone from coming
      in and setting it to some explicit port in the future.
      
      (closes issue ASTERISK-16357)
      Reported by: challado
      Tested by: Alexander Heinz, Nikolay Ilduganov, benjamin, eliafino, David van Geyn
      patches:
        ASTERISK-16357.diff uploaded by Nikolay Ilduganov (license 6253)
      ........
      
      Merged revisions 379342 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@379343 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      b80431fe
  24. Jan 16, 2013
    • Matthew Jordan's avatar
      Fix parsing SMSSRC for SMS messages · f551978e
      Matthew Jordan authored
      The parser for SMS messages would incorrectly parse out the from number.
      The parsing would incorrectly start scanning for the from number at the
      same index as the first double quote ("); this would inadvertently cause
      it to treat the first double quote as the terminating double quote for
      the from number as well.
      
      The SMSSRC should now populate correctly.
      
      (closes issue ASTERISK-16822)
      Reported by: menschentier
      Tested by: Jonas Falck
      patches:
       fixSMSSRC.patch uploaded by jonax (license 6320)
      
      (closes issue ASTERISK-19153)
      Reported by: Panos Gkikakis
      patches:
        sms-sender-fix.diff uploaded by roeften (license 5884)  
      ........
      
      Merged revisions 379178 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@379179 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      f551978e
  25. Dec 10, 2012
  26. Nov 27, 2012
    • Richard Mudgett's avatar
      Remove unnecessary channel module references. · 37b50fe4
      Richard Mudgett authored
      * Removed call to ast_module_user_hangup_all() in res_config_mysql.c since
      it is effectively a noop.  No channels can attach a reference to that
      module.
      
      * Removed call to ast_module_user_hangup_all() in app_celgenuserevent.c.
      The caller of unload_module() has already called it.
      
      * Removed redundant channel module references in pbx_dundi.c.  The
      registered dialplan function callback dispatchers for the read/read2/write
      callbacks already reference the module before calling.
      
      * pbx_dundi: Moved unregistering CLI commands, DUNDi switch, and dialplan
      functions to the first thing the unload_module() does.  This will reduce
      the chance of new channels using DUNDi services while the module is being
      torn down.
      ........
      
      Merged revisions 376657 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 376658 from http://svn.asterisk.org/svn/asterisk/branches/10
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@376659 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      37b50fe4
  27. Aug 10, 2012
  28. Aug 09, 2012
  29. Jul 31, 2012
  30. Jul 30, 2012
    • Russell Bryant's avatar
      Allow specifying a port number for the MySQL server. · 9850a075
      Russell Bryant authored
      This patch allows you to specify a port number for the MySQL server.
      It's useful if a MySQL server is running on a non-standard port.
      Even though this module is deprecated in favor of func_odbc, someone
      asked for this feature and it seems pretty harmless to add.
      
      It has been tested using a number of combinations of with/without a
      port number specified in the dialplan and changing the port number
       for mysqld.
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@370534 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      9850a075
  31. Jul 18, 2012
  32. Jul 05, 2012
  33. Jul 04, 2012
Loading