Skip to content
Snippets Groups Projects
  1. Dec 22, 2017
  2. Mar 08, 2017
    • Sean Bright's avatar
      pbx_spool: Set AST_OUTGOING_ATTEMPT variable on channel · bc2c66b5
      Sean Bright authored
      Set a variable on the channel that indicates which attempt number we
      are currently performing to allow for attempt-specific behavior.
      
      ASTERISK-26568 #close
      Reported by: Roman Shubovich
      
      Change-Id: Iacd7e8d43b0ed5b6cb021c62f41f1a1f5733dd89
      bc2c66b5
  3. Mar 06, 2017
    • Sean Bright's avatar
      pbx_spool: Gracefully handle long lines in call files · 5a74abc5
      Sean Bright authored
      Per the linked issue, we aren't checking the buffer filled by fgets()
      to determine if it contains a newline, so we will fail to correctly
      parse the trailing portion of a long line.
      
      This patch increases the buffer size from 256 to 1024, and skips any
      line that exceeds that length, logging a warning in the process.
      
      ASTERISK-17067 #close
      Reported by: Dave Olszewski
      
      Change-Id: I51bcf270c1b4347ba05b43f18dc2094c76f5d7b0
      5a74abc5
  4. Feb 10, 2017
    • Sean Bright's avatar
      manager: Restore Originate failure behavior from Asterisk 11 · 09107730
      Sean Bright authored
      In Asterisk 11, if the 'Originate' AMI command failed to connect the provided
      Channel while in extension mode, a 'failed' extension would be looked up and
      run. This was, I believe, unintentionally removed in 51b6c496. This patch
      restores that behavior.
      
      This also adds an enum for the various 'synchronous' modes in an attempt to
      make them meaningful.
      
      ASTERISK-26115 #close
      Reported by: Nasir Iqbal
      
      Change-Id: I8afbd06725e99610e02adb529137d4800c05345d
      09107730
  5. Oct 27, 2016
    • Corey Farrell's avatar
      Remove ASTERISK_REGISTER_FILE. · a6e5bae3
      Corey Farrell authored
      ASTERISK_REGISTER_FILE no longer has any purpose so this commit removes
      all traces of it.
      
      Previously exported symbols removed:
      * __ast_register_file
      * __ast_unregister_file
      * ast_complete_source_filename
      
      This also removes the mtx_prof static variable that was declared when
      MTX_PROFILE was enabled.  This variable was only used in lock.c so it
      is now initialized in that file only.
      
      ASTERISK-26480 #close
      
      Change-Id: I1074af07d71f9e159c48ef36631aa432c86f9966
      a6e5bae3
  6. May 11, 2015
    • Ivan Poddubny's avatar
      pbx/pbx_spool: Fix issue when call files were executed too early · e6ebddd9
      Ivan Poddubny authored
      pbx_spool used to delete/move the call file upon successful outgoing
      call completion, but did not delete it from in-memory list of files
      (dirlist, used only when compiled with inotify/kqueue support).
      That resulted in an extra attempt to process that filename after
      retrytime seconds.
      Then, if a new file with the same name appears that is scheduled
      in future further than the completed one plus its retrytime,
      then it gets executed earlier than expected.
      
      This patch fixes remove_from_queue function to also remove the entry
      from the dirlist.
      
      ASTERISK-17069 #close
      Reported by: Jeremy Kister
      
      ASTERISK-24442 #close
      Reported by: tootai
      
      Change-Id: If9ec9b88073661ce485d6b008fd0b2612e49a28b
      e6ebddd9
  7. Apr 13, 2015
    • Matt Jordan's avatar
      git migration: Refactor the ASTERISK_FILE_VERSION macro · 4a582616
      Matt Jordan authored
      Git does not support the ability to replace a token with a version
      string during check-in. While it does have support for replacing a
      token on clone, this is somewhat sub-optimal: the token is replaced
      with the object hash, which is not particularly easy for human
      consumption. What's more, in practice, the source file version was often
      not terribly useful. Generally, when triaging bugs, the overall version
      of Asterisk is far more useful than an individual SVN version of a file. As a
      result, this patch removes Asterisk's support for showing source file
      versions.
      
      Specifically, it does the following:
      
      * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
        remove passing the version in with the macro. Other facilities
        than 'core show file version' make use of the file names, such as
        setting a debug level only on a specific file. As such, the act of
        registering source files with the Asterisk core still has use. The
        macro rename now reflects the new macro purpose.
      
      * main/asterisk:
        - Refactor the file_version structure to reflect that it no longer
          tracks a version field.
        - Remove the "core show file version" CLI command. Without the file
          version, it is no longer useful.
        - Remove the ast_file_version_find function. The file version is no
          longer tracked.
        - Rename ast_register_file_version/ast_unregister_file_version to
          ast_register_file/ast_unregister_file, respectively.
      
      * main/manager: Remove value from the Version key of the ModuleCheck
        Action. The actual key itself has not been removed, as doing so would
        absolutely constitute a backwards incompatible change. However, since
        the file version is no longer tracked, there is no need to attempt to
        include it in the Version key.
      
      * UPGRADE: Add notes for:
        - Modification to the ModuleCheck AMI Action
        - Removal of the "core show file version" CLI command
      
      Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
      4a582616
  8. Jan 30, 2015
  9. Jul 20, 2014
  10. Mar 07, 2014
    • Scott Griepentrog's avatar
      uniqueid: channel linkedid, ami, ari object creation with id's · 80ef9a21
      Scott Griepentrog authored
      Much needed was a way to assign id to objects on creation, and
      much change was necessary to accomplish it.  Channel uniqueids
      and linkedids are split into separate string and creation time
      components without breaking linkedid propgation.  This allowed
      the uniqueid to be specified by the user interface - and those
      values are now carried through to channel creation, adding the
      assignedids value to every function in the chain including the
      channel drivers. For local channels, the second channel can be
      specified or left to default to a ;2 suffix of first.  In ARI,
      bridge, playback, and snoop objects can also be created with a
      specified uniqueid.
      
      Along the way, the args order to allocating channels was fixed
      in chan_mgcp and chan_gtalk, and linkedid is no longer lost as
      masquerade occurs.
      
      (closes issue ASTERISK-23120)
      Review: https://reviewboard.asterisk.org/r/3191/
      ........
      
      Merged revisions 410157 from http://svn.asterisk.org/svn/asterisk/branches/12
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@410158 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      80ef9a21
  11. Oct 03, 2013
  12. Mar 15, 2013
  13. Nov 14, 2012
  14. Oct 08, 2012
    • Richard Mudgett's avatar
      Fix deletion of unopenable spool files. · ab548bb0
      Richard Mudgett authored
      If scan_service() cannot open the spool file, it logs a message saying
      that it will delete the file and calls remove_from_queue() to do it.
      However, remove_from_queue() fails to delete the spool file because struct
      outgoing has not yet been fully initialized.
      
      * Merged allocating a new struct outgoing and init_outgoing() into
      new_outgoing().  Allocation is initialization.
      
      * Made apply_outgoing() not initialize the spool filename in struct
      outgoing.
      
      * Made apply_outgoing() call ast_trim_blanks() and ast_skip_blanks()
      rather than manually inlining them.
      
      * Reduced indentation levels in apply_outgoing().
      
      * Fixed a garbled comment in remove_from_queue().
      
      * Reworked scan_service() to simplify it.
      
      (closes issue ASTERISK-17231)
      Reported by: David Chappell
      Patches:
            spool_open_failure.diff (license #4997) patch uploaded by David Chappell
            Started with this patch.
      ........
      
      Merged revisions 374686 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      
      * Fixed some memory leaks on off nominal paths in init_outgoing() when
      merging into the new_outgoing() function dealing with o->capabilities.
      ........
      
      Merged revisions 374695 from http://svn.asterisk.org/svn/asterisk/branches/10
      ........
      
      Merged revisions 374708 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@374717 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      ab548bb0
  15. Aug 08, 2012
  16. Jul 31, 2012
  17. Feb 13, 2012
  18. Feb 01, 2012
  19. Oct 25, 2011
  20. Jul 14, 2011
  21. Feb 04, 2011
  22. Feb 03, 2011
  23. Nov 10, 2010
  24. Oct 18, 2010
  25. Oct 03, 2010
  26. Sep 07, 2010
  27. May 13, 2010
  28. Mar 27, 2010
  29. Nov 04, 2009
  30. Aug 10, 2009
  31. May 02, 2009
  32. Mar 03, 2009
  33. Dec 03, 2008
  34. Oct 14, 2008
  35. Jun 18, 2008
Loading