Skip to content
Snippets Groups Projects
  1. Mar 24, 2017
  2. Mar 23, 2017
    • Kevin Harwell's avatar
      AMI: Updated version · d2f2cdf4
      Kevin Harwell authored
      Updated the AMI version for the following reason (see CHANGES for more details):
      
      The 'PJSIPShowEndpoint' command's response event of 'IdentifyDetail' now
      contains a new optional parameter, 'MatchHeader'.
      
      Change-Id: Ie206913ef1dcfa6a2ebe3282da2387e52d6f05b9
      d2f2cdf4
    • Kevin Harwell's avatar
      pjproject_bundled: raise timeout value used when downloading · 12dde3b5
      Kevin Harwell authored
      After configuring Asterisk with '--with-pjproject-bundled' the configure/build
      process attempts to download pjproject from its download site. Currently, a
      timeout of 10 seconds is used that will stop the download process if pjproject
      has not been fully downloaded in that time. For some systems this was not enough
      time and the process was timing out too early.
      
      This patch raises the download timeout value to '60'. Also, this patch fixes
      another bug where the DOWNLOAD_TIMEOUT variable was not being properly exported
      due to a naming error. DOWNLOAD_MAX_TIMEOUT is now properly renamed to
      DOWNLOAD_TIMEOUT.
      
      ASTERISK-26814 #close
      
      Change-Id: Ia56e4e8a3d39db76bc8a1852b2cf07ec10b39842
      12dde3b5
    • Sean Bright's avatar
      res_xmpp: Correct implementation of JABBER_STATUS & JabberStatus · 98a88e9f
      Sean Bright authored
      The documentation for JABBER_STATUS (and the deprecated JabberStatus
      app) indicate that a return value of 7 indicates that the specified
      buddy was not in the roster. It also indicates that you can specify a
      "bare" JID (one without a resource). Unfortunately the actual behavior
      does not match the documented behavior.
      
      Assuming that our roster includes the buddy online and available
      "valid@example.org/Valid" and does *not* include the buddy
      "invalid@example.org", the JABBER_STATUS() function returns the
      following before this patch:
      
      +------------------------------+------------+--------------------------+
      | Buddy                        | Status     | Result                   |
      +------------------------------+------------+--------------------------+
      | valid@example.org            |  Online    |  7 (Not in roster)       |
      | valid@example.org/Valid      |  Online    |  1 (Online)              |
      | valid@example.org/Invalid    |  N/A       |  7 (Not in roster)       |
      | invalid@example.org          |  N/A       |  Error logged, no return |
      | invalid@example.org/Valid    |  N/A       |  Error logged, no return |
      +------------------------------+------------+--------------------------+
      
      And after this patch:
      
      +------------------------------+------------+--------------------------+
      | Buddy                        | Status     | Result                   |
      +------------------------------+------------+--------------------------+
      | valid@example.org            |  Online    |  1 (Online)              |
      | valid@example.org/Valid      |  Online    |  1 (Online)              |
      | valid@example.org/Invalid    |  N/A       |  6 (Offline)             |
      | invalid@example.org          |  N/A       |  7 (Not in roster)       |
      | invalid@example.org/Valid    |  N/A       |  7 (Not in roster)       |
      +------------------------------+------------+--------------------------+
      
      This brings the behavior in line with the documentation.
      
      ASTERISK-23510 #close
      Reported by: Anthony Critelli
      
      Change-Id: I9c3241035363ef4a6bdc21fabfd8ffcd9ec657bf
      98a88e9f
    • Sean Bright's avatar
      res_xmpp: Try to provide useful errors messages from OpenSSL · be94105d
      Sean Bright authored
      If any errors occur during the TLS connection setup, we currently dump a
      fairly generic error message. So instead we try to pull in something
      useful from OpenSSL to report instead.
      
      ASTERISK-24712
      Reported by: Matthias Urlichs
      
      Change-Id: I288500991a9681f447d92913b11fedaf426087f4
      be94105d
    • Sean Bright's avatar
      res_xmpp: Correctly check return value of SSL_connect · 94939814
      Sean Bright authored
      SSL_connect returns non-zero for both success and some error conditions
      so simply negating is inadequate.
      
      Change-Id: Ifbf882896e598703b6c615407fa456d3199f95b1
      94939814
    • Sean Bright's avatar
      res_xmpp: Don't crash when trying to send a message without a connection · 7657c279
      Sean Bright authored
      If we never establish a connection to our Jabber server, iksemel never sets up
      its internal transport pointer, so attempting to send a message dereferences a
      NULL pointer and causes a crash.
      
      ASTERISK-21855 #close
      Reported by: Jeremy Kister
      
      Change-Id: I204a568894e4a53ab929783ecc594a000f04d79c
      7657c279
    • Sean Bright's avatar
      res_xmpp: Include client name in connection related error messages · 0136ec12
      Sean Bright authored
      ASTERISK-25622 #close
      Reported by: Sean Darcy
      
      Change-Id: I8472cb7bfb58d411a3cfbd482da98cae2d94d1e9
      0136ec12
  3. Mar 22, 2017
  4. Mar 21, 2017
  5. Mar 20, 2017
    • Sean Bright's avatar
      bridge_softmix: Ignore non-voice frames from translator · fc794de7
      Sean Bright authored
      Some codecs - codec_speex specifically - take voice frames and return
      other types of frames, like CNG. If we subsequently treat those as
      voice frames, we'll run into trouble when destroying the frame because
      of the requirement that each voice frame have an associated format.
      
      ASTERISK-26880 #close
      Reported by: Kirsty Tyerman
      
      Change-Id: I43f8450c48fb276ad8b99db8512be82949c1ca7c
      fc794de7
    • Joshua Colp's avatar
    • Aaron An's avatar
      audiohook.c: Lost RTP packets lead to out-of-sync MixMonitor. · 25016a74
      Aaron An authored
      Fixed a bug in function "ast_audiohook_write_frame" that checked the
      variable other_factory_samples and only flushed the factories, so they
      would be in sync, when other_factory_samples > 0. When there is not any
      rtp incoming the variable other_factory_samples will be 0, and although
      the result of "our_factory_ms - other_factory_ms" may be very large,
      this led to the record file not syncing.
      
      ASTERISK-26875 #close
      Reported-by: Aaron An
      Tested-by: Aaron An
      
      Change-Id: Ia4d890fb8fc1636a7188502bab35f555685aea22
      25016a74
    • zuul's avatar
      Merge "thread safety: Don't use getprotobyname()" · 24ada764
      zuul authored
      24ada764
    • Sean Bright's avatar
      thread safety: Don't use getprotobyname() · fc71c18a
      Sean Bright authored
      POSIX does not require getprotobyname() to be thread safe and some
      implementations use static memory which causes issues when multiple
      threads are used.
      
      Further, our usage of it today is just to ultimately get IPPROTO_TCP
      for calls to setsockopt(). So instead we just use IPPROTO_TCP directly.
      
      Change-Id: I2e14e58674808f7ce99b2f5e900d0f90d0d8da48
      fc71c18a
  6. Mar 19, 2017
  7. Mar 18, 2017
Loading