Skip to content
Snippets Groups Projects
  1. Dec 07, 2017
  2. Dec 06, 2017
  3. Dec 05, 2017
    • Niklas Larsson's avatar
      bridge_basic.c: Update transfer diagnostic messages. · 9d005831
      Niklas Larsson authored
      * Add the channel name to diagnostic messages so you will know which
      channel failed to transfer.
      
      * Promoted some debug messages to verbose 4 messages.
      
      ASTERISK-27449 #close
      
      Change-Id: Idac66b7628c99379cc9269158377fd87dc97a880
      9d005831
  4. Dec 04, 2017
  5. Dec 02, 2017
    • Corey Farrell's avatar
      autoconf: Remove use of m4_ifblank. · 39939cec
      Corey Farrell authored
      The m4_ifblank macro is not available on CentOS 6, reverse conditionals
      to allow use of m4_ifval instead.  ./bootstrap.sh was run but this patch
      does not result in any difference to the generated configure script.
      
      Change-Id: I280785deb872ed8d3339d99cce63a2b54d5f1438
      39939cec
  6. Dec 01, 2017
    • George Joseph's avatar
      AST-2017-013: chan_skinny: Call pthread_detach when sess threads end · 075faac2
      George Joseph authored
      chan_skinny creates a new thread for each new session.  In trying
      to be a good cleanup citizen, the threads are joinable and the
      unload_module function does a pthread_cancel() and a pthread_join()
      on any sessions that are active at that time.  This has an
      unintended side effect though. Since you can call pthread_join on a
      thread that's already terminated, pthreads keeps the thread's
      storage around until you explicitly call pthread_join (or
      pthread_detach()).   Since only the module_unload function was
      calling pthread_join, and even then only on the ones active at the
      tme, the storage for every thread/session ever created sticks
      around until asterisk exits.
      
      * A thread can detach itself so the session_destroy() function
        now calls pthread_detach() just before it frees the session
        memory allocation.  The module_unload function still takes care
        of the ones that are still active should the module be unloaded.
      
      ASTERISK-27452
      Reported by: Juan Sacco
      
      Change-Id: I9af7268eba14bf76960566f891320f97b974e6dd
      (cherry picked from commit 8f5dff54)
      075faac2
    • Sean Bright's avatar
      config: Speed up config template lookup · d9fdeae6
      Sean Bright authored
      ast_category_get() has an (undocumented) implementation detail where it
      tries to match the category name first by an explicit pointer comparison
      and if that fails falls back to a normal match.
      
      When initially building an ast_config during ast_config_load, this
      pointer comparison can never succeed, but we will end up iterating all
      categories twice. As the number of categories using a template
      increases, this dual looping becomes quite expensive. So we pass a flag
      to category_get_sep() indicating if a pointer match is even possible
      before trying to do so, saving us a full pass over the list of current
      categories.
      
      In my tests, loading a file with 3 template categories and 12000
      additional categories that use those 3 templates (this file configures
      4000 PJSIP endpoints with AOR & Auth) takes 1.2 seconds. After this
      change, that drops to 22ms.
      
      Change-Id: I59b95f288e11eb6bb34f31ce4cc772136b275e4a
      d9fdeae6
    • Sean Bright's avatar
      config: Speed up ACO & sorcery initialization · 1ad0fbc8
      Sean Bright authored
      When starting Asterisk in the foreground, there is a perceptible delay
      when loading modules that use the ACO and sorcery config frameworks.
      For example, a lightly configured res_pjsip took 853ms to load on my
      VM.
      
      I tracked down the slowness to the XPath queries used to associate the
      relevant documentation with the config options. One improvement was
      adding a call to xmlXPathOrderDocElems after loading an XML document.
      From the libxml2 docs:
      
        Call this routine to speed up XPath computation on static documents.
      
      The second change was to remove recursive descent and wildcard
      operators from the XPath queries. After these changes, res_pjsip takes
      85ms to load on my VM and there is no longer a perceptible delay when
      starting Asterisk in the foreground.
      
      Change-Id: I45d457f1580e26bf5a2b0dab16e8e9ae46dcbd82
      1ad0fbc8
    • Joshua Colp's avatar
      res_http_post: Not all versions of gmime have GMIME_MAJOR_VERSION. · 892df22c
      Joshua Colp authored
      This change makes the presence of the GMIME_MAJOR_VERSION
      definition optional, as not all versions of gmime actually
      define it.
      
      ASTERISK-27454
      
      Change-Id: I01d99590045971ed6787899147170a5954077238
      892df22c
    • Corey Farrell's avatar
      README-SERIOUSLY.bestpractices.txt: Convert to markdown · 35a7036a
      Corey Farrell authored
      Follow-up to conversion of README.md.
      
      Change-Id: I17ee7cf25bc027ece844efa2c1dfe613aff1e35b
      35a7036a
  7. Nov 30, 2017
  8. Nov 28, 2017
  9. Nov 27, 2017
Loading