Skip to content
Snippets Groups Projects
  1. Nov 13, 2018
  2. Jan 24, 2018
    • Corey Farrell's avatar
      Remove redundant module checks and references. · 527cf5a5
      Corey Farrell authored
      This removes references that are no longer needed due to automatic
      references created by module dependencies.
      
      In addition this removes most calls to ast_module_check as they were
      checking modules which are listed as dependencies.
      
      Change-Id: I332a6e8383d4c72c8e89d988a184ab8320c4872e
      527cf5a5
  3. Jan 15, 2018
    • Corey Farrell's avatar
      loader: Add dependency fields to module structures. · 9cfdb81e
      Corey Farrell authored
      * Declare 'requires' and 'enhances' text fields on module info structure.
      * Rename 'nonoptreq' to 'optional_modules'.
      * Update doxygen comments.
      
      Still need to investigate dependencies among modules I cannot compile.
      
      Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf
      9cfdb81e
  4. Oct 27, 2016
    • Corey Farrell's avatar
      Remove ASTERISK_REGISTER_FILE. · a6e5bae3
      Corey Farrell authored
      ASTERISK_REGISTER_FILE no longer has any purpose so this commit removes
      all traces of it.
      
      Previously exported symbols removed:
      * __ast_register_file
      * __ast_unregister_file
      * ast_complete_source_filename
      
      This also removes the mtx_prof static variable that was declared when
      MTX_PROFILE was enabled.  This variable was only used in lock.c so it
      is now initialized in that file only.
      
      ASTERISK-26480 #close
      
      Change-Id: I1074af07d71f9e159c48ef36631aa432c86f9966
      a6e5bae3
  5. Jun 22, 2016
    • George Joseph's avatar
      test_res_pjsip_scheduler: Add 'depends' on pjproject in MODULEINFO · 3b4f5d13
      George Joseph authored
      Since the file was missing the depends on pjproject, it wasn't
      picking up the pjproject related include path.  If there was no
      system installed pjproject and pjproject-bundled was used, a compile
      would fail because pjsip.h wasn't found.
      
      ASTERISK-26139 #close
      
      Change-Id: I2ee64a999051452bc198c4e2c168c70769cd3757
      3b4f5d13
  6. Apr 14, 2016
    • George Joseph's avatar
      res_pjsip: Add serialized scheduler (res_pjsip/pjsip_scheduler.c) · e83499df
      George Joseph authored
      There are several places that do scheduled tasks or periodic housecleaning,
      each with its own implementation:
      
      * res_pjsip_keepalive has a thread that sends keepalives.
      * pjsip_distributor has a thread that cleans up expired unidentified requests.
      * res_pjsip_registrar_expire has a thread that cleans up expired contacts.
      * res_pjsip_pubsub uses ast_sched directly and then calls ast_sip_push_task.
      * res_pjsip_sdp_rtp also uses ast_sched to send keepalives.
      
      There are also places where we should be doing scheduled work but aren't.
      A good example are the places we have sorcery observers to start registration
      or qualify.  These don't work when changes are made to a backend database
      without a pjsip reload.  We need to check periodically.
      
      As a first step to solving these issues, a new ast_sip_sched facility has
      been created.
      
      ast_sip_sched wraps ast_sched but only uses ast_sched as a scheduled queue.
      When a task is ready to run, ast_sip_task_pusk is called for it. This ensures
      that the task is executed in a PJLIB registered thread and doesn't hold up the
      ast_sched thread so it can immediately continue processing the queue.  The
      serializer used by ast_sip_sched is one of your choosing or a random one from
      the res_pjsip pool if you don't choose one.
      
      Another feature is the ability to automatically clean up the task_data when the
      task expires (if ever).  If it's an ao2 object, it will be dereferenced, if
      it's a malloc'd object it will be freed.  This is selectable when the task is
      scheduled.  Even if you choose to not auto dereference an ao2 task data object,
      the scheduler itself maintains a reference to it while the task is under it's
      control.  This prevents the data from disappearing out from under the task.
      
      There are two scheduling models.
      
      AST_SIP_SCHED_TASK_PERIODIC specifies that the invocations of the task occur at
      the specific interval.  That is, every "interval" milliseconds, regardless of
      how long the task takes.  If the task takes longer than the interval, it will
      be scheduled at the next available multiple of interval.  For exmaple: If the
      task has an interval of 60 secs and the task takes 70 secs (it better not),
      the next invocation will happen at 120 seconds.
      
      AST_SIP_SCHED_TASK_DELAY specifies that the next invocation of the task should
      start "interval" milliseconds after the current invocation has finished.
      
      Also, the same ast_sched facility for fixed or variable intervals exists.  The
      task's return code in conjunction with the AST_SIP_SCHED_TASK_FIXED or
      AST_SIP_SCHED_TASK_VARIABLE flags controls the next invocation start time.
      
      One res_pjsip.h housekeeping change was made.  The pjsip header files were
      added to the top.  There have been a few cases lately where I've needed
      res_pjsip.h just for ast_sip calls and had compiles fail spectacularly because
      I didn't add the pjsip header files to my source even though I never referenced
      any pjsip calls.
      
      Finally, a few new convenience APIs were added to astobj2 to make things a
      little easier in the scheduler.  ao2_ref_and_lock() calls ao2_ref() and
      ao2_lock() in one go.  ao2_unlock_and_unref() does the reverse. A few macros
      were also copied from res_phoneprov because I got tired of having to duplicate
      the same hash, sort and compare functions over and over again. The
      AO2_STRING_FIELD_(HASH|SORT|CMP)_FN macros will insert functions suitable for
      aor_container_alloc into your source.
      
      This facility can be used immediately for the situations where we already have
      a thread that wakes up periodically or do some scheduled work.  For the
      registration and qualify issues, additional sorcery and schema changes would
      need to be made so that we can easily detect changed objects on a periodic
      basis without having to pull the entire database back to check.  I'm thinking
      of a last-updated timestamp on the rows but more on this later.
      
      Change-Id: I7af6ad2b2d896ea68e478aa1ae201d6dd016ba1c
      e83499df
Loading