Skip to content
Snippets Groups Projects
  1. Sep 27, 2018
  2. Sep 26, 2018
  3. Sep 25, 2018
    • Joshua Colp's avatar
      res_rtp_asterisk: Raise event when RTP port is allocated · 8bb26484
      Joshua Colp authored
      This change raises a testsuite event to provide what port
      Asterisk has actually allocated for RTP. This ensures that
      testsuite tests can remove any assumption of ports and instead
      use the actual port in use.
      
      ASTERISK-28070
      
      Change-Id: I91bd45782e84284e01c89acf4b2da352e14ae044
      8bb26484
  4. Sep 24, 2018
  5. Sep 21, 2018
    • Kevin Harwell's avatar
      rtp_engine: rtcp_report_to_json can overflow the ssrc integer value · 31fba4e8
      Kevin Harwell authored
      When writing an RTCP report to json the code attempts to pack the "ssrc" and
      "source_ssrc" unsigned integer values as a signed int value type. This of course
      means if the ssrc's unsigned value is greater than that which can fit into a
      signed integer value it gets converted to a negative number. Subsequently, the
      negative value goes out in the json report.
      
      This patch now packs the value as a json_int_t, which is the widest integer type
      available on a given system. This should make it so the value no longer
      overflows.
      
      Note, this was caught by two failing tests hep/rtcp-receiver/ and
      hep/rtcp-sender.
      
      Change-Id: I2af275286ee5e795b79f0c3d450d9e4b28e958b0
      31fba4e8
    • George Joseph's avatar
      app_voicemail: Fix stack overrun in append_mailbox · 22cf065e
      George Joseph authored
      The append_mailbox function wasn't calculating the correct length
      to pass to ast_alloca and it wasn't handling the case where context
      might be empty.
      
      Found by the Address Sanitizer.
      
      Change-Id: I7eb51c7bd18a7a8dbdba261462a95cc69e84f161
      22cf065e
    • George Joseph's avatar
      channel.c: Address stack overflow in does_id_conflict() · 4d51a8e0
      George Joseph authored
      does_id_conflict() was passing a pointer to an int to a callback
      that expected a pointer to a size_t.
      
      Found by the Address Sanitizer.
      
      Change-Id: I0ff542067eef63a14a60301654d65d34fe2ad503
      4d51a8e0
    • Corey Farrell's avatar
      res_rtp_asterisk: Fix crash on ast_rtp_new failure. · bdc81597
      Corey Farrell authored
      ast_rtp_new free'd rtp upon failure, but rtp_engine.c would also call
      the destroy callback.  Remove call to ast_free from ast_rtp_new, leave
      it to rtp_engine.c to initiate the full cleanup.  Add error detection
      for the ssrc_mapping vector initialization.  In rtp_allocate_transport
      set rtp->s = -1 in the failure path where we close that FD to ensure we
      don't try closing it twice.
      
      ASTERISK-27854 #close
      
      Change-Id: Ie02aecbb46228ca804e24b19cec2bb6f7b94e451
      bdc81597
  6. Sep 20, 2018
  7. Sep 19, 2018
  8. Sep 18, 2018
    • Richard Mudgett's avatar
      stasis_message.c: Don't create immutable stasis objects with locks. · 79e3becc
      Richard Mudgett authored
      * Create the stasis message object without a lock as it is immutable.
      * Create the stasis message type object without a lock as it is immutable.
      * Creating the stasis message type could crash if the passed in type name
      is NULL and REF_DEBUG is enabled.  Added missing NULL check when passing
      the ao2 object tag string.
      
      Change-Id: I28763c58bb9f0b427c11971d0103bf94055e7b32
      79e3becc
    • Joshua Colp's avatar
      pjproject: Upgrade to 2.8. · ce9a980b
      Joshua Colp authored
      This change brings in PJSIP 2.8, removes all the patches
      that were merged upstream, and makes a minor change to
      support a breaking change that was done.
      
      ASTERISK-28059
      
      Change-Id: I5097772b11b0f95c3c1f52df6400158666f0a189
      ce9a980b
    • Florian Floimair's avatar
      alembic: fix suppress_q850_reason_headers column name · 6a1c313f
      Florian Floimair authored
      In the original commit introducing the feature the column in the alembic
      script was called 'suppress_q850_reason_header'.
      In the code however the option is called 'suppress_q850_reason_headers'
      (trailing 's'). This leads to errors when ARI push configuration is used.
      
      Change-Id: Ie84808adbca6fcc9136556e4f5d741adbef5d14f
      6a1c313f
Loading