Skip to content
Snippets Groups Projects
  1. Sep 05, 2017
    • Sean Bright's avatar
      formats: Restore previous fread() behavior · c3a6c8fd
      Sean Bright authored
      Some formats are able to handle short reads while others are not, so
      restore the previous behavior for the format modules so that we don't
      have spurious errors when playing back files.
      
      ASTERISK-27232 #close
      Reported by: Jens T.
      
      Change-Id: Iab7f52b25a394f277566c8a2a4b15a692280a300
      c3a6c8fd
  2. Jun 16, 2017
  3. May 02, 2017
  4. Apr 25, 2017
    • Sean Bright's avatar
      cleanup: Fix fread() and fwrite() error handling · f5b67871
      Sean Bright authored
      Cleaned up some of the incorrect uses of fread() and fwrite(), mostly in
      the format modules. Neither of these functions will ever return a value
      less than 0, which we were checking for in some cases.
      
      I've introduced a fair amount of duplication in the format modules, but
      I plan to change how format modules work internally in a subsequent
      patch set, so this is simply a stop-gap.
      
      Change-Id: I8ca1cd47c20b2c0b72088bd13b9046f6977aa872
      f5b67871
  5. Apr 17, 2017
    • Sean Bright's avatar
      format_wav: Read 16khz wav samples properly · 6c0ab9af
      Sean Bright authored
      When opening a PCM wave file for reading, we aren't tracking the
      frequency of the opened file, so we treat 16khz files as 8khz and do
      half reads.
      
      This patch also cleans up some of the data types and an unnecessarily
      complex `if` expression.
      
      ASTERISK-26613 #close
      Reported by: Vitaly K
      
      Change-Id: I05f8b263058dc573ea8ffe0c62e7964506e11815
      6c0ab9af
  6. Apr 15, 2017
  7. Apr 14, 2017
    • Sean Bright's avatar
      format_pcm: Track actual header size of .au files · be71be7e
      Sean Bright authored
      Sun's Au file format has a minimum data offset 24 bytes, but this
      offset is encoded in each .au file. Instead of assuming the minimum,
      read the actual value and store it for later use.
      
      ASTERISK-20984 #close
      Reported by: Roman S.
      Patches:
      	asterisk-1.8.20.0-au-clicks-2.diff (license #6474) patch
      	uploaded by Roman S.
      
      Change-Id: I524022fb19ff2fd5af2cc2d669d27a780ab2057c
      be71be7e
  8. Apr 12, 2017
    • George Joseph's avatar
      modules: change module LOAD_FAILUREs to LOAD_DECLINES (14) · 6db0939b
      George Joseph authored
      Change-Id: If99e3b4fc2d7e86fc3e61182aa6c835b407ed49e
      6db0939b
    • George Joseph's avatar
      modules: change module LOAD_FAILUREs to LOAD_DECLINES · 747beb1e
      George Joseph authored
      In all non-pbx modules, AST_MODULE_LOAD_FAILURE has been changed
      to AST_MODULE_LOAD_DECLINE.  This prevents asterisk from exiting
      if a module can't be loaded.  If the user wishes to retain the
      FAILURE behavior for a specific module, they can use the "require"
      or "preload-require" keyword in modules.conf.
      
      A new API was added to logger: ast_is_logger_initialized().  This
      allows asterisk.c/check_init() to print to the error log once the
      logger subsystem is ready instead of just to stdout.  If something
      does fail before the logger is initialized, we now print to stderr
      instead of stdout.
      
      Change-Id: I5f4b50623d9b5a6cb7c5624a8c5c1274c13b2b25
      747beb1e
  9. Oct 27, 2016
    • Corey Farrell's avatar
      Remove ASTERISK_REGISTER_FILE. · a6e5bae3
      Corey Farrell authored
      ASTERISK_REGISTER_FILE no longer has any purpose so this commit removes
      all traces of it.
      
      Previously exported symbols removed:
      * __ast_register_file
      * __ast_unregister_file
      * ast_complete_source_filename
      
      This also removes the mtx_prof static variable that was declared when
      MTX_PROFILE was enabled.  This variable was only used in lock.c so it
      is now initialized in that file only.
      
      ASTERISK-26480 #close
      
      Change-Id: I1074af07d71f9e159c48ef36631aa432c86f9966
      a6e5bae3
  10. Sep 29, 2016
  11. Sep 27, 2016
    • George Joseph's avatar
      format_ogg_opus: New format · 40aa2813
      George Joseph authored
      Add Ogg/Opus playback support.
      
      This uses libopusfile in order to be able to read .opus files and play
      them back.
      
      Writing/recording support is not present at this time.
      
      ASTERISK-26409
      
      Change-Id: I8815d23345108d8ca7c0bd640f6a1ce6b4f56955
      (cherry picked from commit daee8bbd5209b4158bc1785eede845a26e6cbeaa)
      40aa2813
  12. Jun 09, 2016
  13. Apr 13, 2015
    • Matt Jordan's avatar
      git migration: Refactor the ASTERISK_FILE_VERSION macro · 4a582616
      Matt Jordan authored
      Git does not support the ability to replace a token with a version
      string during check-in. While it does have support for replacing a
      token on clone, this is somewhat sub-optimal: the token is replaced
      with the object hash, which is not particularly easy for human
      consumption. What's more, in practice, the source file version was often
      not terribly useful. Generally, when triaging bugs, the overall version
      of Asterisk is far more useful than an individual SVN version of a file. As a
      result, this patch removes Asterisk's support for showing source file
      versions.
      
      Specifically, it does the following:
      
      * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
        remove passing the version in with the macro. Other facilities
        than 'core show file version' make use of the file names, such as
        setting a debug level only on a specific file. As such, the act of
        registering source files with the Asterisk core still has use. The
        macro rename now reflects the new macro purpose.
      
      * main/asterisk:
        - Refactor the file_version structure to reflect that it no longer
          tracks a version field.
        - Remove the "core show file version" CLI command. Without the file
          version, it is no longer useful.
        - Remove the ast_file_version_find function. The file version is no
          longer tracked.
        - Rename ast_register_file_version/ast_unregister_file_version to
          ast_register_file/ast_unregister_file, respectively.
      
      * main/manager: Remove value from the Version key of the ModuleCheck
        Action. The actual key itself has not been removed, as doing so would
        absolutely constitute a backwards incompatible change. However, since
        the file version is no longer tracked, there is no need to attempt to
        include it in the Version key.
      
      * UPGRADE: Add notes for:
        - Modification to the ModuleCheck AMI Action
        - Removal of the "core show file version" CLI command
      
      Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
      4a582616
  14. Mar 28, 2015
  15. Jul 25, 2014
  16. Jul 20, 2014
  17. May 09, 2014
  18. Feb 05, 2014
  19. Aug 08, 2013
    • Matthew Jordan's avatar
      Improve disk writes for wav49 format · 16fd65bb
      Matthew Jordan authored
      Writing to a file in the wav49 format performs rather inefficiently. The
      procedure is approximately:
       (1) Write GSM frame to the end of the file
       (2) Seek to the end of the file
       (3) Seek to the header
       (4) Update the file size
       (5) Seek (again) to the end of the file
       (6) Repeat
      
      This pattern negates any attempt to use the stdio buffering setup in
      ast_writefile. It also results in many small writes that require a seek going
      to the disk each second which translates to poor disk performance on certain
      file systems, particularly when there are multiple wav49 files being written
      simultaneously.
      
      (closes issue ASTERISK-19595)
      Reported by: Byron Clark
      Tested by: Byron Clark
      patches:
        gsm_wav_only_update_header_on_close.patch uploaded by byronclark (License 6157)
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@396412 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      16fd65bb
  20. Oct 14, 2012
  21. Aug 30, 2012
    • Matthew Jordan's avatar
      Clean up doxygen warnings · 8018b879
      Matthew Jordan authored
      This patch fixes numerous doxygen warnings across Asterisk.  It also updates
      the makefile to regenerate the doxygen configuration on the local system
      before running doxygen to help prevent warnings/errors on the local system.
      
      Much thanks to Andrew for tackling one of the Asterisk janitor projects!
      
      (issue ASTERISK-20259)
      Reported by: Andrew Latham
      Patches:
        doxygen_partial.diff uploaded by Andrew Latham (license 5985)
        make_progdocs.diff uploaded by Andrew Latham (license 5985)
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@371989 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      8018b879
  22. Jun 07, 2012
  23. Apr 29, 2012
  24. Apr 17, 2012
  25. Apr 16, 2012
  26. Apr 06, 2012
  27. Feb 16, 2012
  28. Feb 14, 2012
  29. Feb 08, 2012
  30. Nov 09, 2011
  31. Jul 29, 2011
  32. Jul 14, 2011
  33. Jul 08, 2011
  34. Jul 07, 2011
  35. May 16, 2011
  36. May 03, 2011
Loading