Skip to content
Snippets Groups Projects
  1. Nov 09, 2023
  2. Oct 03, 2023
  3. Mar 23, 2022
  4. Nov 16, 2021
    • Josh Soref's avatar
      codecs: Spelling fixes · 84556eb9
      Josh Soref authored
      Correct typos of the following word families:
      
      voiced
      denumerator
      codeword
      upsampling
      constructed
      residual
      subroutine
      conditional
      quantizing
      courtesy
      number
      
      ASTERISK-29714
      
      Change-Id: I471fb8086a5277d8f05047fedee22cfa97a4252d
      84556eb9
  5. Nov 15, 2021
    • Josh Soref's avatar
      codecs: Spelling fixes · ccfebc3c
      Josh Soref authored
      Correct typos of the following word families:
      
      voiced
      denumerator
      codeword
      upsampling
      constructed
      residual
      subroutine
      conditional
      quantizing
      courtesy
      number
      
      ASTERISK-29714
      
      Change-Id: I471fb8086a5277d8f05047fedee22cfa97a4252d
      ccfebc3c
  6. Mar 16, 2021
    • Joshua C. Colp's avatar
      xml: Embed module information into core XML documentation. · 60800b03
      Joshua C. Colp authored
      This change embeds the MODULEINFO block of modules
      into the core XML documentation. This provides a shared
      mechanism for use by both menuselect and Asterisk for
      information and a definitive source of truth.
      
      ASTERISK-29335
      
      Change-Id: Ifbfd5c700049cf320a3e45351ac65dd89bc99d90
      60800b03
    • Joshua C. Colp's avatar
      xml: Embed module information into core XML documentation. · 149e5e5b
      Joshua C. Colp authored
      This change embeds the MODULEINFO block of modules
      into the core XML documentation. This provides a shared
      mechanism for use by both menuselect and Asterisk for
      information and a definitive source of truth.
      
      ASTERISK-29335
      
      Change-Id: Ifbfd5c700049cf320a3e45351ac65dd89bc99d90
      149e5e5b
  7. Jan 04, 2021
    • Alexander Traud's avatar
      codecs: Remove test-law. · 80c14f74
      Alexander Traud authored
      This was dead code, test code introduced with Asterisk 13. This was
      found while analyzing ASTERISK_28416 and ASTERISK_29185. This change
      partly fixes, not closes those two issues.
      
      Change-Id: I42d0daa37f6f334c7d86672f06f085858a3f3940
      80c14f74
  8. Nov 18, 2019
    • Kevin Harwell's avatar
      various files - fix some alerts raised by lgtm code analysis · bdd785d3
      Kevin Harwell authored
      This patch fixes several issues reported by the lgtm code analysis tool:
      
      https://lgtm.com/projects/g/asterisk/asterisk
      
      Not all reported issues were addressed in this patch. This patch mostly fixes
      confirmed reported errors, potential problematic code points, and a few other
      "low hanging" warnings or recommendations found in core supported modules.
      These include, but are not limited to the following:
      
      * innapropriate stack allocation in loops
      * buffer overflows
      * variable declaration "hiding" another variable declaration
      * comparisons results that are always the same
      * ambiguously signed bit-field members
      * missing header guards
      
      Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25
      bdd785d3
  9. Sep 08, 2019
  10. Aug 23, 2019
  11. Oct 04, 2018
    • Richard Mudgett's avatar
      codec_speex.c: Cleanup module loading to DECLINE and not FAILURE. · 9f02861d
      Richard Mudgett authored
      If codec_speex fails to register a translator it would cause Asterisk to
      exit instead of continue as a DECLINED module.
      
      * Make unload_module() always return 0.  It is silly to fail unloading if
      any translators we try to unregister were not even registered.
      
      Change-Id: Ia262591f68333dad17673ba7104d11c88096f51a
      9f02861d
  12. Aug 27, 2018
    • Corey Farrell's avatar
      Create --disable-binary-modules option. · a2001c00
      Corey Farrell authored
      This new option can be passed for ./configure or
      ./tests/CI/buildAsterisk.sh to prevent download/install of binary
      modules.
      
      Normally enabling the categories MENUSELECT_CODECS or MENUSELECT_RES
      will result in binary modules being enabled even if the build target is
      incompatible with those modules.  This includes CI scripts which enable
      categories before disabling specific modules.
      
      If more binary modules are offered in the future this will help avoid
      accidentally downloading them if unwanted or incompatible.  Adding a
      binary module will only require creating a new menuselect entry similar
      to the existing ones, it will not be necessary to modify the CI scripts.
      
      Change-Id: I6b1bd1c75a2e48f05b8b8a45b7a7a2d00a079166
      a2001c00
  13. Jun 21, 2018
    • Alexander Traud's avatar
      codecs/ilbc: Compile in Solaris 11. · 7f3882c8
      Alexander Traud authored
      The symbol FS is the sampling frequency. That symbol is not used in Asterisk at
      all and was a copy-and-paste of the iLBC reference code from the IETF RFC.
      However, in Solaris, that symbol is defined by another header already. To
      compile in Solaris, that symbol has to go.
      
      Change-Id: I91ddbe5be7c00069c3a25abd5f58d7b2f04c51b1
      7f3882c8
  14. Mar 27, 2018
    • Joshua Colp's avatar
      res_rtp_asterisk: Add support for raising additional RTCP messages. · e14b0e96
      Joshua Colp authored
      This change extends the existing AST_FRAME_RTCP frame type to be
      able to contain additional RTCP message types, such as feedback
      messages. The payload type is contained in the subclass which allows
      knowing what is in the frame itself.
      
      The RTCP feedback message type is now handled and REMB[1] messages
      are raised with their containing information.
      
      This also fixes a bug where all feedback messages were triggering
      video updates instead of just FIR and FUR.
      
      Finally RTCP frames are now passed up through the Asterisk core to
      what is handling the channel, mapped appropriately in the case of
      bridging, and written to an outgoing stream. Since RTCP frames are
      on a per-stream basis this is only done on multistream capable
      channels.
      
      [1] https://tools.ietf.org/html/draft-alvestrand-rmcat-remb-03
      
      ASTERISK-27758
      ASTERISK-26366
      
      Change-Id: I680da0ad8d5059d5e9655d896fb9d92e9da8491e
      e14b0e96
  15. Feb 12, 2018
    • Alexander Traud's avatar
      codecs: Add support for WebRTC iLBC 2.0. · 97f45d58
      Alexander Traud authored
      When the latest version of that library was installed, Asterisk did not build.
      
      ASTERISK-27669
      Reported by: Николай Михо
      
      Change-Id: I27e09bb875fdd56423bd9fae1be85fddb428eb96
      97f45d58
  16. Jan 09, 2018
  17. Jan 06, 2018
  18. Dec 22, 2017
  19. Dec 11, 2017
  20. Dec 08, 2017
    • Sean Bright's avatar
      utils: Add convenience function for setting fd flags · 2ffe52a1
      Sean Bright authored
      There are many places in the code base where we ignore the return value
      of fcntl() when getting/setting file descriptior flags. This patch
      introduces a convenience function that allows setting or clearing file
      descriptor flags and will also log an error on failure for later
      analysis.
      
      Change-Id: I8b81901e1b1bd537ca632567cdb408931c6eded7
      2ffe52a1
  21. Oct 24, 2017
  22. Apr 13, 2017
  23. Apr 12, 2017
    • George Joseph's avatar
      modules: change module LOAD_FAILUREs to LOAD_DECLINES · 747beb1e
      George Joseph authored
      In all non-pbx modules, AST_MODULE_LOAD_FAILURE has been changed
      to AST_MODULE_LOAD_DECLINE.  This prevents asterisk from exiting
      if a module can't be loaded.  If the user wishes to retain the
      FAILURE behavior for a specific module, they can use the "require"
      or "preload-require" keyword in modules.conf.
      
      A new API was added to logger: ast_is_logger_initialized().  This
      allows asterisk.c/check_init() to print to the error log once the
      logger subsystem is ready instead of just to stdout.  If something
      does fail before the logger is initialized, we now print to stderr
      instead of stdout.
      
      Change-Id: I5f4b50623d9b5a6cb7c5624a8c5c1274c13b2b25
      747beb1e
  24. Mar 27, 2017
  25. Jan 23, 2017
    • Lorenzo Miniero's avatar
      media: Add experimental support for RTCP feedback. · 1061539b
      Lorenzo Miniero authored
      This change adds experimental support for providing RTCP
      feedback information to codec modules so they can dynamically
      change themselves based on conditions.
      
      ASTERISK-26584
      
      Change-Id: Ifd6aa77fb4a7ff546c6025900fc2baf332c31857
      1061539b
  26. Nov 17, 2016
    • Timo Teräs's avatar
      codec_dahdi: Fix poll.h include. · 349e08cb
      Timo Teräs authored
      POSIX defines poll.h. sys/poll.h should not be used as it is c-library
      internal header which may or may not exist. Notably in musl including
      sys/poll.h generates warning of being incorrect.
      
      Change-Id: Ib318c1c7142a737bcf3caa4d8d72560bebe39252
      349e08cb
  27. Oct 27, 2016
    • Corey Farrell's avatar
      Remove ASTERISK_REGISTER_FILE. · a6e5bae3
      Corey Farrell authored
      ASTERISK_REGISTER_FILE no longer has any purpose so this commit removes
      all traces of it.
      
      Previously exported symbols removed:
      * __ast_register_file
      * __ast_unregister_file
      * ast_complete_source_filename
      
      This also removes the mtx_prof static variable that was declared when
      MTX_PROFILE was enabled.  This variable was only used in lock.c so it
      is now initialized in that file only.
      
      ASTERISK-26480 #close
      
      Change-Id: I1074af07d71f9e159c48ef36631aa432c86f9966
      a6e5bae3
  28. Sep 27, 2016
    • George Joseph's avatar
      codec_opus: Add download ability to menuselect · c7ef1e0a
      George Joseph authored
      Updated codecs/codecs.xml to add codec_opus to the external
      download list.
      
      ASTERISK-26409
      
      Change-Id: Ia07b36539f30e852125fb2b94147dc9774df31a4
      (cherry picked from commit 2cdab0e36eec4997ca3bd85aa09efc477038e31c)
      (cherry picked from commit e9684f3acd0e8def0df582c1505dd39dd3fd1610)
      c7ef1e0a
  29. Sep 06, 2016
    • George Joseph's avatar
      build: Add download capability for external packages · 6caf6bcd
      George Joseph authored
      The DPMA and g729a, silk, siren7 and siren14 codecs hosted at
      http://downloads.digium.com/pub/telephony/ are now listed in the
      "External" sections of the "Resource Modules" and "Codec Translators"
      pages in menuselect.  Any that are selected will automatically be
      downloaded and installed when "make install" is run.  Their LICENSE and
      README (if avaialble) files will be installed to
      ASTVARLIBDIR/documentation/thirdparty/<product_name>.
      
      Example use with codecs:
      
      The codecs/codecs.xml file is a menuselect style xml file that lists
      the codecs to be included.  Their support levels are 'external', which
      triggers the download and install, and defaultenabled is no.  Also
      because codec_g729a is actually in a directory named codec_g729 on the
      download server, the newly added 'member_data' element is used to
      override the default of the directory name being the package name.  You
      can use the 'directory_name' attribute to keep default base URL
      (http://downloads.digium.com/pub/telephony/) but use the new directory,
      or you use the 'remote_url' attribute to specify a full URL to the
      download directory.  In this case, you must still follow the same
      subdirectory naming conventions as that used for the packages located
      at 'http://downloads.digium.com/pub/telephony'.
      
      A new configure option '--with-externals-cache' was added and like
      '--with-sounds-cache' it allows the installer to cache tarballs so
      they're not downloaded every time.
      
      To assist with the download and install process, each external package
      now has a manifest.xml file that, among other things, contains a package
      version and checksums for each file in the tarball.  The manifest is
      saved to both the cache directory and ASTMODDIR and together with the
      manifest.xml on the downloads site, tells the install scripts whether
      a download and/or update is needed.
      
      bash and xmlstarlet are required for downloader operation.  If they're
      not installed, the external items in menuselect will be unavailable.
      
      Change-Id: Id3dcf1289ffd3cb0bbd7dfab3cafbb87be60323a
      6caf6bcd
  30. Aug 24, 2016
  31. Aug 09, 2016
  32. Jul 22, 2016
    • Alexander Traud's avatar
      codecs: Add iLBC 20. · 8fb80700
      Alexander Traud authored
      Asterisk already supported iLBC 30. This change adds iLBC 20. Now, Asterisk
      defaults to iLBC 20 but falls back to iLBC 30, when the remote party requests
      this.
      
      ASTERISK-26218 #close
      ASTERISK-26221 #close
      Reported by: Aaron Meriwether
      
      Change-Id: I07f523a3aa1338bb5217a1bf69c1eeb92adedffa
      8fb80700
  33. Dec 08, 2015
  34. Dec 01, 2015
  35. Sep 17, 2015
    • Alexander Traud's avatar
      translate: Fix transcoding while different in frame size. · 077adf48
      Alexander Traud authored
      When Asterisk translates between codecs, each with a different frame size (for
      example between iLBC 30 and Speex-WB), too large frames were created by
      ast_trans_frameout. Now, ast_trans_frameout is called with the correct frame
      length, creating several frames when necessary. Affects all transcoding modules
      which used ast_trans_frameout: GSM, iLBC, LPC10, and Speex.
      
      ASTERISK-25353 #close
      
      Change-Id: I2e229569d73191d66a4e43fef35432db24000212
      077adf48
  36. Jun 05, 2015
    • David M. Lee's avatar
      Fixes for OS X · 9fca378b
      David M. Lee authored
       * Add some type casting so tv_usec can really be a long, instead of
         some strange platform specific type.
      
       * Add some .dylib style files to .gitignore.
      
       * Switch from using -Xlinker to -Wl,. For [reasons unknown][], newer
         versions of GCC, when compiling the Homebrew formula for Asterisk,
         are not properly passing the -Xlinker options to the linker. Given
         that -Wl, does exactly the [same thing][], and does it properly, this
         patch changes the -Xlinker options to use -Wl, instead.
      
       [reasons unknown]: http://bit.ly/1SUbEYx
       [same thing]: https://gcc.gnu.org/onlinedocs/gcc/Link-Options.html
      
      Change-Id: Id5e6b3c6cc86282ea5fca630dc3991137c5bf4dd
      9fca378b
  37. May 14, 2015
    • Corey Farrell's avatar
      MALLOC_DEBUG: Replace WRAP_LIBC_MALLOC with ASTMM_LIBC. · 478fb4a3
      Corey Farrell authored
      There are 3 ways that calls directly to standard allocator functions can
      be dealt with:
      1. Block their use, cause them to generate an error.  This is the default.
      2. Replace them with the Asterisk equivalent function calls.
      3. Leave them alone.
      
      This change allows one of these 3 options to be selected by any source.
      The source just needs to define ASTMM_LIBC to ASTMM_BLOCK, ASTMM_REDIRECT,
      or ASTMM_IGNORE to use option 1, 2 or 3 respectively.  Normally ASTMM_BLOCK
      is the correct option, so it is default when ASTMM_LIBC is not defined.
      In some cases when building 3rd party code it is desirable to have it use
      Asterisk functions, without changing the whole source - ASTMM_REDIRECT
      accomplishes this.  When using 3rd party libraries sometimes a static
      inline function will make use of malloc or free.  In these cases it may
      be unsafe to replace the allocator in the header, as it's possible the
      memory could be freed by the library using standard allocators.  For
      those cases ASTMM_IGNORE is needed.
      
      Change-Id: I8afef4bc7f3b93914263ae27d3a5858b69663fc7
      478fb4a3
  38. May 13, 2015
  39. May 08, 2015
    • Corey Farrell's avatar
      Fix crash in codec_lpc10 when MALLOC_DEBUG is enabled. · f93b3a22
      Corey Farrell authored
      This switches codecs/lpc10/lpcini.c back to including "asterisk.h"
      instead of <stdlib.h>.  lpcini.c allocates memory that is freed by
      codec_lpc10.c, so it is important to use MALLOC_DEBUG allocator.
      Added #define WRAP_LIBC_MALLOC to the start of the source to prevent
      runtime symbol link error's.
      
      Change-Id: I74f63fd09fdeb673ee7753122c3bb4722ab6e1ac
      f93b3a22
Loading