Skip to content
Snippets Groups Projects
  1. Jan 04, 2021
    • Alexander Traud's avatar
      codecs: Remove test-law. · 80c14f74
      Alexander Traud authored
      This was dead code, test code introduced with Asterisk 13. This was
      found while analyzing ASTERISK_28416 and ASTERISK_29185. This change
      partly fixes, not closes those two issues.
      
      Change-Id: I42d0daa37f6f334c7d86672f06f085858a3f3940
      80c14f74
  2. Nov 08, 2019
    • Corey Farrell's avatar
      core: Improve MALLOC_DEBUG for frames. · 8a1f30af
      Corey Farrell authored
      * Pass caller information to frame allocation functions.
      * Disable caching as it interfers with MALLOC_DEBUG reporting.
      * Stop using ast_calloc_cache.
      
      Change-Id: Id343cd80a3db941d2daefde2a060750fea8cd260
      8a1f30af
  3. May 11, 2018
    • Corey Farrell's avatar
      Fix GCC 8 build issues. · b5914d90
      Corey Farrell authored
      This fixes build warnings found by GCC 8.  In some cases format
      truncation is intentional so the warning is just suppressed.
      
      ASTERISK-27824 #close
      
      Change-Id: I724f146cbddba8b86619d4c4a9931ee877995c84
      b5914d90
  4. Dec 22, 2017
  5. Dec 18, 2017
    • Corey Farrell's avatar
      netsock: Remove from Asterisk core. · 064c74e4
      Corey Farrell authored
      This moves netsock.c / netsock.h to the chan_iax2 module.  netsock.h has
      been marked deprecated since 13.0.0, chan_iax2 is the only remaining
      user.
      
      Change-Id: I28c6578043bac18de5ea608e136acec4f83d5dd3
      064c74e4
  6. Nov 11, 2017
    • Richard Mudgett's avatar
      core: Add cache_media_frames debugging option. · 90bb0a3e
      Richard Mudgett authored
      The media frame cache gets in the way of finding use after free errors of
      media frames.  Tools like valgrind and MALLOC_DEBUG don't know when a
      frame is released because it gets put into the cache instead of being
      freed.
      
      * Added the "cache_media_frames" option to asterisk.conf.  Disabling the
      option helps track down media frame mismanagement when using valgrind or
      MALLOC_DEBUG.  The cache gets in the way of determining if the frame is
      used after free and who freed it.  NOTE: This option has no effect when
      Asterisk is compiled with the LOW_MEMORY compile time option enabled
      because the cache code does not exist.
      
      To disable the media frame cache simply disable the cache_media_frames
      option in asterisk.conf and restart Asterisk.
      
      Sample asterisk.conf setting:
      [options]
      cache_media_frames=no
      
      ASTERISK-27413
      
      Change-Id: I0ab2ce0f4547cccf2eb214901835c2d951b78c00
      90bb0a3e
  7. Aug 01, 2017
    • Corey Farrell's avatar
      Fix compiler warnings on Fedora 26 / GCC 7. · 58d03211
      Corey Farrell authored
      GCC 7 has added capability to produce warnings, this fixes most of those
      warnings.  The specific warnings are disabled in a few places:
      
      * app_voicemail.c: truncation of paths more than 4096 chars in many places.
      * chan_mgcp.c: callid truncated to 80 chars.
      * cdr.c: two userfields are combined to cdr copy, fix would break ABI.
      * tcptls.c: ignore use of deprecated method SSLv3_client_method().
      
      ASTERISK-27156 #close
      
      Change-Id: I65f280e7d3cfad279d16f41823a4d6fddcbc4c88
      58d03211
  8. Oct 27, 2016
    • Corey Farrell's avatar
      Remove ASTERISK_REGISTER_FILE. · a6e5bae3
      Corey Farrell authored
      ASTERISK_REGISTER_FILE no longer has any purpose so this commit removes
      all traces of it.
      
      Previously exported symbols removed:
      * __ast_register_file
      * __ast_unregister_file
      * ast_complete_source_filename
      
      This also removes the mtx_prof static variable that was declared when
      MTX_PROFILE was enabled.  This variable was only used in lock.c so it
      is now initialized in that file only.
      
      ASTERISK-26480 #close
      
      Change-Id: I1074af07d71f9e159c48ef36631aa432c86f9966
      a6e5bae3
  9. Apr 13, 2015
    • Matt Jordan's avatar
      git migration: Refactor the ASTERISK_FILE_VERSION macro · 4a582616
      Matt Jordan authored
      Git does not support the ability to replace a token with a version
      string during check-in. While it does have support for replacing a
      token on clone, this is somewhat sub-optimal: the token is replaced
      with the object hash, which is not particularly easy for human
      consumption. What's more, in practice, the source file version was often
      not terribly useful. Generally, when triaging bugs, the overall version
      of Asterisk is far more useful than an individual SVN version of a file. As a
      result, this patch removes Asterisk's support for showing source file
      versions.
      
      Specifically, it does the following:
      
      * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
        remove passing the version in with the macro. Other facilities
        than 'core show file version' make use of the file names, such as
        setting a debug level only on a specific file. As such, the act of
        registering source files with the Asterisk core still has use. The
        macro rename now reflects the new macro purpose.
      
      * main/asterisk:
        - Refactor the file_version structure to reflect that it no longer
          tracks a version field.
        - Remove the "core show file version" CLI command. Without the file
          version, it is no longer useful.
        - Remove the ast_file_version_find function. The file version is no
          longer tracked.
        - Rename ast_register_file_version/ast_unregister_file_version to
          ast_register_file/ast_unregister_file, respectively.
      
      * main/manager: Remove value from the Version key of the ModuleCheck
        Action. The actual key itself has not been removed, as doing so would
        absolutely constitute a backwards incompatible change. However, since
        the file version is no longer tracked, there is no need to attempt to
        include it in the Version key.
      
      * UPGRADE: Add notes for:
        - Modification to the ModuleCheck AMI Action
        - Removal of the "core show file version" CLI command
      
      Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
      4a582616
  10. Dec 17, 2014
  11. Aug 07, 2014
    • Richard Mudgett's avatar
      chan_iax2: Several media format fixes. · ea7d4ab0
      Richard Mudgett authored
      * Fixed the iax.conf bandwidth option.  This is the root cause of
      ASTERISK-24150.
      
      * Added checks in iax2_request() to ensure that there are actual formats
      requested for the new channel to prevent any more fracks from issues like
      ASTERISK-24150.  This is a consequence of the iax.conf bandwidth option
      not working.
      
      * Fixed struct iax2_codec_pref.order member size mismatch issue when
      converting to and from the codec preference order list passed over the
      wire.  In addition the values sent over the wire are now compatible with
      previous Asterisk versions.
      
      * Fixed several issues dealing with the struct iax2_codec_pref members.
      Off-by-one, array limit errors, and the order/framing members always need
      to be updated together.
      
      * Made iax2_request() setup the channel's native format preference order
      according to the user's wishes.  The new media format strategy needs the
      order specified earler.
      
      * Fixed usage of ast_format_compatibility_bitfield2format().  The function
      can return NULL if the bitfield was not associated with a function.
      
      * Deleted dead code iax2_codec_pref_getsize() and
      iax2_codec_pref_setsize().
      
      * Made iax2_parse_allow_disallow() and iax2_codec_pref_string() call
      iax2_codec_pref_to_cap() instead of inlining it.
      
      * Made IAX_CAPABILITY_MEDBANDWIDTH, IAX_CAPABILITY_LOWBANDWIDTH, and
      IAX_CAPABILITY_LOWFREE constants again as they were in Asterisk v1.8.
      
      * Renamed prefs to prefs_global so it won't get confused with the local
      pref versions.
      
      * Fixed too small buffer in handle_cli_iax2_show_peer().
      
      * Fixed ast_cli() calls in handle_cli_iax2_show_peer() to output complete
      lines.
      
      * Changed struct create_addr_info.prefs to be struct iax2_codec_pref as an
      optimization so iax2_request() and iax2_call() do less work.
      
      * Fixed a potential deadlock in ast_iax2_new() on an off-nominal path when
      the pbx could not get started.
      
      * Made set_config() setup a local prefs list along side the local
      capability format bitfield.  Once the config is loaded, then the local
      copies are put into the global versions.
      
      * Fix unininialized codec_buf in function_iaxpeer().
      
      ASTERISK-24150 #close
      Reported by: Scott Griepentrog
      
      Review: https://reviewboard.asterisk.org/r/3890/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@420364 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      ea7d4ab0
  12. Jul 20, 2014
  13. May 09, 2014
  14. Oct 05, 2013
  15. Oct 04, 2013
  16. Sep 04, 2013
  17. Jul 21, 2013
  18. Feb 01, 2013
  19. Jan 31, 2013
    • Sean Bright's avatar
      Move IAX firmware related functionality into separate files. · d6e05d5b
      Sean Bright authored
      This patch is mostly a reorganization of existing code with a few exceptions:
      
      * Added doxygen comments to all of the extracted functions.
      
      * Split reload_firmware(int unload) into iax_firmware_reload() and
        iax_firmware_unload() for readability.
      
      * Create iax_firmware_traverse() to support the 'iax2 show firmware' CLI
        command.
      
      * Renamed iax_check_version() to iax_firmware_get_version() and change its
        arguments and return value so that it returns a success/failure value and sets
        the selected version into an out parameter to avoid confusion with failure and
        version 0.
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@380695 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      d6e05d5b
  20. Jan 29, 2013
Loading