Skip to content
Snippets Groups Projects
  1. Sep 23, 2021
    • Joshua C. Colp's avatar
      ari: Ignore invisible bridges when listing bridges. · 0aac38c0
      Joshua C. Colp authored
      When listing bridges we go through the ones present in
      ARI, get their snapshot, turn it into JSON, and add it
      to the payload we ultimately return.
      
      An invisible "dial bridge" exists within ARI that would
      also try to be added to this payload if the channel
      "create" and "dial" routes were used. This would ultimately
      fail due to invisible bridges having no snapshot
      resulting in the listing of bridges failing.
      
      This change makes it so that the listing of bridges
      ignores invisible ones.
      
      ASTERISK-29668
      
      Change-Id: I14fa4b589b4657d1c2a5226b0f527f45a0cd370a
      0aac38c0
  2. Sep 22, 2021
  3. Sep 21, 2021
    • Naveen Albert's avatar
      app_queue: Fix hint updates for included contexts · 5abf499d
      Naveen Albert authored
      Previously, if custom hints were used with the hint:
      format in app_queue, when device state changes occured,
      app_queue would only do a literal string comparison of
      the context used for the hint in app_queue and the context
      of the hint which just changed state. This caused hints
      to not update and become stale if the context associated
      with the agent included the context which actually changes
      state, essentially completely breaking device state for
      any such agents defined in this manner.
      
      This fix adds an additional check to ensure that included
      contexts are also compared against the context which changed
      state, so that the behavior is correct no matter whether the
      context is specified to app_queue directly or indirectly.
      
      ASTERISK-29578 #close
      
      Change-Id: I8caf2f8da8157ef3d9ea71a8568c1eec95592b78
      5abf499d
    • Sean Bright's avatar
      res_http_media_cache.c: Compare unaltered MIME types. · 02f54e27
      Sean Bright authored
      Rather than stripping parameters from Content-Type headers before
      comparison, first try to compare the whole string. If no match is
      found, strip the parameters and try that way.
      
      ASTERISK-29275 #close
      
      Change-Id: I2963c8ecbb3a9605b78b6421c415108d77a66a0f
      02f54e27
    • Naveen Albert's avatar
      logger: Add custom logging capabilities · 148f8355
      Naveen Albert authored
      Adds the ability for users to log to custom log levels
      by providing custom log level names in logger.conf. Also
      adds a logger show levels CLI command.
      
      ASTERISK-29529
      
      Change-Id: If082703cf81a436ae5a565c75225fa8c0554b702
      148f8355
    • Sean Bright's avatar
      app_externalivr.c: Fix mixed leading whitespace in source code. · 6698753b
      Sean Bright authored
      No functional changes.
      
      Change-Id: I46514152c0af67f395526374aaa847ccd6a85378
      6698753b
  4. Sep 20, 2021
  5. Sep 15, 2021
    • George Joseph's avatar
      pjproject: Add patch to fix trailing whitespace issue in rtpmap · 54a9dbb2
      George Joseph authored
      An issue was found where a particular manufacturer's phones add a
      trailing space to the end of the rtpmap attribute when specifying
      a payload type that has a "param" after the format name and clock
      rate. For example:
      
      a=rtpmap:120 opus/48000/2 \r\n
      
      Because pjmedia_sdp_attr_get_rtpmap currently takes everything after
      the second '/' up to the line end as the param, the space is
      included in future comparisons, which then fail if the param being
      compared to doesn't also have the space.
      
      We now use pj_scan_get() to parse the param part of rtpmap so
      trailing whitespace is automatically stripped.
      
      ASTERISK-29654
      
      Change-Id: Ibd0a4e243a69cde7ba9312275b13ab62ab86bc1b
      54a9dbb2
    • Carlos Oliva's avatar
      app_mp3: Force output to 16 bits in mpg123 · 07c297d0
      Carlos Oliva authored
      In new mpg123 versions (since 1.26) the default output is 32 bits
      Asterisk expects the output in 16 bits, so we force the output to be on 16 bits.
      It will work wit new and old versions of mpg123.
      Thanks Thomas Orgis <thomas-forum@orgis.org> for giving the key!
      
      ASTERISK-29635 #close
      
      Change-Id: I88c7740118b5af4e895bd8b765b68ed5c11fc816
      07c297d0
    • Naveen Albert's avatar
      res_pjsip_caller_id: Add ANI2/OLI parsing · 5b5c358e
      Naveen Albert authored
      Adds parsing of ANI II digits (Originating
      Line Information) to PJSIP, on par with
      what currently exists in chan_sip.
      
      ASTERISK-29472
      
      Change-Id: Ifc938a7a7d45ce33999ebf3656a542226f6d3847
      5b5c358e
    • Naveen Albert's avatar
      app_mf: Add channel agnostic MF sender · b760bad2
      Naveen Albert authored
      Adds a SendMF application and PlayMF manager
      event to send arbitrary R1 MF tones on the
      current or specified channel.
      
      ASTERISK-29496
      
      Change-Id: I5d89afdbccee3f86cc702ed96d882f3d351327a4
      b760bad2
  6. Sep 13, 2021
  7. Sep 10, 2021
    • Sungtae Kim's avatar
      resource_channels.c: Fix external media data option · a1fa8df0
      Sungtae Kim authored
      Fixed the external media creation handle to handle the 'data' option correctly.
      
      ASTERISK-29629
      
      Change-Id: I22e57fe8ebf3d3e08fb2121aa4a8a52cc62e8129
      a1fa8df0
    • Naveen Albert's avatar
      func_strings: Add STRBETWEEN function · b8fc77a3
      Naveen Albert authored
      Adds the STRBETWEEN function, which can be used to insert a
      substring between each character in a string. For instance,
      this can be used to insert pauses between DTMF tones in a
      string of digits.
      
      ASTERISK-29627
      
      Change-Id: Ice23009d4a8e9bb9718d2b2301d405567087d258
      b8fc77a3
    • Sean Bright's avatar
      test_abstract_jb.c: Fix put and put_out_of_order memory leaks. · c4037d4a
      Sean Bright authored
      We can't rely on RAII_VAR(...) to properly clean up data that is
      allocated within a loop.
      
      ASTERISK-27176 #close
      
      Change-Id: Ib575616101230c4f603519114ec62ebf3936882c
      c4037d4a
    • Naveen Albert's avatar
      func_env: Add DIRNAME and BASENAME functions · e0111a56
      Naveen Albert authored
      Adds the DIRNAME and BASENAME functions, which are
      wrappers around the corresponding C library functions.
      These can be used to safely and conveniently work with
      file paths and names in the dialplan.
      
      ASTERISK-29628 #close
      
      Change-Id: Id3aeb907f65c0ff96b6e57751ff0cb49d61db7f3
      e0111a56
    • Naveen Albert's avatar
      func_sayfiles: Retrieve say file names · ddf6299b
      Naveen Albert authored
      Up until now, all of the logic used to translate
      arguments to the Say applications has been
      directly coupled to playback, preventing other
      modules from using this logic.
      
      This refactors code in say.c and adds a SAYFILES
      function that can be used to retrieve the file
      names that would be played. These can then be
      used in other applications or for other purposes.
      
      Additionally, a SayMoney application and a SayOrdinal
      application are added. Both SayOrdinal and SayNumber
      are also expanded to support integers greater than
      one billion.
      
      ASTERISK-29531
      
      Change-Id: If9718c89353b8e153d84add3cc4637b79585db19
      ddf6299b
    • Naveen Albert's avatar
      res_tonedetect: Tone detection module · 7df69633
      Naveen Albert authored
      dsp.c contains arbitrary tone detection functionality
      which is currently only used for fax tone recognition.
      This change makes this functionality publicly
      accessible so that other modules can take advantage
      of this.
      
      Additionally, a WaitForTone and TONE_DETECT app and
      function are included to allow users to do their
      own tone detection operations in the dialplan.
      
      ASTERISK-29546
      
      Change-Id: Ie38c395000f4fd4d04e942e8658e177f8f499b26
      7df69633
    • George Joseph's avatar
      res_snmp: Add -fPIC to _ASTCFLAGS · 448962d0
      George Joseph authored
      With gcc 11, res/res_snmp.c and res/snmp/agent.c need the
      -fPIC option added to its _ASTCFLAGS.
      
      ASTERISK-29634
      
      Change-Id: I34649c85e075fd954e578378fabf798c3f038f50
      448962d0
  8. Sep 09, 2021
    • Sean Bright's avatar
      app_voicemail.c: Ability to silence instructions if greeting is present. · 26fc5f3c
      Sean Bright authored
      There is an option to silence voicemail instructions but it does not
      take into consideration if a recorded greeting exists or not. Add a
      new 'S' option that does that.
      
      ASTERISK-29632 #close
      
      Change-Id: I03f2f043a9beb9d99deab302247e2a8686066fb4
      26fc5f3c
    • Sean Bright's avatar
      term.c: Add support for extended number format terminfo files. · 605dd03b
      Sean Bright authored
      ncurses 6.1 introduced an extended number format for terminfo files
      which the terminfo parsing in Asterisk is not able to parse. This
      results in some TERM values that do support color (screen-256color on
      Ubuntu 20.04 for example) to not get a color console.
      
      ASTERISK-29630 #close
      
      Change-Id: I27a4fcfab502219924af2d6b1c46feba92903cb3
      605dd03b
  9. Sep 08, 2021
    • Jasper Hafkenscheid's avatar
      res_srtp: Disable parsing of not enabled cryptos · c07d5311
      Jasper Hafkenscheid authored
      When compiled without extended srtp crypto suites also disable parsing
      these from received SDP. This prevents using these, as some client
      implementations are not stable.
      
      ASTERISK-29625
      
      Change-Id: I7dafb29be1cdaabdc984002573f4bea87520533a
      c07d5311
    • Sean Bright's avatar
      dns.c: Load IPv6 DNS resolvers if configured. · 695fc3db
      Sean Bright authored
      IPv6 nameserver addresses are stored in different part of the
      __res_state structure, so look there if we appear to have support for
      it.
      
      ASTERISK-28004 #close
      
      Change-Id: I67067077d8a406ee996664518d9c8fbf11f6977d
      695fc3db
    • George Joseph's avatar
      bridge_softmix: Suppress error on topology change failure · 976521c9
      George Joseph authored
      There are conditions under which a failure to change topology
      is expected so there's no need to print an ERROR message.
      
      ASTERISK-29618
      Reported by: Alexander
      
      Change-Id: Idc168b8588e018bf3a23769f08c4ad646086d481
      976521c9
  10. Sep 02, 2021
    • sungtae kim's avatar
      resource_channels.c: Fix wrong external media parameter parse · 79d6d222
      sungtae kim authored
      Fixed ARI external media handler to accept body parameters.
      
      ASTERISK-29622
      
      Change-Id: I49509c48a6cbc0fb4165bfa4f834b5e8b9ace20d
      79d6d222
    • Sean Bright's avatar
      config_options: Handle ACO arrays correctly in generated XML docs. · 5029e78f
      Sean Bright authored
      There are 3 separate changes here but they are all closely related:
      
      * Only try to set matchfield attributes on 'field' nodes
      
      * We need to adjust how we treat the category pointer based on the
        value of the category_match, to avoid memory corruption. We now
        generate a regex-like string when match types other than
        ACO_WHITELIST and ACO_BLACKLIST are used.
      
      * Switch app_agent_pool from ACO_BLACKLIST_ARRAY to
        ACO_BLACKLIST_EXACT since we only have one category we need to
        ignore, not two.
      
      ASTERISK-29614 #close
      
      Change-Id: I7be7bdb1bb9814f942bc6bb4fdd0a55a7b7efe1e
      5029e78f
    • Naveen Albert's avatar
      chan_iax2: Add ANI2/OLI information element · 3072c540
      Naveen Albert authored
      Adds an information element for ANI2 so that
      Originating Line Information can be transmitted
      over IAX2 channels.
      
      ASTERISK-29605 #close
      
      Change-Id: Iaeacdf6ccde18eaff7f776a0f49fee87dcb549d2
      3072c540
    • Mark Murawski's avatar
      pbx_ael: Fix crash and lockup issue regarding 'ael reload' · bbf4f300
      Mark Murawski authored
      Currently pbx_ael does not check if a reload is currently pending
      before proceeding with a reload. This can cause multiple threads to
      operate at the same time on what should be mutex protected data. This
      change adds protection to reloading to ensure only one ael reload is
      executing at a time.
      
      ASTERISK-29609 #close
      
      Change-Id: I5ed392ad226f6e4e7696ad742076d3e45c57af35
      bbf4f300
  11. Sep 01, 2021
    • Naveen Albert's avatar
      app_read: Allow reading # as a digit · 6cc004dc
      Naveen Albert authored
      Allows for the digit # to be read as a digit,
      just like any other DTMF digit, as opposed to
      forcing it to be used as an end of input
      indicator. The default behavior remains
      unchanged.
      
      ASTERISK-18454 #close
      
      Change-Id: I3033432adb9d296ad227e76b540b8b4a2417665b
      6cc004dc
    • Sebastien Duthil's avatar
      res_rtp_asterisk: Automatically refresh stunaddr from DNS · 6fbf55ac
      Sebastien Duthil authored
      This allows the STUN server to change its IP address without having to
      reload the res_rtp_asterisk module.
      
      The refresh of the name resolution occurs first when the module is
      loaded, then recurringly, slightly after the previous DNS answer TTL
      expires.
      
      ASTERISK-29508 #close
      
      Change-Id: I7955a046293f913ba121bbd82153b04439e3465f
      6fbf55ac
  12. Aug 26, 2021
    • Naveen Albert's avatar
      bridge_basic: Change warning to verbose if transfer cancelled · f01a0398
      Naveen Albert authored
      The attended transfer feature will emit a warning if the user
      cancels the transfer or the attended transfer doesn't complete
      for any reason. Changes the warning to a verbose message,
      since nothing is actually wrong here.
      
      ASTERISK-29612 #close
      
      Change-Id: I64c93cdb21360a0a8d45e9cb6db3af8168f66e6d
      f01a0398
  13. Aug 25, 2021
  14. Aug 20, 2021
    • Sarah Autumn's avatar
      sig_analog: Changes to improve electromechanical signalling compatibility · 466eb4a5
      Sarah Autumn authored
      This changeset is intended to address compatibility issues encountered
      when interfacing Asterisk to electromechanical telephone switches that
      implement ANI-B, ANI-C, or ANI-D.
      
      In particular the behaviours that this impacts include:
      
       - FGC-CAMA did not work at all when using MF signaling. Modified the
         switch case block to send calls to the correct part of the
         signaling-handling state machine.
      
       - For FGC-CAMA operation, the delay between called number ST and
         second wink for ANI spill has been made configurable; previously
         all calls were made to wait for one full second.
      
       - After the ANI spill, previous behavior was to require a 'ST' tone
         to advance the call.  This has been changed to allow 'STP' 'ST2P'
         or 'ST3P' as well, for compatibility with ANI-D.
      
       - Store ANI2 (ANI INFO) digits in the CALLERID(ANI2) channel variable.
      
       - For calls with an ANI failure, No. 1 Crossbar switches will send
         forward a single-digit failure code, with no calling number digits
         and no ST pulse to terminate the spill.  I've made the ANI timeout
         configurable so to reduce dead air time on calls with ANI fail.
      
       - ANI info digits configurable.  Modern digital switches will send 2
         digits, but ANI-B sends only a single info digit.  This caused the
         ANI reported by Asterisk to be misaligned.
      
       - Changed a confusing log message to be more informative.
      
      ASTERISK-29518
      
      Change-Id: Ib7e27d987aee4ed9bc3663c57ef413e21b404256
      466eb4a5
    • Andre Barbosa's avatar
      media_cache: Don't lock when curl the remote file · c4839c04
      Andre Barbosa authored
      When playing a remote sound file, which is not in cache, first we need
      to download it with ast_bucket_file_retrieve.
      
      This can take a while if the remote host is slow. The current CURL
      timeout is 180secs, so in extreme situations, it can take 3 minutes to
      return.
      
      Because ast_media_cache_retrieve has a lock on all function, while we
      are waiting for the delayed download, Asterisk is not able to play any
      more files, even the files already cached locally.
      
      ASTERISK-29544 #close
      
      Change-Id: I8d4142b463ae4a1d4c41bff2bf63324821567408
      c4839c04
  15. Aug 19, 2021
    • George Joseph's avatar
      res_pjproject: Allow mapping to Asterisk TRACE level · 84f2bf43
      George Joseph authored
      Allow mapping pjproject log messages to the Asterisk TRACE
      log level.  The defaults were also changes to log pjproject
      levels 3,4 to DEBUG and 5,6 to TRACE.  Previously 3,4,5,6
      all went to DEBUG.
      
      ASTERISK-29582
      
      Change-Id: I859a37a8dec263ed68099709cfbd3e665324c72d
      84f2bf43
Loading