Skip to content
Snippets Groups Projects
  1. Mar 25, 2020
    • Jaco Kroon's avatar
      dahdiras: Only set plugin dahdi.so to pppd if we're running as root. · 4f92dcd6
      Jaco Kroon authored
      Users of this should set plugin dahdi.so in their options file.
      
      ASTERISK-16676
      
      Change-Id: I6d01ad0a10e9fea477876d0941c3f38aac357e91
      4f92dcd6
    • Jaco Kroon's avatar
      dundi: fix NULL dereference. · 40e93b02
      Jaco Kroon authored
      If a negative (error) return is received from dundi_lookup_internal,
      this is not handled correctly when assigning the result to the buffer.
      As such, use a signed integer in the assignment and do a proper
      comparison.
      
      ASTERISK-21205
      
      Change-Id: I5214ebb6491e2bd14f90c7d3ce229da86888f739
      40e93b02
    • Joshua C. Colp's avatar
      res_pjsip_sdp_rtp: Only do hold/unhold on default audio stream. · 34750d20
      Joshua C. Colp authored
      When examining a stream to determine hold/unhold information we
      only care about the default audio stream. Other streams aren't
      used for hold/unhold.
      
      ASTERISK-28784
      
      Change-Id: I7a1f10f07822c4aee1f98a38b9628849b578afe4
      34750d20
    • Sungtae Kim's avatar
      res_pjsip_session: Fixed wrong session termination · 8147f437
      Sungtae Kim authored
      When the Asterisk receives 200 OK with invalid SDP,
      the Asterisk/PJPROJECT terminating the session.
      But if the channel was in the Bridge, Asterisk tries send
      the Re-Invite before terminating the session.
      And when the Asterisk sending the Re-Invite, it doesn't check
      the SDP is NULL or not. This crashes the Asterisk.
      
      Fixed it to close the session correctly if the UAS sends the
      200 OK with wrong SDP.
      
      ASTERISK-28743
      
      Change-Id: Ifa864e0e125b1a7ed2f3abd4164187e1dddc56da
      8147f437
    • Jaco Kroon's avatar
      build: enable building with uClibc · a699e016
      Jaco Kroon authored
      This patch has been included in Gentoo distribution for at least since
      asterisk 1.8, but there are references in the logs going back as far as
      1.0.0 - not sure if this is still required in any way, it does apply,
      and it doesn't (as far as we can determine) cause build failures.
      
      Change-Id: I46d8845e30200205e80580680bf060aa3012ba54
      a699e016
    • Jaco Kroon's avatar
      build: search from newest to oldest for gmime. · f824cd6a
      Jaco Kroon authored
      We (Gentoo distribution) reckon that in the case of multiple versions of
      gmime installed we should prefer the newest one.
      
      Change-Id: Idf7be613230232eb1d573d93c4a5a8297f4ecd2d
      f824cd6a
    • Joshua C. Colp's avatar
      res_pjsip_session: Don't restrict non-audio default streams to sendrecv. · 9620ecbf
      Joshua C. Colp authored
      The state of the default audio stream is used for hold/unhold so we
      restrict it to sendrecv as the core does not handle when it changes as
      a result of hold/unhold.
      
      This restriction does not apply to other media types though so we now
      only restrict it to audio. This allows the other default streams to
      store their state at all values, and not just sendrecv and removed.
      
      ASTERISK-28783
      
      Change-Id: I139740f38cea7f7d92a876ec2631ef50681f6625
      9620ecbf
  2. Mar 20, 2020
    • Michael Neuhauser's avatar
      chan_psip, res_pjsip_sdp_rtp: ignore rtptimeout if direct-media is active · 5562fb2e
      Michael Neuhauser authored
      Do not hang up a PJSIP channel on RTP timeout if that channel is in
      a direct-media bridge. Also reset the time of the last received RTP packet when
      direct-media ends (wait full rtp_timeout period before checking first time after
      audio came back to Asterisk).
      
      ASTERISK-28774
      Reported-by: Michael Neuhauser
      
      Change-Id: I8b62012be7685849e8fb2b1c5dd39d35313ca2d1
      5562fb2e
    • Jaco Kroon's avatar
      res_rtp_asterisk: implement ACL mechanism for ICE and STUN addresses. · 82c3939c
      Jaco Kroon authored
      
      A pure blacklist is not good enough, we need a whitelist mechanism as
      well, and the simplest way to do that is to re-use existing ACL
      infrastructure.
      
      This makes it simpler to blacklist say an entire block (/24) except a
      smaller block (eg, a /29 or even a /32).  Normally you'd need to
      recursively split the block, so if you want to blacklist a /24 except
      for a /29 you'd end up with a blacklit for a /25, /26, /27 and /28.  I
      feel that having an ACL instead of a blacklist only is clearer.
      
      Change-Id: Id57a8df51fcfd3bd85ea67c489c85c6c3ecd7b30
      Signed-off-by: default avatarJaco Kroon <jaco@uls.co.za>
      82c3939c
  3. Mar 17, 2020
    • Jaco Kroon's avatar
      Update main/backtrace.c to deal with changes in binutils 2.34. · 2ad64e97
      Jaco Kroon authored
      binutils 2.34 merged this commit:
      
      https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;\
      	h=fd3619828e94a24a92cddec42cbc0ab33352eeb4
      
      Which effectively does things like:
      
      -#define bfd_section_size(bfd, ptr) ((ptr)->size)
      -#define bfd_get_section_size(ptr) ((ptr)->size)
      
      +#define bfd_section_size(sec) ((sec)->size)
      
      So in order to remain backwards compatible we need to detect this API
      change, and adjust accordingly.  The simplest is to notice that the
      bfd_get_section_size and bfd_get_section_vma MACROs are no longer
      defined, and define then onto the new API.  The alternative is to litter
      the code with a number of #ifdef #else #endif splatters right through
      the code.
      
      Change-Id: I3efe0f8e8f3e338d16fcbc2b26a505367b6e172f
      2ad64e97
    • Sean Bright's avatar
      func_odbc.conf.sample: Clarify sample documentation · c4e09837
      Sean Bright authored
      ASTERISK-20325 #close
      
      Change-Id: I06cb9b467b0fd06c8af2a5aee049f872c09cc4b6
      c4e09837
  4. Mar 13, 2020
    • Sean Bright's avatar
      chan_vpb: Fix 'catching polymorphic type ... by value' error · 49cf8457
      Sean Bright authored
      Fixes the following compile error:
      
          chan_vpb.cc:2688:26: error: catching polymorphic type
              ‘class std::exception’ by value
      
      Change-Id: Ic87bc357d72427d77626735c83200fd278a7a649
      49cf8457
    • Sean Bright's avatar
      dns_txt: Add TXT record parsing support · d68f940f
      Sean Bright authored
      Change-Id: Ie0eca23b8e6f4c7d9846b6013d79099314d90ef5
      d68f940f
    • Joshua C. Colp's avatar
      audiohook: Don't allow audiohooks to attach to hung up channels. · 98d10d0a
      Joshua C. Colp authored
      Given a scenario where MixMonitor was initiated over AMI it
      was possible for the channel and MixMonitor thread to remain
      alive past hang up of the channel. This scenario required
      the AMI initiated MixMonitor to retrieve the channel, a
      hangup to occur on the channel in another thread, and then
      for MixMonitor to actually start. If this occurred the
      MixMonitor thread would remain alive indefinitely and
      the channel reference would remain.
      
      This change ensures that audiohooks are never able to
      be attached to channels that have been hung up. An
      additional fix has also been done in app_mixmonitor to
      properly release the channel reference if this occurs.
      
      ASTERISK-28780
      
      Change-Id: I8044c06daa06f0f16607788c596f55623be26f58
      98d10d0a
    • George Joseph's avatar
      CI: Create generic jenkinsfile · 00a7e4b5
      George Joseph authored
      This is a generic jenkinsfile to build Asterisk and optionally
      perform one or more of the following:
       * Publish the API docs to the wiki
       * Run the Unit tests
       * Run Testsuite Tests
      
      This job can be triggered manually from Jenkins or be triggered
      automatically on a schedule based on a cron string.
      
      Change-Id: Id9d22a778a1916b666e0e700af2b9f1bacda0852
      00a7e4b5
  5. Mar 12, 2020
    • Torrey Searle's avatar
      res_rtp_asterisk: Send correct sender SSRC when p2p bridge in use · a1dba820
      Torrey Searle authored
      bridge_p2p_rtp_write will forward rtp to the bridged rtp instance
      without modifying the ssrc.  However, it is not updating the SSRC
      in the bridged rtp.  Thus, when SSRC packets are generated, they
      have the correct SSRC for the sender.
      
      ASTERISK-28773 #close
      
      Change-Id: I39f923bde28ebb4f0fddc926b92494aed294a478
      a1dba820
  6. Mar 10, 2020
  7. Mar 09, 2020
  8. Mar 06, 2020
    • Sean Bright's avatar
      enum.c: Add support for regular expression flag in NAPTR record · 517224ce
      Sean Bright authored
      A regular expression in a NAPTR response record can have a trailing
      'i' flag to indicate that the expression should be evaluated in a
      case-insensitive way. We were not checking for that flag which caused
      the record parsing to fail on otherwise valid input.
      
      Although this change will initially go into Asterisk 13, 16, and 17,
      it is my intention to replace the majority of this code in 16 and up -
      including this fix - by changing enum.c to consume the new DNS API
      which duplicates most of this logic already. Asterisk 13 doesn't have
      the DNS API, so this fix will be as good as it gets.
      
      ASTERISK-26711 #close
      Reported by: Vitold
      
      Change-Id: I33943a5b3e7539c6dca3a5079982ee15a08186f0
      517224ce
    • Jared Smith's avatar
      indications.conf.sample: Add indication tones for Indonesia · 0a7fe309
      Jared Smith authored
      These tones come from http://www.itu.int/ITU-T/inr/forms/files/tones-0203.pdf
      
      ASTERISK-23407
      
      Change-Id: I48e2285f1e5bb29b3335f762006f66c423d0fcb8
      0a7fe309
  9. Mar 05, 2020
  10. Mar 04, 2020
  11. Mar 03, 2020
    • Kevin Harwell's avatar
      codec negotiation: add incoming_call_offer_prefs option · 06dada3f
      Kevin Harwell authored
      Add a new option, incoming_call_offer_pref, to res_pjsip endpoints that
      specifies the preferred order of codecs after receiving an offer.
      
      This patch does the following:
      
        Adds a new enumeration, ast_sip_call_codec_pref, used by the the new
      configuration option that's added to the endpoint media structure.
      
        Adds a new ast_sip_session_caps structure that's set for each session media
      object.
      
        Creates a new file, res_pjsip_session_caps that "implements" the new
      structure and option, and is compiled into the res_pjsip_session library.
      
      ASTERISK-28756 #close
      
      Change-Id: I35e7a2a0c236cfb6bd9cdf89539f57a1ffefc76f
      06dada3f
    • Joshua C. Colp's avatar
      res_rtp_asterisk: Improve video performance in certain networks. · 87fda066
      Joshua C. Colp authored
      The receive buffer will now grow if we end up flushing the
      receive queue after not receiving the expected packet in time.
      This is done in hopes that if this is encountered again the
      extra buffer size will allow more time to pass and any missing
      packets to be received.
      
      The send buffer will now grow if we are asked for packets and
      can't find them. This is done in hopes that the packets are
      from the past and have simply been expired. If so then in
      the future with the extra buffer space the packets should be
      available.
      
      Sequence number cycling has been handled so that the
      correct sequence number is calculated and used in
      various places, including for sorting packets and
      for determining if a packet is old or not.
      
      NACK sending is now more aggressive. If a substantial number
      of missing sequence numbers are added a NACK will be sent
      immediately. Afterwards once the receive buffer reaches 25%
      a single NACK is sent. If the buffer continues to grow and
      reaches 50% or greater a NACK will be sent for each received
      future packet to aggressively ask the remote endpoint to
      retransmit.
      
      ASTERISK-28764
      
      Change-Id: I97633dfa8a09a7889cef815b2be369f3f0314b41
      87fda066
  12. Mar 02, 2020
    • Kevin Harwell's avatar
      f8a85260
    • Kevin Harwell's avatar
      message & stasis/messaging: make text message variables work in ARI · a715cf5a
      Kevin Harwell authored
      When a text message was received any associated variable was not written to
      the ARI TextMessageReceived event. This occurred because Asterisk only wrote
      out "send" variables. However, even those "send" variables would fail ARI
      validation due to a TextMessageVariable formatting bug.
      
      Since it seems the TextMessageReceived event has never been able to include
      actual variables it was decided to remove the TextMessageVariable object type
      from ARI, and simply return a JSON object of key/value pairs for variables.
      This aligns more with how the ARI sendMessage handles variables, and other
      places in ARI.
      
      ASTERISK-28755 #close
      
      Change-Id: Ia6051c01a53b30cf7edef84c27df4ed4479b8b6f
      a715cf5a
  13. Feb 27, 2020
Loading