Skip to content
Snippets Groups Projects
  1. Apr 13, 2015
    • Matt Jordan's avatar
      git migration: Refactor the ASTERISK_FILE_VERSION macro · 4a582616
      Matt Jordan authored
      Git does not support the ability to replace a token with a version
      string during check-in. While it does have support for replacing a
      token on clone, this is somewhat sub-optimal: the token is replaced
      with the object hash, which is not particularly easy for human
      consumption. What's more, in practice, the source file version was often
      not terribly useful. Generally, when triaging bugs, the overall version
      of Asterisk is far more useful than an individual SVN version of a file. As a
      result, this patch removes Asterisk's support for showing source file
      versions.
      
      Specifically, it does the following:
      
      * Rename ASTERISK_FILE_VERSION macro to ASTERISK_REGISTER_FILE, and
        remove passing the version in with the macro. Other facilities
        than 'core show file version' make use of the file names, such as
        setting a debug level only on a specific file. As such, the act of
        registering source files with the Asterisk core still has use. The
        macro rename now reflects the new macro purpose.
      
      * main/asterisk:
        - Refactor the file_version structure to reflect that it no longer
          tracks a version field.
        - Remove the "core show file version" CLI command. Without the file
          version, it is no longer useful.
        - Remove the ast_file_version_find function. The file version is no
          longer tracked.
        - Rename ast_register_file_version/ast_unregister_file_version to
          ast_register_file/ast_unregister_file, respectively.
      
      * main/manager: Remove value from the Version key of the ModuleCheck
        Action. The actual key itself has not been removed, as doing so would
        absolutely constitute a backwards incompatible change. However, since
        the file version is no longer tracked, there is no need to attempt to
        include it in the Version key.
      
      * UPGRADE: Add notes for:
        - Modification to the ModuleCheck AMI Action
        - Removal of the "core show file version" CLI command
      
      Change-Id: I6cf0ff280e1668bf4957dc21f32a5ff43444a40e
      4a582616
  2. Mar 26, 2015
  3. Mar 17, 2015
  4. Feb 06, 2015
  5. Dec 17, 2014
  6. Nov 06, 2014
  7. Nov 05, 2014
  8. Sep 18, 2014
  9. Aug 27, 2014
  10. Aug 11, 2014
  11. Jul 20, 2014
  12. Jul 18, 2014
  13. Jul 03, 2014
  14. Jun 24, 2014
  15. Jun 12, 2014
    • Richard Mudgett's avatar
      AST-2014-007: Fix DOS by consuming the number of allowed HTTP connections. · 4ca5745d
      Richard Mudgett authored
      Simply establishing a TCP connection and never sending anything to the
      configured HTTP port in http.conf will tie up a HTTP connection.  Since
      there is a maximum number of open HTTP sessions allowed at a time you can
      block legitimate connections.
      
      A similar problem exists if a HTTP request is started but never finished.
      
      * Added http.conf session_inactivity timer option to close HTTP
      connections that aren't doing anything.  Defaults to 30000 ms.
      
      * Removed the undocumented manager.conf block-sockets option.  It
      interferes with TCP/TLS inactivity timeouts.
      
      * AMI and SIP TLS connections now have better authentication timeout
      protection.  Though I didn't remove the bizzare TLS timeout polling code
      from chan_sip.
      
      * chan_sip can now handle SSL certificate renegotiations in the middle of
      a session.  It couldn't do that before because the socket was non-blocking
      and the SSL calls were not restarted as documented by the OpenSSL
      documentation.
      
      * Fixed an off nominal leak of the ssl struct in
      handle_tcptls_connection() if the FILE stream failed to open and the SSL
      certificate negotiations failed.
      
      The patch creates a custom FILE stream handler to give the created FILE
      streams inactivity timeout and timeout after a specific moment in time
      capability.  This approach eliminates the need for code using the FILE
      stream to be redesigned to deal with the timeouts.
      
      This patch indirectly fixes most of ASTERISK-18345 by fixing the usage of
      the SSL_read/SSL_write operations.
      
      ASTERISK-23673 #close
      Reported by: Richard Mudgett
      ........
      
      Merged revisions 415841 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 415854 from http://svn.asterisk.org/svn/asterisk/branches/11
      ........
      
      Merged revisions 415896 from http://svn.asterisk.org/svn/asterisk/branches/12
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@415907 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      4ca5745d
  16. May 09, 2014
  17. Apr 04, 2014
  18. Jan 24, 2014
  19. Nov 23, 2013
    • Kevin Harwell's avatar
      res_pjsip: AMI commands and events. · 05cbf8df
      Kevin Harwell authored
      Created the following AMI commands and corresponding events for res_pjsip:
      
      PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few
                           select attributes on each.
        Events:
          EndpointList - for each endpoint a few attributes.
          EndpointlistComplete - after all endpoints have been listed.
      
      PJSIPShowEndpoint - Provides a detail list of attributes for a specified
                          endpoint.
        Events:
          EndpointDetail - attributes on an endpoint.
          AorDetail - raised for each AOR on an endpoint.
          AuthDetail - raised for each associated inbound and outbound auth
          TransportDetail - transport attributes.
          IdentifyDetail - attributes for the identify object associated with
                           the endpoint.
          EndpointDetailComplete - last event raised after all detail events.
      
      PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound
                                      registrations.
        Events:
          InboundRegistrationDetail - inbound registration attributes for each
                                      registration.
          InboundRegistrationDetailComplete - raised after all detail records have
                                      been listed.
      
      PJSIPShowRegistrationsOutbound  - Provides a detail listing of all outbound
                                        registrations.
        Events:
          OutboundRegistrationDetail - outbound registration attributes for each
                                       registration.
          OutboundRegistrationDetailComplete - raised after all detail records
                                       have been listed.
      
      PJSIPShowSubscriptionsInbound - A detail listing of all inbound subscriptions
                                      and their attributes.
        Events:
          SubscriptionDetail - on each subscription detailed attributes
          SubscriptionDetailComplete - raised after all detail records have
                                       been listed.
      
      PJSIPShowSubscriptionsOutbound - A detail listing of all outboundbound
                                      subscriptions and their attributes.
        Events:
          SubscriptionDetail - on each subscription detailed attributes
          SubscriptionDetailComplete - raised after all detail records have
                                       been listed.
      
      (issue ASTERISK-22609)
      Reported by: Matt Jordan
      Review: https://reviewboard.asterisk.org/r/2959/
      ........
      
      Merged revisions 403131 from http://svn.asterisk.org/svn/asterisk/branches/12
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@403133 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      05cbf8df
  20. Oct 24, 2013
  21. Oct 02, 2013
  22. Sep 09, 2013
  23. Aug 23, 2013
  24. Aug 16, 2013
  25. Aug 15, 2013
  26. Aug 08, 2013
  27. Jul 23, 2013
  28. Jul 04, 2013
  29. Jul 03, 2013
    • David M. Lee's avatar
      ARI - channel recording support · a75fd322
      David M. Lee authored
      This patch is the first step in adding recording support to the
      Asterisk REST Interface.
      
      Recordings are stored in /var/spool/recording. Since recordings may be
      destructive (overwriting existing files), the API rejects attempts to
      escape the recording directory (avoiding issues if someone attempts to
      record to ../../lib/sounds/greeting, for example).
      
      (closes issue ASTERISK-21594)
      (closes issue ASTERISK-21581)
      Review: https://reviewboard.asterisk.org/r/2612/
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@393550 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      a75fd322
    • David M. Lee's avatar
      ARI authentication. · 9ba976b1
      David M. Lee authored
      This patch adds authentication support to ARI.
      
      Two authentication methods are supported. The first is HTTP Basic
      authentication, as specified in RFC 2617[1]. The second is by simply
      passing the username and password as an ?api_key query parameter
      (which allows swagger-ui[2] to authenticate more easily).
      
      ARI usernames and passwords are configured in the ari.conf file
      (formerly known as stasis_http.conf). The user may be set to
      `read_only`, which will prohibit the user from issuing POST, DELETE,
      etc. Also, the user's password may be specified in either plaintext,
      or encrypted using the crypt() function.
      
      Several other notes about the patch.
      
       * A few command line commands for seeing ARI config and status were
         also added.
       * The configuration parsing grew big enough that I extracted it to
         its own file.
      
       [1]: http://www.ietf.org/rfc/rfc2617.txt [2]:
       https://github.com/wordnik/swagger-ui
      
      (closes issue ASTERISK-21277)
      Review: https://reviewboard.asterisk.org/r/2649/
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@393530 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      9ba976b1
  30. Jun 17, 2013
    • Matthew Jordan's avatar
      Update Asterisk's CDRs for the new bridging framework · 6258bbe7
      Matthew Jordan authored
      This patch is the initial push to update Asterisk's CDR engine for the new
      bridging framework. This patch guts the existing CDR engine and builds the new
      on top of messages coming across Stasis. As changes in channel state and bridge
      state are detected, CDRs are built and dispatched accordingly. This
      fundamentally changes CDRs in a few ways.
      (1) CDRs are now *very* reflective of the actual state of channels and bridges.
          This means CDRs track well with what an actual channel is doing - which
          is useful in transfer scenarios (which were previously difficult to pin
          down). It does, however, mean that CDRs cannot be 'fooled'. Previous
          behavior in Asterisk allowed for CDR applications, channels, and other
          properties to be spoofed in parts of the code - this no longer works.
      (2) CDRs have defined behavior in multi-party scenarios. This behavior will not
          be what everyone wants, but it is a defined behavior and as such, it is
          predictable.
      (3) The CDR manipulation functions and applications have been overhauled. Major
          changes have been made to ResetCDR and ForkCDR in particular. Many of the
          options for these two applications no longer made any sense with the new
          framework and the (slightly) more immutable nature of CDRs.
      
      There are a plethora of other changes. For a full description of CDR behavior,
      see the CDR specification on the Asterisk wiki.
      
      (closes issue ASTERISK-21196)
      
      Review: https://reviewboard.asterisk.org/r/2486/
      
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@391947 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      6258bbe7
  31. May 02, 2013
  32. Jan 12, 2013
    • Automerge script's avatar
      Merged revisions 378935 via svnmerge from · f7f7850f
      Automerge script authored
      file:///srv/subversion/repos/asterisk/trunk
      
      ................
        r378935 | dlee | 2013-01-12 00:43:37 -0600 (Sat, 12 Jan 2013) | 41 lines
        
        Fix XML encoding of 'identity display' in NOTIFY messages.
        
        XML encoding in chan_sip is accomplished by naively building the XML
        directly from strings. While this usually works, it fails to take into
        account escaping the reserved characters in XML.
        
        This patch adds an 'ast_xml_escape' function, which works similarly to
        'ast_uri_encode'. This is used to properly escape the local_display
        attribute in XML formatted NOTIFY messages.
        
        Several things to note:
         * The Right Thing(TM) to do would probably be to replace the
           ast_build_string stuff with building an ast_xml_doc. That's a much
           bigger change, and out of scope for the original ticket, so I
           refrained myself.
         * It is with great sadness that I wrote my own ast_xml_escape
           function. There's one in libxml2, but it's knee-deep in
           libxml2-ness, and not easily used to one-off escape a
           string.
         * I only escaped the string we know is causing problems
           (local_display). At least some of the other strings are
           URI-encoded, which should be XML safe. Rather than figuring out
           what's safe and escaping what's not, it would be much cleaner to
           simply build an ast_xml_doc for the messages and let the XML
           library do the XML escaping. Like I said, that's out of scope.
        
        (closes issue ABE-2902)
        Reported by: Guenther Kelleter
        Tested by: Guenther Kelleter
        Review: http://reviewboard.digium.internal/r/365/
        
        ........
        
        Merged revision 378919 from https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
        ........
        
        Merged revisions 378933 from http://svn.asterisk.org/svn/asterisk/branches/1.8
        ........
        
        Merged revisions 378934 from http://svn.asterisk.org/svn/asterisk/branches/11
      ................
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/team/mmichelson/threadpool@378946 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      f7f7850f
    • David M. Lee's avatar
      Fix XML encoding of 'identity display' in NOTIFY messages. · aecd2429
      David M. Lee authored
      XML encoding in chan_sip is accomplished by naively building the XML
      directly from strings. While this usually works, it fails to take into
      account escaping the reserved characters in XML.
      
      This patch adds an 'ast_xml_escape' function, which works similarly to
      'ast_uri_encode'. This is used to properly escape the local_display
      attribute in XML formatted NOTIFY messages.
      
      Several things to note:
       * The Right Thing(TM) to do would probably be to replace the
         ast_build_string stuff with building an ast_xml_doc. That's a much
         bigger change, and out of scope for the original ticket, so I
         refrained myself.
       * It is with great sadness that I wrote my own ast_xml_escape
         function. There's one in libxml2, but it's knee-deep in
         libxml2-ness, and not easily used to one-off escape a
         string.
       * I only escaped the string we know is causing problems
         (local_display). At least some of the other strings are
         URI-encoded, which should be XML safe. Rather than figuring out
         what's safe and escaping what's not, it would be much cleaner to
         simply build an ast_xml_doc for the messages and let the XML
         library do the XML escaping. Like I said, that's out of scope.
      
      (closes issue ABE-2902)
      Reported by: Guenther Kelleter
      Tested by: Guenther Kelleter
      Review: http://reviewboard.digium.internal/r/365/
      
      ........
      
      Merged revision 378919 from https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
      ........
      
      Merged revisions 378933 from http://svn.asterisk.org/svn/asterisk/branches/1.8
      ........
      
      Merged revisions 378934 from http://svn.asterisk.org/svn/asterisk/branches/11
      
      
      git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@378935 65c4cc65-6c06-0410-ace0-fbb531ad65f3
      aecd2429
  33. Dec 13, 2012
  34. Nov 29, 2012
Loading