Skip to content
Snippets Groups Projects
  1. Sep 24, 2018
  2. Sep 21, 2018
    • George Joseph's avatar
      app_voicemail: Fix stack overrun in append_mailbox · 22cf065e
      George Joseph authored
      The append_mailbox function wasn't calculating the correct length
      to pass to ast_alloca and it wasn't handling the case where context
      might be empty.
      
      Found by the Address Sanitizer.
      
      Change-Id: I7eb51c7bd18a7a8dbdba261462a95cc69e84f161
      22cf065e
    • George Joseph's avatar
      channel.c: Address stack overflow in does_id_conflict() · 4d51a8e0
      George Joseph authored
      does_id_conflict() was passing a pointer to an int to a callback
      that expected a pointer to a size_t.
      
      Found by the Address Sanitizer.
      
      Change-Id: I0ff542067eef63a14a60301654d65d34fe2ad503
      4d51a8e0
    • Corey Farrell's avatar
      res_rtp_asterisk: Fix crash on ast_rtp_new failure. · bdc81597
      Corey Farrell authored
      ast_rtp_new free'd rtp upon failure, but rtp_engine.c would also call
      the destroy callback.  Remove call to ast_free from ast_rtp_new, leave
      it to rtp_engine.c to initiate the full cleanup.  Add error detection
      for the ssrc_mapping vector initialization.  In rtp_allocate_transport
      set rtp->s = -1 in the failure path where we close that FD to ensure we
      don't try closing it twice.
      
      ASTERISK-27854 #close
      
      Change-Id: Ie02aecbb46228ca804e24b19cec2bb6f7b94e451
      Unverified
      bdc81597
  3. Sep 20, 2018
  4. Sep 19, 2018
  5. Sep 18, 2018
    • Richard Mudgett's avatar
      stasis_message.c: Don't create immutable stasis objects with locks. · 79e3becc
      Richard Mudgett authored
      * Create the stasis message object without a lock as it is immutable.
      * Create the stasis message type object without a lock as it is immutable.
      * Creating the stasis message type could crash if the passed in type name
      is NULL and REF_DEBUG is enabled.  Added missing NULL check when passing
      the ao2 object tag string.
      
      Change-Id: I28763c58bb9f0b427c11971d0103bf94055e7b32
      79e3becc
    • Joshua Colp's avatar
      pjproject: Upgrade to 2.8. · ce9a980b
      Joshua Colp authored
      This change brings in PJSIP 2.8, removes all the patches
      that were merged upstream, and makes a minor change to
      support a breaking change that was done.
      
      ASTERISK-28059
      
      Change-Id: I5097772b11b0f95c3c1f52df6400158666f0a189
      ce9a980b
    • Florian Floimair's avatar
      alembic: fix suppress_q850_reason_headers column name · 6a1c313f
      Florian Floimair authored
      In the original commit introducing the feature the column in the alembic
      script was called 'suppress_q850_reason_header'.
      In the code however the option is called 'suppress_q850_reason_headers'
      (trailing 's'). This leads to errors when ARI push configuration is used.
      
      Change-Id: Ie84808adbca6fcc9136556e4f5d741adbef5d14f
      6a1c313f
    • George Joseph's avatar
      app_voicemail: Remove need to subscribe to stasis · cdece3b6
      George Joseph authored
      app_voicemail was using the stasis cache to build and maintain a
      list of mailboxes that had subscribers.  It then used this list
      to determine if a mailbox should be polled for new messages if
      polling was enabled.  For this to work, stasis had to cache every
      subscription and unsubscription to the mailbox which caused a lot of
      overhead, both cpu and memory related.
      
      Since polling is only required when changes are being made to
      mailboxes outside of app_voicemail and since the number of mailboxes
      that don't have any subscribers is likely to be very low, all
      mailboxes are now polled instead of just the ones with subscribers.
      
      This paves the way for disabling the caching of stasis subscription
      change messages.
      
      Also fixed cleanup in some of the unit tests that not only left
      test users in the users list but also caused segfaults if the tests
      were run more than once.
      
      ASTERISK-27121
      
      Change-Id: I5cceb737246949f9782955c64425b8bd25a9e9ee
      cdece3b6
    • Joshua Colp's avatar
      res_pjsip_session: Don't add declined stream if one does not exist. · 32a7b9f4
      Joshua Colp authored
      Given a scenario where a session refresh was done with a removed
      stream we would always add a removed stream to the outgoing SDP
      even if one did not already exist.
      
      This change makes it so that a removed stream is only placed into
      the SDP if one already exists.
      
      ASTERISK-28047
      
      Change-Id: Ibb97d21cdeb87a8acae0c720861b0ff255708442
      32a7b9f4
  6. Sep 17, 2018
  7. Sep 16, 2018
  8. Sep 14, 2018
    • Sean Bright's avatar
      res_pjsip: Log IPv6 addresses correctly · 07cb13f7
      Sean Bright authored
      Both pjsip_tx_data.tp_info.dst_name and pjsip_rx_data.pkt_info.src_name
      store IPv6 addresses without enclosing brackets. This causes some log
      output to be confusing because it is difficult to separate the IPv6
      address from a port specification.
      
      * Use pj_sockaddr_print() along with pjsip_tx_data.tp_info.dst_addr and
        pjsip_rx_data.pkt_info.src_addr where possible for consistent IPv6
        output.
      
      * When a pj_sockaddr is not available, explicitly wrap IPv6 addresses
        in brackets.
      
      * When assigning pjsip_rx_data.pkt_info.src_name ourselves, make sure
        to also set pjsip_rx_data.pkt_info.src_addr.
      
      Change-Id: I5cfe997ced7883862a12b9c7d8551d76ae02fcf8
      07cb13f7
    • George Joseph's avatar
      CI: Use proper credentials for Security testsuite checkout · 8be6998f
      George Joseph authored
      Can't do anonymous http checkout from Security-testsuite.
      Need to use same credentials as the gerrit review checkout.
      
      Change-Id: I87af68c995cb8926f5e87f9af245600d76984f05
      8be6998f
Loading